LKML Archive on
help / color / mirror / Atom feed
From: Henrique de Moraes Holschuh <>
To: Gleb Natapov <>
Cc:, "H. Peter Anvin" <>,
	Thomas Gleixner <>,
	Ingo Molnar <>,
Subject: Re: [PATCH] Fix EDD3.0 data verification.
Date: Wed, 2 Feb 2011 11:30:36 -0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, 02 Feb 2011, Gleb Natapov wrote:
> Check for nonzero path in edd_has_edd30() has no sense. First, it looks
> at the wrong memory. Device path starts at offset 30 of the info->params
> structure which is at offset 8 from the beginning of info structure, but
> code looks at info + 4 instead. This was correct when code was introduced,
> but around v2.6.4 three more fields were added to edd_info structure
> (commit 66b61a5c in history.git). Second, even if it will check correct
> memory it will always succeed since at offset 30 (params->key) there will
> be non-zero values otherwise previous check would fail.

Hmm, would that be a reason for boot lockups on some systems ?  I've
seen that happen on Intel D875PBZ and Debian stable (2.6.26).  We
dropped EDD support then.

  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

  reply	other threads:[~2011-02-02 13:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-02 11:21 [PATCH] Fix EDD3.0 data verification Gleb Natapov
2011-02-02 13:30 ` Henrique de Moraes Holschuh [this message]
2011-02-02 13:38   ` Gleb Natapov
2011-02-02 17:14 ` H. Peter Anvin
2011-02-02 17:25   ` Gleb Natapov
2011-02-02 17:29     ` H. Peter Anvin
2011-02-02 17:38       ` Gleb Natapov
2011-02-02 17:59         ` Gleb Natapov
2011-02-02 19:56           ` H. Peter Anvin
2011-02-03 10:04             ` Gleb Natapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).