LKML Archive on
help / color / mirror / Atom feed
From: Gleb Natapov <>
To: "H. Peter Anvin" <>
	Thomas Gleixner <>,
	Ingo Molnar <>,
Subject: Re: [PATCH] Fix EDD3.0 data verification.
Date: Wed, 2 Feb 2011 19:38:27 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Feb 02, 2011 at 09:29:17AM -0800, H. Peter Anvin wrote:
> On 02/02/2011 09:25 AM, Gleb Natapov wrote:
> > According to spec length should be set to 30 on exit.
> I don't really know how this comment relates to the code, but in the
> code I saw a fixed number of bytes being checksummed, which is
> definitely wrong.
What length do you propose to use? If you were referring to
params->length then it is incorrect since it will be always 30 on exit
and this has nothing to do with size we need to checksum. Spec defines
that the sum of bytes 30-73 should be zero. What is definitely wrong
about this?


  reply	other threads:[~2011-02-02 17:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-02 11:21 [PATCH] Fix EDD3.0 data verification Gleb Natapov
2011-02-02 13:30 ` Henrique de Moraes Holschuh
2011-02-02 13:38   ` Gleb Natapov
2011-02-02 17:14 ` H. Peter Anvin
2011-02-02 17:25   ` Gleb Natapov
2011-02-02 17:29     ` H. Peter Anvin
2011-02-02 17:38       ` Gleb Natapov [this message]
2011-02-02 17:59         ` Gleb Natapov
2011-02-02 19:56           ` H. Peter Anvin
2011-02-03 10:04             ` Gleb Natapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).