LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Wolfram Sang <w.sang@pengutronix.de>
To: John Stultz <john.stultz@linaro.org>
Cc: linux-kernel@vger.kernel.org,
	Alessandro Zummo <a.zummo@towertech.it>,
	Marcelo Roberto Jimenez <mroberto@cpti.cetuc.puc-rio.br>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 2/4] RTC: Fix rtc driver ioctl specific shortcutting
Date: Thu, 3 Feb 2011 09:43:09 +0100	[thread overview]
Message-ID: <20110203084309.GA20679@pengutronix.de> (raw)
In-Reply-To: <1296699283-6784-3-git-send-email-john.stultz@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 1058 bytes --]

On Wed, Feb 02, 2011 at 06:14:41PM -0800, John Stultz wrote:
> Some RTC drivers enable functionality directly via their ioctl method
> instead of using the generic ioctl handling code. With the recent
> virtualization of the RTC layer, its now important that the generic
> layer always be used.
> 
> This patch moved the rtc driver ioctl method call to after the generic
> ioctl processing is done. This allows hardware specific features or
> ioctls to still function, while relying on the generic code for handling
> everything else.

I guess the documentation should be updated, too. Currently it says:

Note that many of these ioctls need not actually be implemented by your
driver.  The common rtc-dev interface handles many of these nicely if your
driver returns ENOIOCTLCMD.  Some common examples:
...

That situation has changed after your patch.

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2011-02-03  8:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-03  2:14 [PATCH 0/4] RTC regression fixups John Stultz
2011-02-03  2:14 ` [PATCH 1/4] RTC: Prevents a division by zero in kernel code John Stultz
2011-02-03  2:14 ` [PATCH 2/4] RTC: Fix rtc driver ioctl specific shortcutting John Stultz
2011-02-03  8:43   ` Wolfram Sang [this message]
2011-02-03 19:01     ` John Stultz
2011-02-03  2:14 ` [PATCH 3/4] RTC: Convert rtc drivers to use the alarm_irq_enable method John Stultz
2011-02-03  2:14 ` [PATCH 4/4] RTC: Fix minor compile warning John Stultz
2011-02-03 17:30 ` [PATCH 0/4] RTC regression fixups Marcelo Roberto Jimenez
2011-02-03 19:16   ` John Stultz
2011-02-03 20:31     ` Marcelo Roberto Jimenez
2011-02-03 21:37       ` John Stultz
2011-02-03 22:27         ` john stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110203084309.GA20679@pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=a.zummo@towertech.it \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mroberto@cpti.cetuc.puc-rio.br \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH 2/4] RTC: Fix rtc driver ioctl specific shortcutting' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).