LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* request_region/release_resource
@ 2011-02-03 20:25 Julia Lawall
  2011-02-04 21:38 ` request_region/release_resource Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2011-02-03 20:25 UTC (permalink / raw)
  To: linux-kernel; +Cc: greg

Is there any circumstance in which it is ok to call release_resource on 
the result of calling request(_mem)_region?  One issue is that 
release_resource doesn't free its argument, but then what if the call to 
release_resource is followed by a call to kfree?

Example:
drivers/watchdog/s3c2410_wdt.c, in the function s3c2410wdt_probe

thanks,
julia

^ permalink raw reply	[flat|nested] 2+ messages in thread
* Re: request_region/release_resource
  2011-02-03 20:25 request_region/release_resource Julia Lawall
@ 2011-02-04 21:38 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2011-02-04 21:38 UTC (permalink / raw)
  To: Julia Lawall; +Cc: linux-kernel

On Thu, Feb 03, 2011 at 09:25:15PM +0100, Julia Lawall wrote:
> Is there any circumstance in which it is ok to call release_resource on 
> the result of calling request(_mem)_region?  One issue is that 
> release_resource doesn't free its argument, but then what if the call to 
> release_resource is followed by a call to kfree?

Ick, not nice things I think :(

Care to fix it up?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-04 21:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-03 20:25 request_region/release_resource Julia Lawall
2011-02-04 21:38 ` request_region/release_resource Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).