LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [patch 0/7] frv: Convert to new irq_chip functions
@ 2011-02-06 19:21 Thomas Gleixner
  2011-02-06 19:21 ` [patch 1/7] frv: Remove stale irq_chip.end Thomas Gleixner
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: Thomas Gleixner @ 2011-02-06 19:21 UTC (permalink / raw)
  To: LKML; +Cc: David Howells

This series converts frv to the new irq_chip functions.

I compiled only the affected files, as the whole thing does not build.

Thanks,

	tglx


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [patch 1/7] frv: Remove stale irq_chip.end
  2011-02-06 19:21 [patch 0/7] frv: Convert to new irq_chip functions Thomas Gleixner
@ 2011-02-06 19:21 ` Thomas Gleixner
  2011-02-06 19:21 ` [patch 2/7] frv: Fix typo from __do_IRQ overhaul Thomas Gleixner
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Thomas Gleixner @ 2011-02-06 19:21 UTC (permalink / raw)
  To: LKML; +Cc: David Howells

[-- Attachment #1: frv-remove-stale-irq_chip-end.patch --]
[-- Type: text/plain, Size: 1315 bytes --]

irq_chip.end got obsolete with the removal of __do_IRQ().

irq-mb93093.c even lacks an implementation, but nobody noticed that
it's broken since commit 88d6e1 in 2006.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/frv/kernel/irq-mb93093.c |    1 -
 arch/frv/kernel/irq.c         |    6 ------
 2 files changed, 7 deletions(-)

Index: linux-next/arch/frv/kernel/irq-mb93093.c
===================================================================
--- linux-next.orig/arch/frv/kernel/irq-mb93093.c
+++ linux-next/arch/frv/kernel/irq-mb93093.c
@@ -73,7 +73,6 @@ static struct irq_chip frv_fpga_pic = {
 	.mask		= frv_fpga_mask,
 	.mask_ack	= frv_fpga_mask_ack,
 	.unmask		= frv_fpga_unmask,
-	.end		= frv_fpga_end,
 };
 
 /*
Index: linux-next/arch/frv/kernel/irq.c
===================================================================
--- linux-next.orig/arch/frv/kernel/irq.c
+++ linux-next/arch/frv/kernel/irq.c
@@ -118,18 +118,12 @@ static void frv_cpupic_unmask(unsigned i
 	__clr_MASK(irqlevel);
 }
 
-static void frv_cpupic_end(unsigned int irqlevel)
-{
-	__clr_MASK(irqlevel);
-}
-
 static struct irq_chip frv_cpu_pic = {
 	.name		= "cpu",
 	.ack		= frv_cpupic_ack,
 	.mask		= frv_cpupic_mask,
 	.mask_ack	= frv_cpupic_mask_ack,
 	.unmask		= frv_cpupic_unmask,
-	.end		= frv_cpupic_end,
 };
 
 /*



^ permalink raw reply	[flat|nested] 8+ messages in thread

* [patch 2/7] frv: Fix typo from __do_IRQ overhaul
  2011-02-06 19:21 [patch 0/7] frv: Convert to new irq_chip functions Thomas Gleixner
  2011-02-06 19:21 ` [patch 1/7] frv: Remove stale irq_chip.end Thomas Gleixner
@ 2011-02-06 19:21 ` Thomas Gleixner
  2011-02-06 19:21 ` [patch 3/7] frv: Convert mb93091 irq_chip to new functions Thomas Gleixner
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Thomas Gleixner @ 2011-02-06 19:21 UTC (permalink / raw)
  To: LKML; +Cc: David Howells

[-- Attachment #1: frv-fix-do-irq-fallout.patch --]
[-- Type: text/plain, Size: 600 bytes --]

Compiles way better.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/frv/kernel/irq-mb93093.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-next/arch/frv/kernel/irq-mb93093.c
===================================================================
--- linux-next.orig/arch/frv/kernel/irq-mb93093.c
+++ linux-next/arch/frv/kernel/irq-mb93093.c
@@ -93,7 +93,7 @@ static irqreturn_t fpga_interrupt(int ir
 		irq = 31 - irq;
 		mask &= ~(1 << irq);
 
-		generic_irq_handle(IRQ_BASE_FPGA + irq);
+		generic_handle_irq(IRQ_BASE_FPGA + irq);
 	}
 
 	return IRQ_HANDLED;



^ permalink raw reply	[flat|nested] 8+ messages in thread

* [patch 3/7] frv: Convert mb93091 irq_chip to new functions
  2011-02-06 19:21 [patch 0/7] frv: Convert to new irq_chip functions Thomas Gleixner
  2011-02-06 19:21 ` [patch 1/7] frv: Remove stale irq_chip.end Thomas Gleixner
  2011-02-06 19:21 ` [patch 2/7] frv: Fix typo from __do_IRQ overhaul Thomas Gleixner
@ 2011-02-06 19:21 ` Thomas Gleixner
  2011-02-06 19:21 ` [patch 4/7] frv: Convert mb93093 irq_chip to new function Thomas Gleixner
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Thomas Gleixner @ 2011-02-06 19:21 UTC (permalink / raw)
  To: LKML; +Cc: David Howells

[-- Attachment #1: frv-convert-mb93091-irq-chips.patch --]
[-- Type: text/plain, Size: 1693 bytes --]

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/frv/kernel/irq-mb93091.c |   24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

Index: linux-next/arch/frv/kernel/irq-mb93091.c
===================================================================
--- linux-next.orig/arch/frv/kernel/irq-mb93091.c
+++ linux-next/arch/frv/kernel/irq-mb93091.c
@@ -36,45 +36,45 @@
 /*
  * on-motherboard FPGA PIC operations
  */
-static void frv_fpga_mask(unsigned int irq)
+static void frv_fpga_mask(struct irq_data *d)
 {
 	uint16_t imr = __get_IMR();
 
-	imr |= 1 << (irq - IRQ_BASE_FPGA);
+	imr |= 1 << (d->irq - IRQ_BASE_FPGA);
 
 	__set_IMR(imr);
 }
 
-static void frv_fpga_ack(unsigned int irq)
+static void frv_fpga_ack(struct irq_data *d)
 {
 	__clr_IFR(1 << (irq - IRQ_BASE_FPGA));
 }
 
-static void frv_fpga_mask_ack(unsigned int irq)
+static void frv_fpga_mask_ack(struct irq_data *d)
 {
 	uint16_t imr = __get_IMR();
 
-	imr |= 1 << (irq - IRQ_BASE_FPGA);
+	imr |= 1 << (d->irq - IRQ_BASE_FPGA);
 	__set_IMR(imr);
 
-	__clr_IFR(1 << (irq - IRQ_BASE_FPGA));
+	__clr_IFR(1 << (d->irq - IRQ_BASE_FPGA));
 }
 
-static void frv_fpga_unmask(unsigned int irq)
+static void frv_fpga_unmask(struct irq_data *d)
 {
 	uint16_t imr = __get_IMR();
 
-	imr &= ~(1 << (irq - IRQ_BASE_FPGA));
+	imr &= ~(1 << (d->irq - IRQ_BASE_FPGA));
 
 	__set_IMR(imr);
 }
 
 static struct irq_chip frv_fpga_pic = {
 	.name		= "mb93091",
-	.ack		= frv_fpga_ack,
-	.mask		= frv_fpga_mask,
-	.mask_ack	= frv_fpga_mask_ack,
-	.unmask		= frv_fpga_unmask,
+	.irq_ack	= frv_fpga_ack,
+	.irq_mask	= frv_fpga_mask,
+	.irq_mask_ack	= frv_fpga_mask_ack,
+	.irq_unmask	= frv_fpga_unmask,
 };
 
 /*



^ permalink raw reply	[flat|nested] 8+ messages in thread

* [patch 4/7] frv: Convert mb93093 irq_chip to new function
  2011-02-06 19:21 [patch 0/7] frv: Convert to new irq_chip functions Thomas Gleixner
                   ` (2 preceding siblings ...)
  2011-02-06 19:21 ` [patch 3/7] frv: Convert mb93091 irq_chip to new functions Thomas Gleixner
@ 2011-02-06 19:21 ` Thomas Gleixner
  2011-02-06 19:21 ` [patch 5/7] frv: Convert mb93493 irq_chip to new functions Thomas Gleixner
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Thomas Gleixner @ 2011-02-06 19:21 UTC (permalink / raw)
  To: LKML; +Cc: David Howells

[-- Attachment #1: frv-convert-mb93093-irq-chips.patch --]
[-- Type: text/plain, Size: 1730 bytes --]

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/frv/kernel/irq-mb93093.c |   26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

Index: linux-next/arch/frv/kernel/irq-mb93093.c
===================================================================
--- linux-next.orig/arch/frv/kernel/irq-mb93093.c
+++ linux-next/arch/frv/kernel/irq-mb93093.c
@@ -35,44 +35,44 @@
 /*
  * off-CPU FPGA PIC operations
  */
-static void frv_fpga_mask(unsigned int irq)
+static void frv_fpga_mask(struct irq_data *d)
 {
 	uint16_t imr = __get_IMR();
 
-	imr |= 1 << (irq - IRQ_BASE_FPGA);
+	imr |= 1 << (d->irq - IRQ_BASE_FPGA);
 	__set_IMR(imr);
 }
 
-static void frv_fpga_ack(unsigned int irq)
+static void frv_fpga_ack(struct irq_data *d)
 {
-	__clr_IFR(1 << (irq - IRQ_BASE_FPGA));
+	__clr_IFR(1 << (d->irq - IRQ_BASE_FPGA));
 }
 
-static void frv_fpga_mask_ack(unsigned int irq)
+static void frv_fpga_mask_ack(struct irq_data *d)
 {
 	uint16_t imr = __get_IMR();
 
-	imr |= 1 << (irq - IRQ_BASE_FPGA);
+	imr |= 1 << (d->irq - IRQ_BASE_FPGA);
 	__set_IMR(imr);
 
-	__clr_IFR(1 << (irq - IRQ_BASE_FPGA));
+	__clr_IFR(1 << (d->irq - IRQ_BASE_FPGA));
 }
 
-static void frv_fpga_unmask(unsigned int irq)
+static void frv_fpga_unmask(struct irq_data *d)
 {
 	uint16_t imr = __get_IMR();
 
-	imr &= ~(1 << (irq - IRQ_BASE_FPGA));
+	imr &= ~(1 << (d->irq - IRQ_BASE_FPGA));
 
 	__set_IMR(imr);
 }
 
 static struct irq_chip frv_fpga_pic = {
 	.name		= "mb93093",
-	.ack		= frv_fpga_ack,
-	.mask		= frv_fpga_mask,
-	.mask_ack	= frv_fpga_mask_ack,
-	.unmask		= frv_fpga_unmask,
+	.irq_ack	= frv_fpga_ack,
+	.irq_mask	= frv_fpga_mask,
+	.irq_mask_ack	= frv_fpga_mask_ack,
+	.irq_unmask	= frv_fpga_unmask,
 };
 
 /*



^ permalink raw reply	[flat|nested] 8+ messages in thread

* [patch 5/7] frv: Convert mb93493 irq_chip to new functions
  2011-02-06 19:21 [patch 0/7] frv: Convert to new irq_chip functions Thomas Gleixner
                   ` (3 preceding siblings ...)
  2011-02-06 19:21 ` [patch 4/7] frv: Convert mb93093 irq_chip to new function Thomas Gleixner
@ 2011-02-06 19:21 ` Thomas Gleixner
  2011-02-06 19:21 ` [patch 6/7] frv: Convert cpu " Thomas Gleixner
  2011-02-06 19:22 ` [patch 7/7] frv: Select GENERIC_HARDIRQS_NO_DEPRECATED Thomas Gleixner
  6 siblings, 0 replies; 8+ messages in thread
From: Thomas Gleixner @ 2011-02-06 19:21 UTC (permalink / raw)
  To: LKML; +Cc: David Howells

[-- Attachment #1: frv-convert-mb93493-irq-chips.patch --]
[-- Type: text/plain, Size: 1902 bytes --]

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/frv/kernel/irq-mb93493.c |   22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

Index: linux-next/arch/frv/kernel/irq-mb93493.c
===================================================================
--- linux-next.orig/arch/frv/kernel/irq-mb93493.c
+++ linux-next/arch/frv/kernel/irq-mb93493.c
@@ -45,46 +45,46 @@
  * daughter board PIC operations
  * - there is no way to ACK interrupts in the MB93493 chip
  */
-static void frv_mb93493_mask(unsigned int irq)
+static void frv_mb93493_mask(struct irq_data *d)
 {
 	uint32_t iqsr;
 	volatile void *piqsr;
 
-	if (IRQ_ROUTING & (1 << (irq - IRQ_BASE_MB93493)))
+	if (IRQ_ROUTING & (1 << (d->irq - IRQ_BASE_MB93493)))
 		piqsr = __addr_MB93493_IQSR(1);
 	else
 		piqsr = __addr_MB93493_IQSR(0);
 
 	iqsr = readl(piqsr);
-	iqsr &= ~(1 << (irq - IRQ_BASE_MB93493 + 16));
+	iqsr &= ~(1 << (d->irq - IRQ_BASE_MB93493 + 16));
 	writel(iqsr, piqsr);
 }
 
-static void frv_mb93493_ack(unsigned int irq)
+static void frv_mb93493_ack(struct irq_data *d)
 {
 }
 
-static void frv_mb93493_unmask(unsigned int irq)
+static void frv_mb93493_unmask(struct irq_data *d)
 {
 	uint32_t iqsr;
 	volatile void *piqsr;
 
-	if (IRQ_ROUTING & (1 << (irq - IRQ_BASE_MB93493)))
+	if (IRQ_ROUTING & (1 << (d->irq - IRQ_BASE_MB93493)))
 		piqsr = __addr_MB93493_IQSR(1);
 	else
 		piqsr = __addr_MB93493_IQSR(0);
 
 	iqsr = readl(piqsr);
-	iqsr |= 1 << (irq - IRQ_BASE_MB93493 + 16);
+	iqsr |= 1 << (d->irq - IRQ_BASE_MB93493 + 16);
 	writel(iqsr, piqsr);
 }
 
 static struct irq_chip frv_mb93493_pic = {
 	.name		= "mb93093",
-	.ack		= frv_mb93493_ack,
-	.mask		= frv_mb93493_mask,
-	.mask_ack	= frv_mb93493_mask,
-	.unmask		= frv_mb93493_unmask,
+	.irq_ack	= frv_mb93493_ack,
+	.irq_mask	= frv_mb93493_mask,
+	.irq_mask_ack	= frv_mb93493_mask,
+	.irq_unmask	= frv_mb93493_unmask,
 };
 
 /*



^ permalink raw reply	[flat|nested] 8+ messages in thread

* [patch 6/7] frv: Convert cpu irq_chip to new functions
  2011-02-06 19:21 [patch 0/7] frv: Convert to new irq_chip functions Thomas Gleixner
                   ` (4 preceding siblings ...)
  2011-02-06 19:21 ` [patch 5/7] frv: Convert mb93493 irq_chip to new functions Thomas Gleixner
@ 2011-02-06 19:21 ` Thomas Gleixner
  2011-02-06 19:22 ` [patch 7/7] frv: Select GENERIC_HARDIRQS_NO_DEPRECATED Thomas Gleixner
  6 siblings, 0 replies; 8+ messages in thread
From: Thomas Gleixner @ 2011-02-06 19:21 UTC (permalink / raw)
  To: LKML; +Cc: David Howells

[-- Attachment #1: frv-convertcpu-irq-chips.patch --]
[-- Type: text/plain, Size: 1471 bytes --]

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/frv/kernel/irq.c |   26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

Index: linux-next/arch/frv/kernel/irq.c
===================================================================
--- linux-next.orig/arch/frv/kernel/irq.c
+++ linux-next/arch/frv/kernel/irq.c
@@ -95,35 +95,35 @@ int show_interrupts(struct seq_file *p, 
 /*
  * on-CPU PIC operations
  */
-static void frv_cpupic_ack(unsigned int irqlevel)
+static void frv_cpupic_ack(struct irq_data *d)
 {
-	__clr_RC(irqlevel);
+	__clr_RC(d->irq);
 	__clr_IRL();
 }
 
-static void frv_cpupic_mask(unsigned int irqlevel)
+static void frv_cpupic_mask(struct irq_data *d)
 {
-	__set_MASK(irqlevel);
+	__set_MASK(d->irq);
 }
 
-static void frv_cpupic_mask_ack(unsigned int irqlevel)
+static void frv_cpupic_mask_ack(struct irq_data *d)
 {
-	__set_MASK(irqlevel);
-	__clr_RC(irqlevel);
+	__set_MASK(d->irq);
+	__clr_RC(d->irq);
 	__clr_IRL();
 }
 
-static void frv_cpupic_unmask(unsigned int irqlevel)
+static void frv_cpupic_unmask(struct irq_data *d)
 {
-	__clr_MASK(irqlevel);
+	__clr_MASK(d->irq);
 }
 
 static struct irq_chip frv_cpu_pic = {
 	.name		= "cpu",
-	.ack		= frv_cpupic_ack,
-	.mask		= frv_cpupic_mask,
-	.mask_ack	= frv_cpupic_mask_ack,
-	.unmask		= frv_cpupic_unmask,
+	.irq_ack	= frv_cpupic_ack,
+	.irq_mask	= frv_cpupic_mask,
+	.irq_mask_ack	= frv_cpupic_mask_ack,
+	.irq_unmask	= frv_cpupic_unmask,
 };
 
 /*



^ permalink raw reply	[flat|nested] 8+ messages in thread

* [patch 7/7] frv: Select GENERIC_HARDIRQS_NO_DEPRECATED
  2011-02-06 19:21 [patch 0/7] frv: Convert to new irq_chip functions Thomas Gleixner
                   ` (5 preceding siblings ...)
  2011-02-06 19:21 ` [patch 6/7] frv: Convert cpu " Thomas Gleixner
@ 2011-02-06 19:22 ` Thomas Gleixner
  6 siblings, 0 replies; 8+ messages in thread
From: Thomas Gleixner @ 2011-02-06 19:22 UTC (permalink / raw)
  To: LKML; +Cc: David Howells

[-- Attachment #1: frv-set-nodepr.patch --]
[-- Type: text/plain, Size: 484 bytes --]

All chips converted

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/frv/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Index: linux-next/arch/frv/Kconfig
===================================================================
--- linux-next.orig/arch/frv/Kconfig
+++ linux-next/arch/frv/Kconfig
@@ -6,6 +6,7 @@ config FRV
 	select HAVE_IRQ_WORK
 	select HAVE_PERF_EVENTS
 	select HAVE_GENERIC_HARDIRQS
+	select GENERIC_HARDIRQS_NO_DEPRECATED
 
 config ZONE_DMA
 	bool



^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2011-02-06 19:23 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-06 19:21 [patch 0/7] frv: Convert to new irq_chip functions Thomas Gleixner
2011-02-06 19:21 ` [patch 1/7] frv: Remove stale irq_chip.end Thomas Gleixner
2011-02-06 19:21 ` [patch 2/7] frv: Fix typo from __do_IRQ overhaul Thomas Gleixner
2011-02-06 19:21 ` [patch 3/7] frv: Convert mb93091 irq_chip to new functions Thomas Gleixner
2011-02-06 19:21 ` [patch 4/7] frv: Convert mb93093 irq_chip to new function Thomas Gleixner
2011-02-06 19:21 ` [patch 5/7] frv: Convert mb93493 irq_chip to new functions Thomas Gleixner
2011-02-06 19:21 ` [patch 6/7] frv: Convert cpu " Thomas Gleixner
2011-02-06 19:22 ` [patch 7/7] frv: Select GENERIC_HARDIRQS_NO_DEPRECATED Thomas Gleixner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).