LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Rodolfo Giometti <giometti@enneenne.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: "Anton Vorontsov" <cbouatmailru@gmail.com>,
	"Grazvydas Ignotas" <notasas@gmail.com>,
	linux-kernel@vger.kernel.org, "Pali Rohár" <pali.rohar@gmail.com>
Subject: Re: [PATCH 03/14] POWER: bq27x00: Fix current now property
Date: Mon, 7 Feb 2011 09:07:26 +0100	[thread overview]
Message-ID: <20110207080725.GC6177@enneenne.com> (raw)
In-Reply-To: <1296953291-10373-4-git-send-email-lars@metafoo.de>

On Sun, Feb 06, 2011 at 01:48:00AM +0100, Lars-Peter Clausen wrote:
> From: Pali Rohár <pali.rohar@gmail.com>
> 
> According to the bq27000 datasheet to obtain the current value in Micro-ampere
> from the AI register it has to be transformed by the following formula:
>     current = AI * 3570 / 20
> 
> This patch adjust the drivers code accordingly.
> 
> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
>  drivers/power/bq27x00_battery.c |    7 +++++--
>  1 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/power/bq27x00_battery.c b/drivers/power/bq27x00_battery.c
> index 4f74659..1b06134 100644
> --- a/drivers/power/bq27x00_battery.c
> +++ b/drivers/power/bq27x00_battery.c
> @@ -44,6 +44,8 @@
>  #define BQ27500_FLAG_DSC		BIT(0)
>  #define BQ27500_FLAG_FC			BIT(9)
>  
> +#define BQ27000_RS			20 /* Resistor sense */
> +
>  /* If the system has several batteries we need a different name for each
>   * of them...
>   */
> @@ -149,7 +151,7 @@ static int bq27x00_battery_current(struct bq27x00_device_info *di)
>  
>  	if (di->chip == BQ27500) {
>  		/* bq27500 returns signed value */
> -		curr = (int)(s16)curr;
> +		curr = (int)((s16)curr) * 1000;
>  	} else {
>  		ret = bq27x00_read(BQ27x00_REG_FLAGS, &flags, 0, di);
>  		if (ret < 0) {
> @@ -160,9 +162,10 @@ static int bq27x00_battery_current(struct bq27x00_device_info *di)
>  			dev_dbg(di->dev, "negative current!\n");
>  			curr = -curr;
>  		}
> +		curr = curr * 3570 / BQ27000_RS;
>  	}
>  
> -	return curr * 1000;
> +	return curr;
>  }
>  
>  /*
> -- 
> 1.7.2.3
> 

Acked-by: Rodolfo Giometti <giometti@linux.it>

-- 

GNU/Linux Solutions                  e-mail: giometti@enneenne.com
Linux Device Driver                          giometti@linux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it

  reply	other threads:[~2011-02-07  8:07 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-06  0:47 [PATCH 00/14] POWER: BQ27x00: New Properties, fixes, bq27000 support Lars-Peter Clausen
2011-02-06  0:47 ` [PATCH 01/14] POWER: bq27x00: Add type property Lars-Peter Clausen
2011-02-06 16:43   ` Rodolfo Giometti
2011-02-06  0:47 ` [PATCH 02/14] POWER: bq27x00: Improve temperature precession Lars-Peter Clausen
2011-02-07  8:06   ` Rodolfo Giometti
2011-02-06  0:48 ` [PATCH 03/14] POWER: bq27x00: Fix current now property Lars-Peter Clausen
2011-02-07  8:07   ` Rodolfo Giometti [this message]
2011-02-06  0:48 ` [PATCH 04/14] POWER: bq27x00: Return -ENODEV for properties if the battery is not present Lars-Peter Clausen
2011-02-06 16:40   ` Rodolfo Giometti
2011-02-06  0:48 ` [PATCH 05/14] POWER: bq27x00: Prepare code for addition of bq27000 platform driver Lars-Peter Clausen
2011-02-07  8:09   ` Rodolfo Giometti
2011-02-06  0:48 ` [PATCH 06/14] POWER: bq27x00: Add bq27000 support Lars-Peter Clausen
2011-02-06  0:48 ` [PATCH 07/14] POWER: bq27X00: Cache battery registers Lars-Peter Clausen
2011-02-06  0:48 ` [PATCH 08/14] POWER: bq27x00: Poll battery state Lars-Peter Clausen
2011-02-06  0:48 ` [PATCH 09/14] POWER: bq27x00: Add new properties Lars-Peter Clausen
2011-02-06  0:48 ` [PATCH 10/14] POWER: bq27x00: Add MODULE_DEVICE_TABLE Lars-Peter Clausen
2011-02-06 16:49   ` Rodolfo Giometti
2011-02-06  0:48 ` [PATCH 11/14] POWER: bq27x00: Give more specific reports on battery status Lars-Peter Clausen
2011-02-06 16:38   ` Rodolfo Giometti
2011-02-06  0:48 ` [PATCH 12/14] POWER: bq27x00: Minor cleanups Lars-Peter Clausen
2011-02-06  0:48 ` [PATCH 13/14] POWER: bq27x00: Cleanup bq27x00_i2c_read Lars-Peter Clausen
2011-02-06  0:48 ` [PATCH 14/14] POWER: Ignore -ENODATA errors when generating a uevent Lars-Peter Clausen
2011-02-06 22:47 ` [PATCH 00/14] POWER: BQ27x00: New Properties, fixes, bq27000 support Felipe Contreras
2011-02-06 23:09   ` Lars-Peter Clausen
2011-02-07  0:00     ` Felipe Contreras
2011-02-07  0:12       ` Lars-Peter Clausen
2011-02-07 10:52     ` Pali Rohár
2011-02-07  0:58 ` Grazvydas Ignotas
2011-02-07  1:30   ` Lars-Peter Clausen
2011-02-08 11:40     ` Grazvydas Ignotas
2011-02-08 16:13       ` Lars-Peter Clausen
2011-02-08 16:28         ` Anton Vorontsov
2011-02-08 17:09           ` Lars-Peter Clausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110207080725.GC6177@enneenne.com \
    --to=giometti@enneenne.com \
    --cc=cbouatmailru@gmail.com \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=notasas@gmail.com \
    --cc=pali.rohar@gmail.com \
    --subject='Re: [PATCH 03/14] POWER: bq27x00: Fix current now property' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).