LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] platform/x86: ideapad-laptop depends on INPUT
@ 2011-01-20 20:48 Randy Dunlap
  2011-02-07 19:40 ` Matthew Garrett
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2011-01-20 20:48 UTC (permalink / raw)
  To: lkml, platform-driver-x86; +Cc: akpm, David Woodhouse, Matthew Garrett

From: Randy Dunlap <randy.dunlap@oracle.com>

Most platform/x86 drivers that use INPUT_SPARSEKMAP also depend on INPUT,
so do the same for ideapad-laptop.  This fixes a kconfig warning and
subsequent build errors when CONFIG_INPUT is disabled.

warning: (ACER_WMI && ASUS_LAPTOP && DELL_WMI && HP_WMI && PANASONIC_LAPTOP && IDEAPAD_LAPTOP && EEEPC_LAPTOP && EEEPC_WMI && MSI_WMI && TOPSTAR_LAPTOP && ACPI_TOSHIBA) selects INPUT_SPARSEKMAP which has unmet direct dependencies (!S390 && INPUT)

ERROR: "input_free_device" [drivers/platform/x86/ideapad-laptop.ko] undefined!
ERROR: "input_register_device" [drivers/platform/x86/ideapad-laptop.ko] undefined!
ERROR: "sparse_keymap_setup" [drivers/platform/x86/ideapad-laptop.ko] undefined!
ERROR: "input_allocate_device" [drivers/platform/x86/ideapad-laptop.ko] undefined!
ERROR: "input_unregister_device" [drivers/platform/x86/ideapad-laptop.ko] undefined!
ERROR: "sparse_keymap_free" [drivers/platform/x86/ideapad-laptop.ko] undefined!
ERROR: "sparse_keymap_report_event" [drivers/platform/x86/ideapad-laptop.ko] undefined!

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Matthew Garrett <mjg@redhat.com>
Cc: platform-driver-x86@vger.kernel.org
---
 drivers/platform/x86/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- lnx-2638-rc1.orig/drivers/platform/x86/Kconfig
+++ lnx-2638-rc1/drivers/platform/x86/Kconfig
@@ -227,7 +227,7 @@ config SONYPI_COMPAT
 config IDEAPAD_LAPTOP
 	tristate "Lenovo IdeaPad Laptop Extras"
 	depends on ACPI
-	depends on RFKILL
+	depends on RFKILL && INPUT
 	select INPUT_SPARSEKMAP
 	help
 	  This is a driver for the rfkill switches on Lenovo IdeaPad netbooks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] platform/x86: ideapad-laptop depends on INPUT
  2011-01-20 20:48 [PATCH] platform/x86: ideapad-laptop depends on INPUT Randy Dunlap
@ 2011-02-07 19:40 ` Matthew Garrett
  0 siblings, 0 replies; 2+ messages in thread
From: Matthew Garrett @ 2011-02-07 19:40 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: lkml, platform-driver-x86, akpm, David Woodhouse

Appled, thanks.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-02-07 19:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-20 20:48 [PATCH] platform/x86: ideapad-laptop depends on INPUT Randy Dunlap
2011-02-07 19:40 ` Matthew Garrett

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).