LKML Archive on
help / color / mirror / Atom feed
From: David Miller <>
Subject: Re: [PATCH] pch_gbe: Fix the issue that the receiving data is not normal.
Date: Tue, 08 Feb 2011 16:35:22 -0800 (PST)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

From: Toshiharu Okada <>
Date: Tue, 08 Feb 2011 17:24:10 +0900

> Hi Devid
> I resubmit this patch modified.
> Please check them.

Your memcpy+memcpy sequences are equivalent to memmove(), please
use that instead.

I have to say this function is insanely complicated.  There seems
to be 16 different ways RX packets are processed.  I can't believe
that is needs to be like this.

  reply	other threads:[~2011-02-09  0:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-08  8:24 Toshiharu Okada
2011-02-09  0:35 ` David Miller [this message]
2011-02-09  4:58   ` Toshiharu Okada
  -- strict thread matches above, loose matches on Subject: below --
2011-01-24  4:43 Toshiharu Okada
2011-01-25 21:32 ` David Miller
2011-01-27  8:45   ` Toshiharu Okada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] pch_gbe: Fix the issue that the receiving data is not normal.' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).