LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: Anton Chikin <kverlin@gmail.com>,
	jkosina@suse.cz, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Anton Chikin <anton.chikin@dataart.com>
Subject: Re: [PATCH] HID: added new driver for Panasonic Elite Panaboard UB-T780 and UB-T880
Date: Tue, 8 Feb 2011 10:12:04 -0800	[thread overview]
Message-ID: <20110208181204.GF4476@core.coreip.homeip.net> (raw)
In-Reply-To: <20110208103923.GA2009@polaris.bitmath.org>

On Tue, Feb 08, 2011 at 11:39:23AM +0100, Henrik Rydberg wrote:
> 
> > +int xold = 0, yold = 0;
> 
> static
> 

Not even that. This is an USB device, not a platform one, so it shoudl
be opssible to connect more than one to a box. All state should go into
per-device structure.

This is also does not appear to be a HID driver, really - it does not
use HID infrastucture but does custom parsing.

Calibration - normally we offload this task to userspace (tslib
or other library/driver).

Thanks.

-- 
Dmitry

  parent reply	other threads:[~2011-02-08 18:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-08  9:36 Anton Chikin
2011-02-08 10:39 ` Henrik Rydberg
2011-02-08 12:28   ` Anton Chikin
2011-02-08 13:54   ` Anton Chikin
2011-02-08 18:12   ` Dmitry Torokhov [this message]
2011-02-09 11:40     ` Anton Chikin
  -- strict thread matches above, loose matches on Subject: below --
2011-02-07 16:28 Anton Chikin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110208181204.GF4476@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=anton.chikin@dataart.com \
    --cc=jkosina@suse.cz \
    --cc=kverlin@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rydberg@euromail.se \
    --subject='Re: [PATCH] HID: added new driver for Panasonic Elite Panaboard UB-T780 and UB-T880' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).