LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Andres Salomon <dilinger@queued.net>
Cc: Dan Carpenter <error27@gmail.com>,
	devel@driverdev.osuosl.org, jon.nettleton@gmail.com,
	gregkh@suse.de, linux-kernel@vger.kernel.org, cjb@laptop.org
Subject: Re: [PATCH RFC] staging: olpc_dcon: Remove _strtoul() function.
Date: Wed, 9 Feb 2011 12:04:34 -0800	[thread overview]
Message-ID: <20110209200434.GA30192@kroah.com> (raw)
In-Reply-To: <20110208094020.44f0fe88@queued.net>

On Tue, Feb 08, 2011 at 09:40:20AM -0800, Andres Salomon wrote:
> On Tue, 8 Feb 2011 14:23:54 +0300
> Dan Carpenter <error27@gmail.com> wrote:
> 
> > On Tue, Feb 08, 2011 at 12:06:00PM +0100, Marek Belisko wrote:
> > > olpc_dcon driver use self invented _strtoul  function
> > > which make similar check like strict_strtoul just extend
> > > for space checking at last string place. Normally access
> > > to sys file looks echo 1024 > /sys/... so space could be considered
> > > as error character and we could simplify code using just
> > > strict_strtoul function instead self invented.
> > > 
> > 
> > Could you do it on top of the patches that Andres Salomon sent?
> > 
> 
> Actually, I have more pending patches.  I can add this to the patchset
> and send it later.  Greg, please don't merge it now, though.

Ok, I've ignored it for now.

      reply	other threads:[~2011-02-09 20:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-08 11:06 Marek Belisko
2011-02-08 11:23 ` Dan Carpenter
2011-02-08 12:02   ` Belisko Marek
2011-02-08 17:40   ` Andres Salomon
2011-02-09 20:04     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110209200434.GA30192@kroah.com \
    --to=greg@kroah.com \
    --cc=cjb@laptop.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=dilinger@queued.net \
    --cc=error27@gmail.com \
    --cc=gregkh@suse.de \
    --cc=jon.nettleton@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH RFC] staging: olpc_dcon: Remove _strtoul() function.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).