LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Andy Walls <awalls@md.metrocast.net>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	stoth@kernellabs.com
Subject: Re: cx23885-input.c does in fact use a workqueue....
Date: Tue, 15 Feb 2011 10:12:39 +0100	[thread overview]
Message-ID: <20110215091239.GD3160@htj.dyndns.org> (raw)
In-Reply-To: <1297731276.2394.19.camel@localhost>

Hello,

On Mon, Feb 14, 2011 at 07:54:36PM -0500, Andy Walls wrote:
> > 1. Just flush the work items explicitly using flush_work_sync().
> 
> That will do for now.
> 
> > 2. Create a dedicated workqueue to serve as flushing domain.
> 
> I have gotten reports of the IR Rx FIFO overflows for the CX23885 IR Rx
> unit (the I2C connected one).  I eventually should either set the Rx
> FIFO service interrupt watermark down from 4 measurments to 1
> measurment, or use a kthread_worker with some higher priority to respond
> to the IR Rx FIFO service interrupt. 

Hmmm... please consider playing with WQ_HIGHPRI before going forward
with dedicated thread.

> > The first would look like the following.  Does this look correct?
> 
> Yes, your patch below looks sane to me.
> 
> Reviewed-by: Andy Walls <awalls@md.metrocast.net>

Thanks.  Will send patch with proper description soon.

-- 
tejun

  reply	other threads:[~2011-02-15  9:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-14  1:35 Andy Walls
2011-02-14  4:33 ` Dmitry Torokhov
2011-02-14 11:03   ` Tejun Heo
2011-02-15  0:54     ` Andy Walls
2011-02-15  9:12       ` Tejun Heo [this message]
2011-02-15  9:20       ` [PATCH] cx23885: restore flushes of cx23885_dev work items Tejun Heo
2011-02-15 20:00         ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110215091239.GD3160@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=awalls@md.metrocast.net \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=stoth@kernellabs.com \
    --subject='Re: cx23885-input.c does in fact use a workqueue....' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).