LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* char/ipmi: cleanup_one_si section mismatch
@ 2011-02-14 15:03 Sergey Senozhatsky
  2011-02-14 23:29 ` Corey Minyard
  0 siblings, 1 reply; 4+ messages in thread
From: Sergey Senozhatsky @ 2011-02-14 15:03 UTC (permalink / raw)
  To: Grant Likely
  Cc: Corey Minyard, openipmi-developer, linux-kernel, Peter Huewe,
	Randy Dunlap

Hello,

commit d2478521afc20227658a10a8c5c2bf1a2aa615b3
Author: Corey Minyard <minyard@acm.org>
Date:   Thu Feb 10 16:08:38 2011 -0600

    char/ipmi: fix OOPS caused by pnp_unregister_driver on unregistered driver


Introduced section mismatch by calling __exit cleanup_ipmi_si 
from __devinit init_ipmi_si. Should we remove __exit annotation then?


---

 drivers/char/ipmi/ipmi_si_intf.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index 7855f9f..94cd2ce 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -3532,7 +3532,7 @@ static void cleanup_one_si(struct smi_info *to_clean)
 	kfree(to_clean);
 }
 
-static void __exit cleanup_ipmi_si(void)
+static void cleanup_ipmi_si(void)
 {
 	struct smi_info *e, *tmp_e;
 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: char/ipmi: cleanup_one_si section mismatch
  2011-02-14 15:03 char/ipmi: cleanup_one_si section mismatch Sergey Senozhatsky
@ 2011-02-14 23:29 ` Corey Minyard
  2011-02-15  9:52   ` [PATCH] char/ipmi: fix " Sergey Senozhatsky
  0 siblings, 1 reply; 4+ messages in thread
From: Corey Minyard @ 2011-02-14 23:29 UTC (permalink / raw)
  To: Sergey Senozhatsky
  Cc: Grant Likely, openipmi-developer, linux-kernel, Peter Huewe,
	Randy Dunlap

Yeah, I should have noticed this.

Acked-by: Corey Minyard <cminyard@mvista.com>

On 02/14/2011 09:03 AM, Sergey Senozhatsky wrote:
> Hello,
>
> commit d2478521afc20227658a10a8c5c2bf1a2aa615b3
> Author: Corey Minyard<minyard@acm.org>
> Date:   Thu Feb 10 16:08:38 2011 -0600
>
>      char/ipmi: fix OOPS caused by pnp_unregister_driver on unregistered driver
>
>
> Introduced section mismatch by calling __exit cleanup_ipmi_si
> from __devinit init_ipmi_si. Should we remove __exit annotation then?
>
>
> ---
>
>   drivers/char/ipmi/ipmi_si_intf.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
> index 7855f9f..94cd2ce 100644
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -3532,7 +3532,7 @@ static void cleanup_one_si(struct smi_info *to_clean)
>   	kfree(to_clean);
>   }
>
> -static void __exit cleanup_ipmi_si(void)
> +static void cleanup_ipmi_si(void)
>   {
>   	struct smi_info *e, *tmp_e;
>
>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] char/ipmi: fix cleanup_one_si section mismatch
  2011-02-14 23:29 ` Corey Minyard
@ 2011-02-15  9:52   ` Sergey Senozhatsky
  2011-03-15 16:37     ` Randy Dunlap
  0 siblings, 1 reply; 4+ messages in thread
From: Sergey Senozhatsky @ 2011-02-15  9:52 UTC (permalink / raw)
  To: Corey Minyard
  Cc: Grant Likely, openipmi-developer, linux-kernel, Peter Huewe,
	Randy Dunlap


commit d2478521afc20227658a10a8c5c2bf1a2aa615b3
Author: Corey Minyard<minyard@acm.org>
Date:   Thu Feb 10 16:08:38 2011 -0600

     char/ipmi: fix OOPS caused by pnp_unregister_driver on unregistered driver


Introduced section mismatch by calling __exit cleanup_ipmi_si from __devinit 
init_ipmi_si. Remove __exit annotation from cleanup_ipmi_si.

Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Acked-by: Corey Minyard <cminyard@mvista.com>

---

 drivers/char/ipmi/ipmi_si_intf.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index 7855f9f..94cd2ce 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -3532,7 +3532,7 @@ static void cleanup_one_si(struct smi_info *to_clean)
 	kfree(to_clean);
 }
 
-static void __exit cleanup_ipmi_si(void)
+static void cleanup_ipmi_si(void)
 {
 	struct smi_info *e, *tmp_e;
 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] char/ipmi: fix cleanup_one_si section mismatch
  2011-02-15  9:52   ` [PATCH] char/ipmi: fix " Sergey Senozhatsky
@ 2011-03-15 16:37     ` Randy Dunlap
  0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2011-03-15 16:37 UTC (permalink / raw)
  To: Sergey Senozhatsky
  Cc: Corey Minyard, Grant Likely, openipmi-developer, linux-kernel,
	Peter Huewe

On Tue, 15 Feb 2011 11:52:45 +0200 Sergey Senozhatsky wrote:

> 
> commit d2478521afc20227658a10a8c5c2bf1a2aa615b3
> Author: Corey Minyard<minyard@acm.org>
> Date:   Thu Feb 10 16:08:38 2011 -0600
> 
>      char/ipmi: fix OOPS caused by pnp_unregister_driver on unregistered driver
> 
> 
> Introduced section mismatch by calling __exit cleanup_ipmi_si from __devinit 
> init_ipmi_si. Remove __exit annotation from cleanup_ipmi_si.
> 
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Acked-by: Corey Minyard <cminyard@mvista.com>

Acked-by: Randy Dunlap <randy.dunlap@oracle.com>

Thanks.

> ---
> 
>  drivers/char/ipmi/ipmi_si_intf.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
> index 7855f9f..94cd2ce 100644
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -3532,7 +3532,7 @@ static void cleanup_one_si(struct smi_info *to_clean)
>  	kfree(to_clean);
>  }
>  
> -static void __exit cleanup_ipmi_si(void)
> +static void cleanup_ipmi_si(void)
>  {
>  	struct smi_info *e, *tmp_e;
>  
> --


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-03-15 16:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-14 15:03 char/ipmi: cleanup_one_si section mismatch Sergey Senozhatsky
2011-02-14 23:29 ` Corey Minyard
2011-02-15  9:52   ` [PATCH] char/ipmi: fix " Sergey Senozhatsky
2011-03-15 16:37     ` Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).