LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: Dirk Eibach <eibach@gdsys.de>,
	linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org,
	rdunlap@xenotime.net, linux-doc@vger.kernel.org
Subject: Re: [PATCH v2] hwmon: Add support for Texas Instruments ADS1015
Date: Thu, 17 Feb 2011 13:17:47 +0100	[thread overview]
Message-ID: <20110217131747.6e327b10@endymion.delvare> (raw)
In-Reply-To: <20110216045035.GA12173@ericsson.com>

Hi Guenter,

On Tue, 15 Feb 2011 20:50:35 -0800, Guenter Roeck wrote:
> On Mon, Feb 14, 2011 at 08:21:50AM -0500, Dirk Eibach wrote:
> > Signed-off-by: Dirk Eibach <eibach@gdsys.de>
> > ---
> > Changes since v1:
> > - fixed/extended Documentation
> > - removed unused register definitions
> > - hardcoded PGA fullscale table size
> > - made sure patch applies against v2.6.38-rc4
> > - reordered functions to avoid forward declaration
> > - results from i2c_smbus_read_word_data() are handled correctly
> > - moved locking into ads1015_read_value()
> > - removed unnecessray clearing of bit
> > - proper error handling in ads1015_read_value()
> > - use DIV_ROUND_CLOSEST for scaling result
> > - removed detect()
>
> Acked-by: Guenter Roeck <guenter.roeck@ericsson.com>
> 
> Jean,
> 
> any further comments ?

I have some more comments on the patch, yes. I'll post them in a moment
when I'm done with the review.

> If not, do you want me to apply it to my tree, or do you want to take it into yours ?

I'll pick it in my tree when I'm happy with it.

-- 
Jean Delvare

  reply	other threads:[~2011-02-17 12:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-14  9:26 [PATCH] " Dirk Eibach
2011-02-14 10:22 ` Jean Delvare
2011-02-14 13:21   ` [PATCH v2] " Dirk Eibach
2011-02-16  4:50     ` Guenter Roeck
2011-02-17 12:17       ` Jean Delvare [this message]
2011-02-17 12:42     ` Jean Delvare
2011-02-18 10:15       ` [PATCH v3] " Dirk Eibach
2011-02-24 16:48         ` Jean Delvare
2011-02-25 13:18           ` [PATCH v4] " Dirk Eibach
2011-03-02 17:57             ` Jean Delvare
2011-03-02 18:16               ` Wolfram Sang
2011-03-03  7:49                 ` (WARNING!!! PGP with incorrect signature) " Eibach, Dirk
2011-03-03  7:56                   ` Jean Delvare
2011-03-03  7:53               ` Eibach, Dirk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110217131747.6e327b10@endymion.delvare \
    --to=khali@linux-fr.org \
    --cc=eibach@gdsys.de \
    --cc=guenter.roeck@ericsson.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=rdunlap@xenotime.net \
    --subject='Re: [PATCH v2] hwmon: Add support for Texas Instruments ADS1015' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).