LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Matthew Garrett <mjg@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Colin King <colin.king@canonical.com>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Enable Dell All-In-One volume up/down keys
Date: Thu, 17 Feb 2011 16:33:51 +0000	[thread overview]
Message-ID: <20110217163351.GB20662@srcf.ucam.org> (raw)
In-Reply-To: <20110217075256.GB19814@core.coreip.homeip.net>

On Wed, Feb 16, 2011 at 11:52:56PM -0800, Dmitry Torokhov wrote:

> Looks generally good, one question though - should't it be part of
> dell-wmi driver?

It uses a different WMI GUID and has a different behaviour model to dell 
laptops that dell-wmi drives, so I think it's fair for it to be a 
separate driver.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

      parent reply	other threads:[~2011-02-17 16:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-14 13:02 Colin King
2011-02-17  7:52 ` Dmitry Torokhov
2011-02-17 11:10   ` Colin Ian King
2011-02-17 17:21     ` Dmitry Torokhov
2011-02-17 18:44       ` Colin Ian King
2011-02-17 16:33   ` Matthew Garrett [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110217163351.GB20662@srcf.ucam.org \
    --to=mjg@redhat.com \
    --cc=colin.king@canonical.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --subject='Re: [PATCH] Enable Dell All-In-One volume up/down keys' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).