LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@us.ibm.com>
To: "Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>
Cc: linux-ext4 <linux-ext4@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH 0/2] Add inode checksum support to ext4
Date: Wed, 6 Apr 2011 15:44:10 -0700 [thread overview]
Message-ID: <20110406224410.GB24354@tux1.beaverton.ibm.com> (raw)
Hi all,
I spent last week analyzing a client's corrupted ext3 image to see if I could
determine what had gone wrong and caused the filesystem to blow apart. As best
as I could tell, a data block got miswritten into a different sector ... which
happened to be an indirect block. Some time later the indirect block, which
now pointed at one of the inode tables (among other things that shouldn't ever
become file data) was loaded as part of a file write, which caused that inode
table to be blown to smithereens. Just for fun I tried reading from one of
these busted-inode files and ... failed to encounter any errors. Somehow, they
didn't find it funny that ext3 would read block numbers from a table with the
contents "ibm.com" with a straight face. Fortunately there were backups. :)
The client at this point asked if ext4 would do a better job of sanity
checking, which got me to wonder why ext4 checksums block groups but not
inodes. It's on Ted's todo list, but apparently nobody wrote any patch, so I
did. The following two patches are a first draft of adding inode checksum
support to both the kernel driver and to the various e2fsprogs.
If you have an existing ext* fs with 256-byte inodes, you ought to be able to
"tune2fs -O inode_csum /dev/XXX", fsck /dev/XXX, and mount the filesystem with
checksumming enabled. It seems to work for me (i386/x86-64), but I'm looking
for comments for improvement and perhaps some more testing (ppc64 is still
building). This inode checksum feature is not enabled by default.
--D
next reply other threads:[~2011-04-06 22:44 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 22:44 Darrick J. Wong [this message]
2011-04-06 22:45 ` [PATCH 1/2] ext4: Calculate and verify inode checksums Darrick J. Wong
2011-04-07 0:52 ` Sunil Mushran
2011-04-07 16:40 ` Darrick J. Wong
2011-04-07 17:10 ` Sunil Mushran
2011-04-08 18:50 ` Joel Becker
2011-04-08 19:30 ` Darrick J. Wong
2011-04-08 8:58 ` Andreas Dilger
2011-04-08 19:12 ` Darrick J. Wong
2011-04-08 22:49 ` Andreas Dilger
2011-04-06 22:47 ` [PATCH 2/2] e2fsprogs: Add support for toggling, verifying, and fixing " Darrick J. Wong
2011-04-08 9:14 ` Andreas Dilger
2011-04-08 19:25 ` Darrick J. Wong
2011-04-08 23:13 ` Andreas Dilger
2011-04-12 2:05 ` Darrick J. Wong
2011-04-08 19:27 ` [PATCH 0/2] Add inode checksum support to ext4 Mingming Cao
2011-04-08 20:17 ` Joel Becker
2011-07-27 8:27 ` Darrick J. Wong
2011-07-27 9:16 ` Andreas Dilger
2011-07-28 16:56 ` Darrick J. Wong
[not found] ` <CAOQ4uxiOpwX2-Nfh9wJ7wSmAnbj9bh1+d9C95-N5D-8saRr6ww@mail.gmail.com>
2011-07-28 18:57 ` Darrick J. Wong
2011-07-29 9:55 ` Andreas Dilger
2011-07-28 22:07 ` Joel Becker
2011-07-29 9:48 ` Andreas Dilger
2011-07-29 13:19 ` Joel Becker
2011-07-30 7:25 ` Coly Li
2011-07-31 7:08 ` Joel Becker
2011-07-31 23:52 ` Coly Li
2011-08-01 4:57 ` Joel Becker
2011-08-01 5:04 ` Joel Becker
2011-08-01 7:16 ` Coly Li
2011-04-20 17:40 ` Andi Kleen
2011-04-20 22:54 ` Darrick J. Wong
2011-04-21 0:25 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110406224410.GB24354@tux1.beaverton.ibm.com \
--to=djwong@us.ibm.com \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--subject='Re: [PATCH 0/2] Add inode checksum support to ext4' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).