LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: David Rientjes <rientjes@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch -linus] regmap: REMAP_IRQ should select IRQ_DOMAIN itself
Date: Thu, 24 May 2012 02:19:51 +0100	[thread overview]
Message-ID: <20120524011950.GD5361@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1205231735100.8785@chino.kir.corp.google.com>

[-- Attachment #1: Type: text/plain, Size: 920 bytes --]

On Wed, May 23, 2012 at 05:36:38PM -0700, David Rientjes wrote:

> What's fragile is going around and adding "select IRQ_DOMAIN" to 
> everything that does "select REGMAP_IRQ".  So I removed that and just made 
> IRQ_DOMAIN select REGMAP_IRQ itself.

It's a different kind of fragility, things break immediately when you
add something new which is reasonably obvous as opposed to happening
at some other time due to a tooling issue and what I'm concerned about
avoiding.  In any case...

> So can this be merged or what's the issue?

...Linus already merged my alternative patch which does this with a
select..if which never seems to have these issues.

Your patch *should* work but due to past issues and the fact that I can
understand why they might occur (the semantic of select is "just enable
this" which doesn't pay too much attention to the target) I'd rather go
with this different approach.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  parent reply	other threads:[~2012-05-24  1:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-22  8:30 linux-next: Tree for May 2 Stephen Rothwell
2012-05-22 11:28 ` Stephen Rothwell
2012-05-22 15:22 ` linux-next: Tree for May 2 (regmap-irq) Randy Dunlap
2012-05-23  6:57   ` [patch -linus] regmap: REMAP_IRQ should select IRQ_DOMAIN itself David Rientjes
2012-05-23  9:32     ` Mark Brown
2012-05-23 15:51       ` Linus Torvalds
2012-05-23 17:33         ` Mark Brown
2012-05-24  0:36           ` David Rientjes
2012-05-24  1:12             ` David Rientjes
2012-05-24  9:37               ` Mark Brown
2012-05-24  1:19             ` Mark Brown [this message]
2012-05-24  4:53               ` David Rientjes
2012-05-24  9:09                 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120524011950.GD5361@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=rientjes@google.com \
    --cc=sfr@canb.auug.org.au \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [patch -linus] regmap: REMAP_IRQ should select IRQ_DOMAIN itself' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).