LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: David Rientjes <rientjes@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch -linus] regmap: REMAP_IRQ should select IRQ_DOMAIN itself
Date: Thu, 24 May 2012 10:09:58 +0100	[thread overview]
Message-ID: <20120524090957.GE5361@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1205232149230.10366@chino.kir.corp.google.com>

On Wed, May 23, 2012 at 09:53:21PM -0700, David Rientjes wrote:

> Well pardon me for actually having a cluster of machines at Google 
> dedicated to upstream build/boot/regression testing that verified my patch 
> was correct and didn't result in any kind of "fragility", or what you have 
> convinced yourself is "fragility."

It working right now isn't the only thing I'm concerned about, though
like I said further up the thread it's possible this is all just me
having too long a memory.

> When you propose your own version, drop all cc's (and this isn't the first 
> time you've done that), and then send the git pull request less than 30 

Sorry about that, I hadn't realised you were particularly attached to
the issue.  I do generally drop people doing global stuff with no
particular obvious interest in the specific topic on new patches since I
know I sometimes get a bit fed up of being CCed on random things I was
tangentially involved in at some point.

> minutes later, I don't really have the chance to review it.  Lesson 
> learned, I simply won't bother to fix your code in the future.

I guess since I've offended you so much already there's not much harm in
saying: it's always much better to send changes in a form that can be
directly applied with tools like git am.  Appending a patch to the
bottom of a mail requires something like hand editing the commit after
it's been applied to extract the changelog.  Not sure it actually made a
difference in this specific case but it can be the difference when
you're not sure about the approach taken, especially for small patches
where it's quick and simple to write and test the replacement.

      reply	other threads:[~2012-05-24  9:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-22  8:30 linux-next: Tree for May 2 Stephen Rothwell
2012-05-22 11:28 ` Stephen Rothwell
2012-05-22 15:22 ` linux-next: Tree for May 2 (regmap-irq) Randy Dunlap
2012-05-23  6:57   ` [patch -linus] regmap: REMAP_IRQ should select IRQ_DOMAIN itself David Rientjes
2012-05-23  9:32     ` Mark Brown
2012-05-23 15:51       ` Linus Torvalds
2012-05-23 17:33         ` Mark Brown
2012-05-24  0:36           ` David Rientjes
2012-05-24  1:12             ` David Rientjes
2012-05-24  9:37               ` Mark Brown
2012-05-24  1:19             ` Mark Brown
2012-05-24  4:53               ` David Rientjes
2012-05-24  9:09                 ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120524090957.GE5361@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=rientjes@google.com \
    --cc=sfr@canb.auug.org.au \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [patch -linus] regmap: REMAP_IRQ should select IRQ_DOMAIN itself' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).