LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] of: Add vendor 2nd prefix for Asahi Kasei Corp
       [not found]               ` <5398AB07.4040304@wwwdotorg.org>
@ 2014-06-12  0:53                 ` Kuninori Morimoto
  2014-06-12  0:59                   ` Simon Horman
                                     ` (2 more replies)
  0 siblings, 3 replies; 34+ messages in thread
From: Kuninori Morimoto @ 2014-06-12  0:53 UTC (permalink / raw)
  To: Rob Herring, linux-kernel
  Cc: Mark Brown, Stephen Warren, devicetree,
	ALSA Development Mailing List, Linux-sh list, Magnus, Simon,
	Geert Uytterhoeven, Ben Dooks

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Current vendor-prefixes.txt already has
"ak" prefix for Asahi Kasei Corp by
ae8c4209af2cec065fef15d200a42a04130799f7
(of: Add vendor prefix for Asahi Kasei Corp.)

It went through the appropriate review process,
and is already in use.
But, almost all Asahi Kasei chip driver is
using "asahi-kasei" prefix today.

Due to ABIness, this patch adds
"asahi-kasei" to vendor-prefixes.txt.
checkpatch.pl will report WARNING without this patch.
(DT compatible string vendor "asahi-kasei" appears un-documented)

OTOH, Asahi Kasei is usually referred as "AKM",
but this patch doesn't care about it.
Because no DT is using it today.

Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Mark Brown <broonie@kernel.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 .../devicetree/bindings/vendor-prefixes.txt        |    1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index abc3080..7e4bb83 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -17,6 +17,7 @@ amstaos	AMS-Taos Inc.
 apm	Applied Micro Circuits Corporation (APM)
 arm	ARM Ltd.
 armadeus	ARMadeus Systems SARL
+asahi-kasei	Asahi Kasei Corp.
 atmel	Atmel Corporation
 auo	AU Optronics Corporation
 avago	Avago Technologies
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH] of: Add vendor 2nd prefix for Asahi Kasei Corp
  2014-06-12  0:53                 ` [PATCH] of: Add vendor 2nd prefix for Asahi Kasei Corp Kuninori Morimoto
@ 2014-06-12  0:59                   ` Simon Horman
  2014-06-12 15:33                   ` Stephen Warren
  2014-09-04  6:08                   ` [PATCH][resend] " Kuninori Morimoto
  2 siblings, 0 replies; 34+ messages in thread
From: Simon Horman @ 2014-06-12  0:59 UTC (permalink / raw)
  To: Kuninori Morimoto
  Cc: Rob Herring, linux-kernel, Mark Brown, Stephen Warren,
	devicetree, ALSA Development Mailing List, Linux-sh list, Magnus,
	Geert Uytterhoeven, Ben Dooks

On Wed, Jun 11, 2014 at 05:53:02PM -0700, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Current vendor-prefixes.txt already has
> "ak" prefix for Asahi Kasei Corp by
> ae8c4209af2cec065fef15d200a42a04130799f7
> (of: Add vendor prefix for Asahi Kasei Corp.)
> 
> It went through the appropriate review process,
> and is already in use.
> But, almost all Asahi Kasei chip driver is
> using "asahi-kasei" prefix today.
> 
> Due to ABIness, this patch adds
> "asahi-kasei" to vendor-prefixes.txt.
> checkpatch.pl will report WARNING without this patch.
> (DT compatible string vendor "asahi-kasei" appears un-documented)
> 
> OTOH, Asahi Kasei is usually referred as "AKM",
> but this patch doesn't care about it.
> Because no DT is using it today.
> 
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Acked-by: Simon Horman <horms+renesas@verge.net.au>

> ---
>  .../devicetree/bindings/vendor-prefixes.txt        |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index abc3080..7e4bb83 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -17,6 +17,7 @@ amstaos	AMS-Taos Inc.
>  apm	Applied Micro Circuits Corporation (APM)
>  arm	ARM Ltd.
>  armadeus	ARMadeus Systems SARL
> +asahi-kasei	Asahi Kasei Corp.
>  atmel	Atmel Corporation
>  auo	AU Optronics Corporation
>  avago	Avago Technologies
> -- 
> 1.7.9.5
> 

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH] of: Add vendor 2nd prefix for Asahi Kasei Corp
  2014-06-12  0:53                 ` [PATCH] of: Add vendor 2nd prefix for Asahi Kasei Corp Kuninori Morimoto
  2014-06-12  0:59                   ` Simon Horman
@ 2014-06-12 15:33                   ` Stephen Warren
  2014-09-04  6:08                   ` [PATCH][resend] " Kuninori Morimoto
  2 siblings, 0 replies; 34+ messages in thread
From: Stephen Warren @ 2014-06-12 15:33 UTC (permalink / raw)
  To: Kuninori Morimoto, Rob Herring, linux-kernel
  Cc: Mark Brown, devicetree, ALSA Development Mailing List,
	Linux-sh list, Magnus, Simon, Geert Uytterhoeven, Ben Dooks

On 06/11/2014 06:53 PM, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Current vendor-prefixes.txt already has
> "ak" prefix for Asahi Kasei Corp by
> ae8c4209af2cec065fef15d200a42a04130799f7
> (of: Add vendor prefix for Asahi Kasei Corp.)
> 
> It went through the appropriate review process,
> and is already in use.
> But, almost all Asahi Kasei chip driver is
> using "asahi-kasei" prefix today.

I'm fine with this patch, but just wanted to comment on this part of the
commit description:

What is in the drivers isn't relevant; that's not what drives the ABI.
The issue is that some *DTs* use ak and some use asahi-kasei, so both
those need to be supported.

That said, we should document which one of the two prefixes is
preferred, and use this for any new AK binding.

It would also be nice to ensure the preferred prefix is in all drivers'
of_match_tables, and remove the deprecated prefix from all drivers'
of_match_tables *except* where there's already a DT file that references
the deprecated vendor prefix.


^ permalink raw reply	[flat|nested] 34+ messages in thread

* [PATCH][resend] of: Add vendor 2nd prefix for Asahi Kasei Corp
  2014-06-12  0:53                 ` [PATCH] of: Add vendor 2nd prefix for Asahi Kasei Corp Kuninori Morimoto
  2014-06-12  0:59                   ` Simon Horman
  2014-06-12 15:33                   ` Stephen Warren
@ 2014-09-04  6:08                   ` Kuninori Morimoto
  2014-09-22 13:00                     ` Mark Rutland
  2 siblings, 1 reply; 34+ messages in thread
From: Kuninori Morimoto @ 2014-09-04  6:08 UTC (permalink / raw)
  To: Rob Herring
  Cc: linux-kernel, Mark Brown, Stephen Warren, devicetree,
	ALSA Development Mailing List, Linux-sh list, Magnus, Simon,
	Geert Uytterhoeven

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Current vendor-prefixes.txt already has
"ak" prefix for Asahi Kasei Corp by
ae8c4209af2cec065fef15d200a42a04130799f7
(of: Add vendor prefix for Asahi Kasei Corp.)

But, almost all Asahi Kasei chip driver is
using "asahi-kasei" prefix today.

This patch adds "asahi-kasei" to vendor-prefixes.txt.
checkpatch.pl will report WARNING without this patch.
(DT compatible string vendor "asahi-kasei" appears un-documented)

OTOH, Asahi Kasei is usually referred to as "AKM",
but this patch doesn't care about it.
Because no DT is using it today.

Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Mark Brown <broonie@kernel.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Acked-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 .../devicetree/bindings/vendor-prefixes.txt        |    1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index abc3080..7e4bb83 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -17,6 +17,7 @@ amstaos	AMS-Taos Inc.
 apm	Applied Micro Circuits Corporation (APM)
 arm	ARM Ltd.
 armadeus	ARMadeus Systems SARL
+asahi-kasei	Asahi Kasei Corp.
 atmel	Atmel Corporation
 auo	AU Optronics Corporation
 avago	Avago Technologies
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH][resend] of: Add vendor 2nd prefix for Asahi Kasei Corp
  2014-09-04  6:08                   ` [PATCH][resend] " Kuninori Morimoto
@ 2014-09-22 13:00                     ` Mark Rutland
  2014-09-22 13:24                       ` Geert Uytterhoeven
  0 siblings, 1 reply; 34+ messages in thread
From: Mark Rutland @ 2014-09-22 13:00 UTC (permalink / raw)
  To: Kuninori Morimoto, olof, Stephen Warren, robh
  Cc: linux-kernel, Mark Brown, devicetree,
	ALSA Development Mailing List, Linux-sh list, Magnus, Simon,
	Geert Uytterhoeven, grant.likely

On Thu, Sep 04, 2014 at 07:08:37AM +0100, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Current vendor-prefixes.txt already has
> "ak" prefix for Asahi Kasei Corp by
> ae8c4209af2cec065fef15d200a42a04130799f7
> (of: Add vendor prefix for Asahi Kasei Corp.)
> 
> But, almost all Asahi Kasei chip driver is
> using "asahi-kasei" prefix today.
> 
> This patch adds "asahi-kasei" to vendor-prefixes.txt.
> checkpatch.pl will report WARNING without this patch.
> (DT compatible string vendor "asahi-kasei" appears un-documented)

If we're adding a new string, we should figure out what's happening with
the old one. We want some consistency here.

>From a quick grep, it looks like the only use of "ak" is "ak,ak8975" in
arch/arm/boot/dts/tegra20-seaboard.dts. There are instances of
"asahi-kasei,ak8975" in other dts files.

Olof added "asahi-kasei,ak8975" to the ak8975 driver in February 2012
(see 54461c3067b2), and the "asahi-kasei" prefix is currently far more
common. This was only documented in May 2013 (see f4b7f751c6fd).

Stephen added the "ak" vendor-refix was added later in November 2012
(see ae8c4209af2c), and the only instance seems to work due to the i2c
subsystem doing something dehind the scenes with the compatible string.
So I think we made a mistake there.

Given all that, I think we should get rid of the "ak" prefix entirely,
fix up the seaboard dts, and leave the legacy matching for "ak,ak8975"
up to the i2c framework. However, that would imply deleting from
vendor-prefixes.txt (if we want people to be warned on use of "ak"), and
that's not a good precedent to set.

Thoughts?

Mark.

> OTOH, Asahi Kasei is usually referred to as "AKM",
> but this patch doesn't care about it.
> Because no DT is using it today.
> 
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
> Acked-by: Simon Horman <horms+renesas@verge.net.au>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>  .../devicetree/bindings/vendor-prefixes.txt        |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index abc3080..7e4bb83 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -17,6 +17,7 @@ amstaos	AMS-Taos Inc.
>  apm	Applied Micro Circuits Corporation (APM)
>  arm	ARM Ltd.
>  armadeus	ARMadeus Systems SARL
> +asahi-kasei	Asahi Kasei Corp.
>  atmel	Atmel Corporation
>  auo	AU Optronics Corporation
>  avago	Avago Technologies
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH][resend] of: Add vendor 2nd prefix for Asahi Kasei Corp
  2014-09-22 13:00                     ` Mark Rutland
@ 2014-09-22 13:24                       ` Geert Uytterhoeven
  2014-09-22 13:27                         ` Mark Rutland
  0 siblings, 1 reply; 34+ messages in thread
From: Geert Uytterhoeven @ 2014-09-22 13:24 UTC (permalink / raw)
  To: Mark Rutland
  Cc: Kuninori Morimoto, Olof Johansson, Stephen Warren, Rob Herring,
	linux-kernel, Mark Brown, devicetree,
	ALSA Development Mailing List, Linux-sh list, Magnus, Simon,
	Grant Likely

Hi Mark,

On Mon, Sep 22, 2014 at 3:00 PM, Mark Rutland <mark.rutland@arm.com> wrote:
> Given all that, I think we should get rid of the "ak" prefix entirely,
> fix up the seaboard dts, and leave the legacy matching for "ak,ak8975"
> up to the i2c framework. However, that would imply deleting from
> vendor-prefixes.txt (if we want people to be warned on use of "ak"), and
> that's not a good precedent to set.

Instead of deleting, we can deprecate, like was done for powervr:

powervr PowerVR (deprecated, use img)

Still missing is an update for checkpatch to warn when a deprecated
vendor prefix is used.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH][resend] of: Add vendor 2nd prefix for Asahi Kasei Corp
  2014-09-22 13:24                       ` Geert Uytterhoeven
@ 2014-09-22 13:27                         ` Mark Rutland
  2014-11-13  2:18                           ` Kuninori Morimoto
  0 siblings, 1 reply; 34+ messages in thread
From: Mark Rutland @ 2014-09-22 13:27 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Kuninori Morimoto, Olof Johansson, Stephen Warren, Rob Herring,
	linux-kernel, Mark Brown, devicetree,
	ALSA Development Mailing List, Linux-sh list, Magnus, Simon,
	grant.likely

On Mon, Sep 22, 2014 at 02:24:24PM +0100, Geert Uytterhoeven wrote:
> Hi Mark,

Hi Geert,

> On Mon, Sep 22, 2014 at 3:00 PM, Mark Rutland <mark.rutland@arm.com> wrote:
> > Given all that, I think we should get rid of the "ak" prefix entirely,
> > fix up the seaboard dts, and leave the legacy matching for "ak,ak8975"
> > up to the i2c framework. However, that would imply deleting from
> > vendor-prefixes.txt (if we want people to be warned on use of "ak"), and
> > that's not a good precedent to set.
> 
> Instead of deleting, we can deprecate, like was done for powervr:
> 
> powervr PowerVR (deprecated, use img)

Ah. I tried to see if we had any deprecated bindings, but I somehow
failed to search correctly and missed powervr.

> Still missing is an update for checkpatch to warn when a deprecated
> vendor prefix is used.

Marking it deprecated and warning with checkpatch is certainly
preferable.

Mark.

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH][resend] of: Add vendor 2nd prefix for Asahi Kasei Corp
  2014-09-22 13:27                         ` Mark Rutland
@ 2014-11-13  2:18                           ` Kuninori Morimoto
  2014-11-13  2:21                             ` Joe Perches
  0 siblings, 1 reply; 34+ messages in thread
From: Kuninori Morimoto @ 2014-11-13  2:18 UTC (permalink / raw)
  To: Mark Rutland
  Cc: Geert Uytterhoeven, Kuninori Morimoto, Olof Johansson,
	Stephen Warren, Rob Herring, linux-kernel, Mark Brown,
	devicetree, ALSA Development Mailing List, Linux-sh list, Magnus,
	Simon, grant.likely


Hi Mark, Geert

Sorry for my super late response about this

> > > Given all that, I think we should get rid of the "ak" prefix entirely,
> > > fix up the seaboard dts, and leave the legacy matching for "ak,ak8975"
> > > up to the i2c framework. However, that would imply deleting from
> > > vendor-prefixes.txt (if we want people to be warned on use of "ak"), and
> > > that's not a good precedent to set.
> > 
> > Instead of deleting, we can deprecate, like was done for powervr:
> > 
> > powervr PowerVR (deprecated, use img)
> 
> Ah. I tried to see if we had any deprecated bindings, but I somehow
> failed to search correctly and missed powervr.
> 
> > Still missing is an update for checkpatch to warn when a deprecated
> > vendor prefix is used.
> 
> Marking it deprecated and warning with checkpatch is certainly
> preferable.

I guess removing "ak" line from vendor-prefixes.txt is very enough
for warn for a deprecated vendor prefix on checkpatch ?

  ...
- ak	Asahi Kasei Corp.
  ...
+ asahi-kasei	Asahi Kasei Corp.

Best regards
---
Kuninori Morimoto

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH][resend] of: Add vendor 2nd prefix for Asahi Kasei Corp
  2014-11-13  2:18                           ` Kuninori Morimoto
@ 2014-11-13  2:21                             ` Joe Perches
  2014-11-13  2:51                               ` Simon Horman
  0 siblings, 1 reply; 34+ messages in thread
From: Joe Perches @ 2014-11-13  2:21 UTC (permalink / raw)
  To: Kuninori Morimoto
  Cc: Mark Rutland, Geert Uytterhoeven, Kuninori Morimoto,
	Olof Johansson, Stephen Warren, Rob Herring, linux-kernel,
	Mark Brown, devicetree, ALSA Development Mailing List,
	Linux-sh list, Magnus, Simon, grant.likely

On Thu, 2014-11-13 at 02:18 +0000, Kuninori Morimoto wrote:
> > > Still missing is an update for checkpatch to warn when a deprecated
> > > vendor prefix is used.
> > 
> > Marking it deprecated and warning with checkpatch is certainly
> > preferable.
> 
> I guess removing "ak" line from vendor-prefixes.txt is very enough
> for warn for a deprecated vendor prefix on checkpatch ?

Huh?  No idea what you mean.
What are you suggesting about checkpatch?



^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH][resend] of: Add vendor 2nd prefix for Asahi Kasei Corp
  2014-11-13  2:21                             ` Joe Perches
@ 2014-11-13  2:51                               ` Simon Horman
  2014-11-13  3:33                                 ` Kuninori Morimoto
  0 siblings, 1 reply; 34+ messages in thread
From: Simon Horman @ 2014-11-13  2:51 UTC (permalink / raw)
  To: Joe Perches
  Cc: Kuninori Morimoto, Mark Rutland, Geert Uytterhoeven,
	Kuninori Morimoto, Olof Johansson, Stephen Warren, Rob Herring,
	linux-kernel, Mark Brown, devicetree,
	ALSA Development Mailing List, Linux-sh list, Magnus,
	grant.likely

On Wed, Nov 12, 2014 at 06:21:49PM -0800, Joe Perches wrote:
> On Thu, 2014-11-13 at 02:18 +0000, Kuninori Morimoto wrote:
> > > > Still missing is an update for checkpatch to warn when a deprecated
> > > > vendor prefix is used.
> > > 
> > > Marking it deprecated and warning with checkpatch is certainly
> > > preferable.
> > 
> > I guess removing "ak" line from vendor-prefixes.txt is very enough
> > for warn for a deprecated vendor prefix on checkpatch ?
> 
> Huh?  No idea what you mean.
> What are you suggesting about checkpatch?

Hi Joe,

I think that what Morimoto-san wanted to say was something like this:

  I guess that removing the "ak" line from vendor-prefixes.txt would
  be sufficient to cause checkpatch to generate a warning about
  using the deprecated "ak" vendor prefix. Is that a good approach?

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH][resend] of: Add vendor 2nd prefix for Asahi Kasei Corp
  2014-11-13  2:51                               ` Simon Horman
@ 2014-11-13  3:33                                 ` Kuninori Morimoto
  2014-11-13 11:07                                   ` Mark Brown
  0 siblings, 1 reply; 34+ messages in thread
From: Kuninori Morimoto @ 2014-11-13  3:33 UTC (permalink / raw)
  To: Simon Horman
  Cc: Joe Perches, Mark Rutland, Geert Uytterhoeven, Kuninori Morimoto,
	Olof Johansson, Stephen Warren, Rob Herring, linux-kernel,
	Mark Brown, devicetree, ALSA Development Mailing List,
	Linux-sh list, Magnus, grant.likely


Hi Joe, Simon

> > > I guess removing "ak" line from vendor-prefixes.txt is very enough
> > > for warn for a deprecated vendor prefix on checkpatch ?
> > 
> > Huh?  No idea what you mean.
> > What are you suggesting about checkpatch?
> 
> Hi Joe,
> 
> I think that what Morimoto-san wanted to say was something like this:
> 
>   I guess that removing the "ak" line from vendor-prefixes.txt would
>   be sufficient to cause checkpatch to generate a warning about
>   using the deprecated "ak" vendor prefix. Is that a good approach?

Yes, this is.
Thank you Simon, Sorry Joe.


^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH][resend] of: Add vendor 2nd prefix for Asahi Kasei Corp
  2014-11-13  3:33                                 ` Kuninori Morimoto
@ 2014-11-13 11:07                                   ` Mark Brown
  2014-11-14  1:43                                     ` [PATCH v3] of: replace Asahi Kasei Corp venter prefix Kuninori Morimoto
  0 siblings, 1 reply; 34+ messages in thread
From: Mark Brown @ 2014-11-13 11:07 UTC (permalink / raw)
  To: Kuninori Morimoto
  Cc: Simon Horman, Joe Perches, Mark Rutland, Geert Uytterhoeven,
	Kuninori Morimoto, Olof Johansson, Stephen Warren, Rob Herring,
	linux-kernel, devicetree, ALSA Development Mailing List,
	Linux-sh list, Magnus, grant.likely

[-- Attachment #1: Type: text/plain, Size: 558 bytes --]

On Thu, Nov 13, 2014 at 03:33:38AM +0000, Kuninori Morimoto wrote:

> > I think that what Morimoto-san wanted to say was something like this:

> >   I guess that removing the "ak" line from vendor-prefixes.txt would
> >   be sufficient to cause checkpatch to generate a warning about
> >   using the deprecated "ak" vendor prefix. Is that a good approach?

> Yes, this is.
> Thank you Simon, Sorry Joe.

It'd be a bit nicer to be able to leave it there with a note saying it
was legacy (if only so people don't try to add it back) but I don't mind
too much.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 34+ messages in thread

* [PATCH v3] of: replace Asahi Kasei Corp venter prefix
  2014-11-13 11:07                                   ` Mark Brown
@ 2014-11-14  1:43                                     ` Kuninori Morimoto
  2014-11-14  8:38                                       ` Alexandre Courbot
  2014-11-14  9:35                                       ` [alsa-devel] " Thierry Reding
  0 siblings, 2 replies; 34+ messages in thread
From: Kuninori Morimoto @ 2014-11-14  1:43 UTC (permalink / raw)
  To: Mark Brown, Mark Rutland
  Cc: Simon Horman, Joe Perches, Geert Uytterhoeven, Kuninori Morimoto,
	Olof Johansson, Stephen Warren, Rob Herring, linux-kernel,
	devicetree, ALSA Development Mailing List, Linux-sh list, Magnus,
	grant.likely, linux-arm-kernel, linux-tegra

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Current vendor-prefixes.txt already has
"ak" prefix for Asahi Kasei Corp by
ae8c4209af2cec065fef15d200a42a04130799f7
(of: Add vendor prefix for Asahi Kasei Corp.)

It went through the appropriate review process.
But, almost all Asahi Kasei chip drivers are
using "asahi-kasei" prefix today.
(arch/arm/boot/dts/tegra20-seaboard.dts only is
using "ak,ak8975", but there are instances of
"asahi-kasei,ak8975" in other dts files.
And drivers/iio/magnetometer/ak8975.c
doesn't support "ak,ak8975")
So, we made a mistake there.

In addition, checkpatch.pl reports WARNING
if it is using "asahi-kasei" prerfix in DT file.
(DT compatible string vendor "asahi-kasei" appears un-documented)

Marking it deprecated and warning with checkpatch
is certainly preferable.
So, this patch replace "ak" to "asahi-kasei" in
vendor-prefixes.txt. (and fixup tegra20-seaboard)

OTOH, Asahi Kasei is usually referred to as "AKM",
but this patch doesn't care about it.
Because no DT is using that today.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 .../devicetree/bindings/vendor-prefixes.txt        |    2 +-
 arch/arm/boot/dts/tegra20-seaboard.dts             |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 723999d..ddcb4cd 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -9,7 +9,6 @@ ad	Avionic Design GmbH
 adapteva	Adapteva, Inc.
 adi	Analog Devices, Inc.
 aeroflexgaisler	Aeroflex Gaisler AB
-ak	Asahi Kasei Corp.
 allwinner	Allwinner Technology Co., Ltd.
 altr	Altera Corp.
 amcc	Applied Micro Circuits Corporation (APM, formally AMCC)
@@ -20,6 +19,7 @@ amstaos	AMS-Taos Inc.
 apm	Applied Micro Circuits Corporation (APM)
 arm	ARM Ltd.
 armadeus	ARMadeus Systems SARL
+asahi-kasei	Asahi Kasei Corp.
 atmel	Atmel Corporation
 auo	AU Optronics Corporation
 avago	Avago Technologies
diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts
index a1d4bf9..7f5cf80 100644
--- a/arch/arm/boot/dts/tegra20-seaboard.dts
+++ b/arch/arm/boot/dts/tegra20-seaboard.dts
@@ -405,7 +405,7 @@
 		clock-frequency = <400000>;
 
 		magnetometer@c {
-			compatible = "ak,ak8975";
+			compatible = "asahi-kasei,ak8975";
 			reg = <0xc>;
 			interrupt-parent = <&gpio>;
 			interrupts = <TEGRA_GPIO(N, 5) IRQ_TYPE_LEVEL_HIGH>;
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH v3] of: replace Asahi Kasei Corp venter prefix
  2014-11-14  1:43                                     ` [PATCH v3] of: replace Asahi Kasei Corp venter prefix Kuninori Morimoto
@ 2014-11-14  8:38                                       ` Alexandre Courbot
  2014-11-14  9:16                                         ` Arnd Bergmann
  2014-11-14  9:30                                         ` Thierry Reding
  2014-11-14  9:35                                       ` [alsa-devel] " Thierry Reding
  1 sibling, 2 replies; 34+ messages in thread
From: Alexandre Courbot @ 2014-11-14  8:38 UTC (permalink / raw)
  To: Kuninori Morimoto, Mark Brown, Mark Rutland
  Cc: Simon Horman, Joe Perches, Geert Uytterhoeven, Kuninori Morimoto,
	Olof Johansson, Stephen Warren, Rob Herring, linux-kernel,
	devicetree, ALSA Development Mailing List, Linux-sh list, Magnus,
	grant.likely, linux-arm-kernel, linux-tegra

On 11/14/2014 10:43 AM, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Current vendor-prefixes.txt already has
> "ak" prefix for Asahi Kasei Corp by
> ae8c4209af2cec065fef15d200a42a04130799f7
> (of: Add vendor prefix for Asahi Kasei Corp.)
>
> It went through the appropriate review process.
> But, almost all Asahi Kasei chip drivers are
> using "asahi-kasei" prefix today.
> (arch/arm/boot/dts/tegra20-seaboard.dts only is
> using "ak,ak8975", but there are instances of
> "asahi-kasei,ak8975" in other dts files.
> And drivers/iio/magnetometer/ak8975.c
> doesn't support "ak,ak8975")
> So, we made a mistake there.
>
> In addition, checkpatch.pl reports WARNING
> if it is using "asahi-kasei" prerfix in DT file.
> (DT compatible string vendor "asahi-kasei" appears un-documented)
>
> Marking it deprecated and warning with checkpatch
> is certainly preferable.
> So, this patch replace "ak" to "asahi-kasei" in
> vendor-prefixes.txt. (and fixup tegra20-seaboard)
>
> OTOH, Asahi Kasei is usually referred to as "AKM",
> but this patch doesn't care about it.
> Because no DT is using that today.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>   .../devicetree/bindings/vendor-prefixes.txt        |    2 +-
>   arch/arm/boot/dts/tegra20-seaboard.dts             |    2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index 723999d..ddcb4cd 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -9,7 +9,6 @@ ad	Avionic Design GmbH
>   adapteva	Adapteva, Inc.
>   adi	Analog Devices, Inc.
>   aeroflexgaisler	Aeroflex Gaisler AB
> -ak	Asahi Kasei Corp.
>   allwinner	Allwinner Technology Co., Ltd.
>   altr	Altera Corp.
>   amcc	Applied Micro Circuits Corporation (APM, formally AMCC)
> @@ -20,6 +19,7 @@ amstaos	AMS-Taos Inc.
>   apm	Applied Micro Circuits Corporation (APM)
>   arm	ARM Ltd.
>   armadeus	ARMadeus Systems SARL
> +asahi-kasei	Asahi Kasei Corp.
>   atmel	Atmel Corporation
>   auo	AU Optronics Corporation
>   avago	Avago Technologies
> diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts
> index a1d4bf9..7f5cf80 100644
> --- a/arch/arm/boot/dts/tegra20-seaboard.dts
> +++ b/arch/arm/boot/dts/tegra20-seaboard.dts
> @@ -405,7 +405,7 @@
>   		clock-frequency = <400000>;
>
>   		magnetometer@c {
> -			compatible = "ak,ak8975";
> +			compatible = "asahi-kasei,ak8975";

Mmm. So does this mean this device was never probed because the driver 
did not recognize its compatible property? I cannot find "ak,ak8975" 
anywhere else in the kernel.

If so,

Acked-by: Alexandre Courbot <acourbot@nvidia.com>

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH v3] of: replace Asahi Kasei Corp venter prefix
  2014-11-14  8:38                                       ` Alexandre Courbot
@ 2014-11-14  9:16                                         ` Arnd Bergmann
  2014-11-14  9:30                                         ` Thierry Reding
  1 sibling, 0 replies; 34+ messages in thread
From: Arnd Bergmann @ 2014-11-14  9:16 UTC (permalink / raw)
  To: Alexandre Courbot
  Cc: Kuninori Morimoto, Mark Brown, Mark Rutland, Simon Horman,
	Joe Perches, Geert Uytterhoeven, Kuninori Morimoto,
	Olof Johansson, Stephen Warren, Rob Herring, linux-kernel,
	devicetree, ALSA Development Mailing List, Linux-sh list, Magnus,
	grant.likely, linux-arm-kernel, linux-tegra

On Friday 14 November 2014 17:38:58 Alexandre Courbot wrote:
> > diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts
> > index a1d4bf9..7f5cf80 100644
> > --- a/arch/arm/boot/dts/tegra20-seaboard.dts
> > +++ b/arch/arm/boot/dts/tegra20-seaboard.dts
> > @@ -405,7 +405,7 @@
> >               clock-frequency = <400000>;
> >
> >               magnetometer@c {
> > -                     compatible = "ak,ak8975";
> > +                     compatible = "asahi-kasei,ak8975";
> 
> Mmm. So does this mean this device was never probed because the driver 
> did not recognize its compatible property? I cannot find "ak,ak8975" 
> anywhere else in the kernel.
> 

No, the i2c bus behaves in a special way by matching the "ak8975"
i2c driver name with any "*,ak8975" DT compatible string. Both
of the above will work with existing kernels.

	Arnd

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH v3] of: replace Asahi Kasei Corp venter prefix
  2014-11-14  8:38                                       ` Alexandre Courbot
  2014-11-14  9:16                                         ` Arnd Bergmann
@ 2014-11-14  9:30                                         ` Thierry Reding
  1 sibling, 0 replies; 34+ messages in thread
From: Thierry Reding @ 2014-11-14  9:30 UTC (permalink / raw)
  To: Alexandre Courbot
  Cc: Kuninori Morimoto, Mark Brown, Mark Rutland, Simon Horman,
	Joe Perches, Geert Uytterhoeven, Kuninori Morimoto,
	Olof Johansson, Stephen Warren, Rob Herring, linux-kernel,
	devicetree, ALSA Development Mailing List, Linux-sh list, Magnus,
	grant.likely, linux-arm-kernel, linux-tegra

[-- Attachment #1: Type: text/plain, Size: 1562 bytes --]

On Fri, Nov 14, 2014 at 05:38:58PM +0900, Alexandre Courbot wrote:
> On 11/14/2014 10:43 AM, Kuninori Morimoto wrote:
[...]
> >diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts
> >index a1d4bf9..7f5cf80 100644
> >--- a/arch/arm/boot/dts/tegra20-seaboard.dts
> >+++ b/arch/arm/boot/dts/tegra20-seaboard.dts
> >@@ -405,7 +405,7 @@
> >  		clock-frequency = <400000>;
> >
> >  		magnetometer@c {
> >-			compatible = "ak,ak8975";
> >+			compatible = "asahi-kasei,ak8975";
> 
> Mmm. So does this mean this device was never probed because the driver did
> not recognize its compatible property?

I2C (like SPI) has a fallback in case the OF table yields no match. The
of_modalias_node() that it uses extracts the module name from the device
tree node's compatible string by skipping the vendor prefix. The
resulting string is then set as the I2C client's name and causes the I2C
standard ID matching to succeed (see of_i2c_register_devices() for how
this is done in detail).

> I cannot find "ak,ak8975" anywhere else in the kernel.
> 
> If so,
> 
> Acked-by: Alexandre Courbot <acourbot@nvidia.com>

Technically this is breaking backwards-compatibility from a DT
perspective, but I think it's safe to do because the Linux kernel has a
way of dealing with this and other operating systems should be able to
deal with this in a similar way (or even easier by letting the driver
match on the ak prefix as well for this particular chip).

So:

Acked-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [alsa-devel] [PATCH v3] of: replace Asahi Kasei Corp venter prefix
  2014-11-14  1:43                                     ` [PATCH v3] of: replace Asahi Kasei Corp venter prefix Kuninori Morimoto
  2014-11-14  8:38                                       ` Alexandre Courbot
@ 2014-11-14  9:35                                       ` Thierry Reding
  2014-11-17  0:51                                         ` [PATCH v4] " Kuninori Morimoto
  1 sibling, 1 reply; 34+ messages in thread
From: Thierry Reding @ 2014-11-14  9:35 UTC (permalink / raw)
  To: Kuninori Morimoto
  Cc: Mark Brown, Mark Rutland, Rob Herring,
	ALSA Development Mailing List, linux-tegra, Stephen Warren,
	Linux-sh list, Magnus, linux-kernel, Olof Johansson, devicetree,
	Simon Horman, Geert Uytterhoeven, Joe Perches, Kuninori Morimoto,
	linux-arm-kernel, grant.likely

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]

On Fri, Nov 14, 2014 at 01:43:03AM +0000, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Current vendor-prefixes.txt already has
> "ak" prefix for Asahi Kasei Corp by
> ae8c4209af2cec065fef15d200a42a04130799f7

It's usually enough to show the first 12 (or so) characters of the SHA1
here. git will show you the right one if you do something like:

	git log --abbrev=12 --abbrev-commit

It's probably useful to "git config core.abbrev 12" for Linux kernel
repositories.

Other than that it seems like you're being overly careful about not
exceeding 72 characters. Your lines seem to wrap at around less than
50 columns. However, making lines too short results in equally hard to
read commit messages, so please try to shoot for 72 columns for maximum
readability.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 34+ messages in thread

* [PATCH v4] of: replace Asahi Kasei Corp venter prefix
  2014-11-14  9:35                                       ` [alsa-devel] " Thierry Reding
@ 2014-11-17  0:51                                         ` Kuninori Morimoto
  2014-11-17 10:26                                           ` Sergei Shtylyov
  0 siblings, 1 reply; 34+ messages in thread
From: Kuninori Morimoto @ 2014-11-17  0:51 UTC (permalink / raw)
  To: Rob Herring
  Cc: Mark Brown, Mark Rutland, Thierry Reding,
	ALSA Development Mailing List, linux-tegra, Stephen Warren,
	Linux-sh list, Magnus, linux-kernel, Olof Johansson, devicetree,
	Simon Horman, Geert Uytterhoeven, Joe Perches, Kuninori Morimoto,
	linux-arm-kernel, grant.likely

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp
by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.)

It went through the appropriate review process. But, almost all
Asahi Kasei chip drivers are using "asahi-kasei" prefix today.
(arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975",
 but there are instances of "asahi-kasei,ak8975" in other dts files.
 And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975")
So, we made a mistake there.

In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei"
prerfix in DT file.
(DT compatible string vendor "asahi-kasei" appears un-documented)

Marking it deprecated and warning with checkpatch is certainly
preferable. So, this patch replace "ak" to "asahi-kasei" in
vendor-prefixes.txt. (and fixup tegra20-seaboard)

OTOH, Asahi Kasei is usually referred to as "AKM", but this patch
doesn't care about it. Because no DT is using that today.

Acked-by: Thierry Reding <treding@nvidia.com>
Acked-by: Alexandre Courbot <acourbot@nvidia.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v3 -> v4

 - git-comment uses 72 char in 1 line
 - added Thierry/Alexandre's Acked-by

 .../devicetree/bindings/vendor-prefixes.txt        |    2 +-
 arch/arm/boot/dts/tegra20-seaboard.dts             |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 723999d..ddcb4cd 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -9,7 +9,6 @@ ad	Avionic Design GmbH
 adapteva	Adapteva, Inc.
 adi	Analog Devices, Inc.
 aeroflexgaisler	Aeroflex Gaisler AB
-ak	Asahi Kasei Corp.
 allwinner	Allwinner Technology Co., Ltd.
 altr	Altera Corp.
 amcc	Applied Micro Circuits Corporation (APM, formally AMCC)
@@ -20,6 +19,7 @@ amstaos	AMS-Taos Inc.
 apm	Applied Micro Circuits Corporation (APM)
 arm	ARM Ltd.
 armadeus	ARMadeus Systems SARL
+asahi-kasei	Asahi Kasei Corp.
 atmel	Atmel Corporation
 auo	AU Optronics Corporation
 avago	Avago Technologies
diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts
index a1d4bf9..7f5cf80 100644
--- a/arch/arm/boot/dts/tegra20-seaboard.dts
+++ b/arch/arm/boot/dts/tegra20-seaboard.dts
@@ -405,7 +405,7 @@
 		clock-frequency = <400000>;
 
 		magnetometer@c {
-			compatible = "ak,ak8975";
+			compatible = "asahi-kasei,ak8975";
 			reg = <0xc>;
 			interrupt-parent = <&gpio>;
 			interrupts = <TEGRA_GPIO(N, 5) IRQ_TYPE_LEVEL_HIGH>;
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH v4] of: replace Asahi Kasei Corp venter prefix
  2014-11-17  0:51                                         ` [PATCH v4] " Kuninori Morimoto
@ 2014-11-17 10:26                                           ` Sergei Shtylyov
  2014-11-18  0:30                                             ` [PATCH v5] of: replace Asahi Kasei Corp vendor prefix Kuninori Morimoto
  0 siblings, 1 reply; 34+ messages in thread
From: Sergei Shtylyov @ 2014-11-17 10:26 UTC (permalink / raw)
  To: Kuninori Morimoto, Rob Herring
  Cc: Mark Brown, Mark Rutland, Thierry Reding,
	ALSA Development Mailing List, linux-tegra, Stephen Warren,
	Linux-sh list, Magnus, linux-kernel, Olof Johansson, devicetree,
	Simon Horman, Geert Uytterhoeven, Joe Perches, Kuninori Morimoto,
	linux-arm-kernel, grant.likely

Hello.

On 11/17/2014 3:51 AM, Kuninori Morimoto wrote:

> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

    s/venter/vendor/ in the subject. Sorry for a late comment.

> Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp
> by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.)

> It went through the appropriate review process. But, almost all
> Asahi Kasei chip drivers are using "asahi-kasei" prefix today.
> (arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975",
>   but there are instances of "asahi-kasei,ak8975" in other dts files.
>   And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975")
> So, we made a mistake there.

> In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei"
> prerfix in DT file.
> (DT compatible string vendor "asahi-kasei" appears un-documented)

> Marking it deprecated and warning with checkpatch is certainly
> preferable. So, this patch replace "ak" to "asahi-kasei" in
> vendor-prefixes.txt. (and fixup tegra20-seaboard)

> OTOH, Asahi Kasei is usually referred to as "AKM", but this patch
> doesn't care about it. Because no DT is using that today.

> Acked-by: Thierry Reding <treding@nvidia.com>
> Acked-by: Alexandre Courbot <acourbot@nvidia.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

    One normally places ACKs after his own sign-off.

WBR, Sergei


^ permalink raw reply	[flat|nested] 34+ messages in thread

* [PATCH v5] of: replace Asahi Kasei Corp vendor prefix
  2014-11-17 10:26                                           ` Sergei Shtylyov
@ 2014-11-18  0:30                                             ` Kuninori Morimoto
  2014-11-28  0:22                                               ` [PATCH v5][resend] of: replace Asahi Kasei Corp venter prefix Kuninori Morimoto
  0 siblings, 1 reply; 34+ messages in thread
From: Kuninori Morimoto @ 2014-11-18  0:30 UTC (permalink / raw)
  To: Rob Herring
  Cc: Mark Brown, Mark Rutland, Thierry Reding,
	ALSA Development Mailing List, linux-tegra, Stephen Warren,
	Linux-sh list, Magnus, linux-kernel, Olof Johansson, devicetree,
	Simon Horman, Geert Uytterhoeven, Joe Perches, Kuninori Morimoto,
	linux-arm-kernel, grant.likely

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp
by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.)

It went through the appropriate review process. But, almost all
Asahi Kasei chip drivers are using "asahi-kasei" prefix today.
(arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975",
 but there are instances of "asahi-kasei,ak8975" in other dts files.
 And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix)
So, we made a mistake there.

In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei"
prerfix in DT file.
(DT compatible string vendor "asahi-kasei" appears un-documented)

Marking it deprecated and warning with checkpatch is certainly
preferable. So, this patch replace "ak" to "asahi-kasei" in
vendor-prefixes.txt. (and fixup tegra20-seaboard)

OTOH, Asahi Kasei is usually referred to as "AKM", but this patch
doesn't care about it. Because no DT is using that today.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Acked-by: Alexandre Courbot <acourbot@nvidia.com>
---
v4 -> v5

 - venter -> vendor on Subject
 - fixup Acked-by ordering

 .../devicetree/bindings/vendor-prefixes.txt        |    2 +-
 arch/arm/boot/dts/tegra20-seaboard.dts             |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 723999d..ddcb4cd 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -9,7 +9,6 @@ ad	Avionic Design GmbH
 adapteva	Adapteva, Inc.
 adi	Analog Devices, Inc.
 aeroflexgaisler	Aeroflex Gaisler AB
-ak	Asahi Kasei Corp.
 allwinner	Allwinner Technology Co., Ltd.
 altr	Altera Corp.
 amcc	Applied Micro Circuits Corporation (APM, formally AMCC)
@@ -20,6 +19,7 @@ amstaos	AMS-Taos Inc.
 apm	Applied Micro Circuits Corporation (APM)
 arm	ARM Ltd.
 armadeus	ARMadeus Systems SARL
+asahi-kasei	Asahi Kasei Corp.
 atmel	Atmel Corporation
 auo	AU Optronics Corporation
 avago	Avago Technologies
diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts
index a1d4bf9..7f5cf80 100644
--- a/arch/arm/boot/dts/tegra20-seaboard.dts
+++ b/arch/arm/boot/dts/tegra20-seaboard.dts
@@ -405,7 +405,7 @@
 		clock-frequency = <400000>;
 
 		magnetometer@c {
-			compatible = "ak,ak8975";
+			compatible = "asahi-kasei,ak8975";
 			reg = <0xc>;
 			interrupt-parent = <&gpio>;
 			interrupts = <TEGRA_GPIO(N, 5) IRQ_TYPE_LEVEL_HIGH>;
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 34+ messages in thread

* [PATCH v5][resend] of: replace Asahi Kasei Corp venter prefix
  2014-11-18  0:30                                             ` [PATCH v5] of: replace Asahi Kasei Corp vendor prefix Kuninori Morimoto
@ 2014-11-28  0:22                                               ` Kuninori Morimoto
  2014-11-28 11:45                                                 ` Sergei Shtylyov
  0 siblings, 1 reply; 34+ messages in thread
From: Kuninori Morimoto @ 2014-11-28  0:22 UTC (permalink / raw)
  To: Matthias Brugger, Jason Cooper, Heiko Stuebner, Shawn Guo,
	Florian Vaussard, Rob Herring, Mark Brown
  Cc: Mark Rutland, Thierry Reding, ALSA Development Mailing List,
	linux-tegra, Stephen Warren, Linux-sh list, Magnus, linux-kernel,
	Olof Johansson, devicetree, Simon Horman, Geert Uytterhoeven,
	Joe Perches, Kuninori Morimoto, linux-arm-kernel, grant.likely

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp
by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.)

It went through the appropriate review process. But, almost all
Asahi Kasei chip drivers are using "asahi-kasei" prefix today.
(arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975",
 but there are instances of "asahi-kasei,ak8975" in other dts files.
 And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix)
So, we made a mistake there.

In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei"
prerfix in DT file.
(DT compatible string vendor "asahi-kasei" appears un-documented)

Marking it deprecated and warning with checkpatch is certainly
preferable. So, this patch replace "ak" to "asahi-kasei" in
vendor-prefixes.txt. (and fixup tegra20-seaboard)

OTOH, Asahi Kasei is usually referred to as "AKM", but this patch
doesn't care about it. Because no DT is using that today.

Acked-by: Thierry Reding <treding@nvidia.com>
Acked-by: Alexandre Courbot <acourbot@nvidia.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 .../devicetree/bindings/vendor-prefixes.txt        |    2 +-
 arch/arm/boot/dts/tegra20-seaboard.dts             |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 723999d..ddcb4cd 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -9,7 +9,6 @@ ad	Avionic Design GmbH
 adapteva	Adapteva, Inc.
 adi	Analog Devices, Inc.
 aeroflexgaisler	Aeroflex Gaisler AB
-ak	Asahi Kasei Corp.
 allwinner	Allwinner Technology Co., Ltd.
 altr	Altera Corp.
 amcc	Applied Micro Circuits Corporation (APM, formally AMCC)
@@ -20,6 +19,7 @@ amstaos	AMS-Taos Inc.
 apm	Applied Micro Circuits Corporation (APM)
 arm	ARM Ltd.
 armadeus	ARMadeus Systems SARL
+asahi-kasei	Asahi Kasei Corp.
 atmel	Atmel Corporation
 auo	AU Optronics Corporation
 avago	Avago Technologies
diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts
index a1d4bf9..7f5cf80 100644
--- a/arch/arm/boot/dts/tegra20-seaboard.dts
+++ b/arch/arm/boot/dts/tegra20-seaboard.dts
@@ -405,7 +405,7 @@
 		clock-frequency = <400000>;
 
 		magnetometer@c {
-			compatible = "ak,ak8975";
+			compatible = "asahi-kasei,ak8975";
 			reg = <0xc>;
 			interrupt-parent = <&gpio>;
 			interrupts = <TEGRA_GPIO(N, 5) IRQ_TYPE_LEVEL_HIGH>;
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH v5][resend] of: replace Asahi Kasei Corp venter prefix
  2014-11-28  0:22                                               ` [PATCH v5][resend] of: replace Asahi Kasei Corp venter prefix Kuninori Morimoto
@ 2014-11-28 11:45                                                 ` Sergei Shtylyov
  2014-12-02  4:57                                                   ` [PATCH v5][resend] of: replace Asahi Kasei Corp vendor prefix Kuninori Morimoto
  0 siblings, 1 reply; 34+ messages in thread
From: Sergei Shtylyov @ 2014-11-28 11:45 UTC (permalink / raw)
  To: Kuninori Morimoto, Matthias Brugger, Jason Cooper,
	Heiko Stuebner, Shawn Guo, Florian Vaussard, Rob Herring,
	Mark Brown
  Cc: Mark Rutland, Thierry Reding, ALSA Development Mailing List,
	linux-tegra, Stephen Warren, Linux-sh list, Magnus, linux-kernel,
	Olof Johansson, devicetree, Simon Horman, Geert Uytterhoeven,
	Joe Perches, Kuninori Morimoto, linux-arm-kernel, grant.likely

Hello.

On 11/28/2014 3:22 AM, Kuninori Morimoto wrote:

> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

> Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp
> by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.)

> It went through the appropriate review process. But, almost all
> Asahi Kasei chip drivers are using "asahi-kasei" prefix today.
> (arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975",
>   but there are instances of "asahi-kasei,ak8975" in other dts files.
>   And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix)
> So, we made a mistake there.

> In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei"
> prerfix in DT file.
> (DT compatible string vendor "asahi-kasei" appears un-documented)

> Marking it deprecated and warning with checkpatch is certainly
> preferable. So, this patch replace "ak" to "asahi-kasei" in
> vendor-prefixes.txt. (and fixup tegra20-seaboard)

> OTOH, Asahi Kasei is usually referred to as "AKM", but this patch
> doesn't care about it. Because no DT is using that today.

> Acked-by: Thierry Reding <treding@nvidia.com>
> Acked-by: Alexandre Courbot <acourbot@nvidia.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

    It's "venter" ISO "vendor" again in the subject. And you already fixed 
that in the previous posting... :-)

WBR, Sergei


^ permalink raw reply	[flat|nested] 34+ messages in thread

* [PATCH v5][resend] of: replace Asahi Kasei Corp vendor prefix
  2014-11-28 11:45                                                 ` Sergei Shtylyov
@ 2014-12-02  4:57                                                   ` Kuninori Morimoto
  2014-12-15  3:53                                                     ` [PATCH v5][resend v2] " Kuninori Morimoto
                                                                       ` (3 more replies)
  0 siblings, 4 replies; 34+ messages in thread
From: Kuninori Morimoto @ 2014-12-02  4:57 UTC (permalink / raw)
  To: Matthias Brugger, Jason Cooper, Heiko Stuebner, Rob Herring
  Cc: Shawn Guo, Florian Vaussard, Mark Brown, Mark Rutland,
	Thierry Reding, ALSA Development Mailing List, linux-tegra,
	Stephen Warren, Linux-sh list, Magnus, linux-kernel,
	Olof Johansson, devicetree, Simon Horman, Geert Uytterhoeven,
	Joe Perches, Kuninori Morimoto, linux-arm-kernel, grant.likely

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp
by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.)

It went through the appropriate review process. But, almost all
Asahi Kasei chip drivers are using "asahi-kasei" prefix today.
(arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975",
 but there are instances of "asahi-kasei,ak8975" in other dts files.
 And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix)
So, we made a mistake there.

In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei"
prerfix in DT file.
(DT compatible string vendor "asahi-kasei" appears un-documented)

Marking it deprecated and warning with checkpatch is certainly
preferable. So, this patch replace "ak" to "asahi-kasei" in
vendor-prefixes.txt. (and fixup tegra20-seaboard)

OTOH, Asahi Kasei is usually referred to as "AKM", but this patch
doesn't care about it. Because no DT is using that today.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Acked-by: Alexandre Courbot <acourbot@nvidia.com>
---
v4 -> v5

 - venter -> vendor on Subject
 - fixup Acked-by ordering

 .../devicetree/bindings/vendor-prefixes.txt        |    2 +-
 arch/arm/boot/dts/tegra20-seaboard.dts             |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 723999d..ddcb4cd 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -9,7 +9,6 @@ ad	Avionic Design GmbH
 adapteva	Adapteva, Inc.
 adi	Analog Devices, Inc.
 aeroflexgaisler	Aeroflex Gaisler AB
-ak	Asahi Kasei Corp.
 allwinner	Allwinner Technology Co., Ltd.
 altr	Altera Corp.
 amcc	Applied Micro Circuits Corporation (APM, formally AMCC)
@@ -20,6 +19,7 @@ amstaos	AMS-Taos Inc.
 apm	Applied Micro Circuits Corporation (APM)
 arm	ARM Ltd.
 armadeus	ARMadeus Systems SARL
+asahi-kasei	Asahi Kasei Corp.
 atmel	Atmel Corporation
 auo	AU Optronics Corporation
 avago	Avago Technologies
diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts
index a1d4bf9..7f5cf80 100644
--- a/arch/arm/boot/dts/tegra20-seaboard.dts
+++ b/arch/arm/boot/dts/tegra20-seaboard.dts
@@ -405,7 +405,7 @@
 		clock-frequency = <400000>;
 
 		magnetometer@c {
-			compatible = "ak,ak8975";
+			compatible = "asahi-kasei,ak8975";
 			reg = <0xc>;
 			interrupt-parent = <&gpio>;
 			interrupts = <TEGRA_GPIO(N, 5) IRQ_TYPE_LEVEL_HIGH>;
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 34+ messages in thread

* [PATCH v5][resend v2] of: replace Asahi Kasei Corp vendor prefix
  2014-12-02  4:57                                                   ` [PATCH v5][resend] of: replace Asahi Kasei Corp vendor prefix Kuninori Morimoto
@ 2014-12-15  3:53                                                     ` Kuninori Morimoto
  2014-12-17  2:33                                                     ` [PATCH v5][resend v3] " Kuninori Morimoto
                                                                       ` (2 subsequent siblings)
  3 siblings, 0 replies; 34+ messages in thread
From: Kuninori Morimoto @ 2014-12-15  3:53 UTC (permalink / raw)
  To: Matthias Brugger, Rob Herring, Mark Brown
  Cc: Jason Cooper, Heiko Stuebner, Shawn Guo, Florian Vaussard,
	Mark Rutland, Thierry Reding, ALSA Development Mailing List,
	linux-tegra, Stephen Warren, Linux-sh list, Magnus, linux-kernel,
	Olof Johansson, devicetree, Simon Horman, Geert Uytterhoeven,
	Joe Perches, Kuninori Morimoto, linux-arm-kernel, grant.likely

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp
by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.)

It went through the appropriate review process. But, almost all
Asahi Kasei chip drivers are using "asahi-kasei" prefix today.
(arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975",
 but there are instances of "asahi-kasei,ak8975" in other dts files.
 And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix)
So, we made a mistake there.

In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei"
prerfix in DT file.
(DT compatible string vendor "asahi-kasei" appears un-documented)

Marking it deprecated and warning with checkpatch is certainly
preferable. So, this patch replace "ak" to "asahi-kasei" in
vendor-prefixes.txt. (and fixup tegra20-seaboard)

OTOH, Asahi Kasei is usually referred to as "AKM", but this patch
doesn't care about it. Because no DT is using that today.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Acked-by: Alexandre Courbot <acourbot@nvidia.com>
---
Rob, Mark

There is no response about this patch.
Mark, is it possible to care about this patch ?
It has relationship to ASoC.

 .../devicetree/bindings/vendor-prefixes.txt        |    2 +-
 arch/arm/boot/dts/tegra20-seaboard.dts             |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 723999d..ddcb4cd 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -9,7 +9,6 @@ ad	Avionic Design GmbH
 adapteva	Adapteva, Inc.
 adi	Analog Devices, Inc.
 aeroflexgaisler	Aeroflex Gaisler AB
-ak	Asahi Kasei Corp.
 allwinner	Allwinner Technology Co., Ltd.
 altr	Altera Corp.
 amcc	Applied Micro Circuits Corporation (APM, formally AMCC)
@@ -20,6 +19,7 @@ amstaos	AMS-Taos Inc.
 apm	Applied Micro Circuits Corporation (APM)
 arm	ARM Ltd.
 armadeus	ARMadeus Systems SARL
+asahi-kasei	Asahi Kasei Corp.
 atmel	Atmel Corporation
 auo	AU Optronics Corporation
 avago	Avago Technologies
diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts
index a1d4bf9..7f5cf80 100644
--- a/arch/arm/boot/dts/tegra20-seaboard.dts
+++ b/arch/arm/boot/dts/tegra20-seaboard.dts
@@ -405,7 +405,7 @@
 		clock-frequency = <400000>;
 
 		magnetometer@c {
-			compatible = "ak,ak8975";
+			compatible = "asahi-kasei,ak8975";
 			reg = <0xc>;
 			interrupt-parent = <&gpio>;
 			interrupts = <TEGRA_GPIO(N, 5) IRQ_TYPE_LEVEL_HIGH>;
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 34+ messages in thread

* [PATCH v5][resend v3] of: replace Asahi Kasei Corp vendor prefix
  2014-12-02  4:57                                                   ` [PATCH v5][resend] of: replace Asahi Kasei Corp vendor prefix Kuninori Morimoto
  2014-12-15  3:53                                                     ` [PATCH v5][resend v2] " Kuninori Morimoto
@ 2014-12-17  2:33                                                     ` Kuninori Morimoto
  2015-01-09  3:40                                                       ` [PATCH v5][resend v4] " Kuninori Morimoto
  2014-12-25  3:55                                                     ` [PATCH v5][resend v6] " Kuninori Morimoto
  2015-01-13 20:03                                                     ` [PATCH v5][resend] " Rob Herring
  3 siblings, 1 reply; 34+ messages in thread
From: Kuninori Morimoto @ 2014-12-17  2:33 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Matthias Brugger, Rob Herring, Mark Brown,
	ALSA Development Mailing List, linux-tegra, Linux-sh list,
	Magnus, linux-kernel, Simon Horman, Geert Uytterhoeven,
	linux-arm-kernel

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp
by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.)

It went through the appropriate review process. But, almost all
Asahi Kasei chip drivers are using "asahi-kasei" prefix today.
(arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975",
 but there are instances of "asahi-kasei,ak8975" in other dts files.
 And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix)
So, we made a mistake there.

In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei"
prerfix in DT file.
(DT compatible string vendor "asahi-kasei" appears un-documented)

Marking it deprecated and warning with checkpatch is certainly
preferable. So, this patch replace "ak" to "asahi-kasei" in
vendor-prefixes.txt. (and fixup tegra20-seaboard)

OTOH, Asahi Kasei is usually referred to as "AKM", but this patch
doesn't care about it. Because no DT is using that today.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Acked-by: Alexandre Courbot <acourbot@nvidia.com>
---
>> Linus

I had sent this patch to Linux ML and Maintainers many times,
but, no-one cares about it.
Can you please check and apply it ?


 .../devicetree/bindings/vendor-prefixes.txt        |    2 +-
 arch/arm/boot/dts/tegra20-seaboard.dts             |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 723999d..ddcb4cd 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -9,7 +9,6 @@ ad	Avionic Design GmbH
 adapteva	Adapteva, Inc.
 adi	Analog Devices, Inc.
 aeroflexgaisler	Aeroflex Gaisler AB
-ak	Asahi Kasei Corp.
 allwinner	Allwinner Technology Co., Ltd.
 altr	Altera Corp.
 amcc	Applied Micro Circuits Corporation (APM, formally AMCC)
@@ -20,6 +19,7 @@ amstaos	AMS-Taos Inc.
 apm	Applied Micro Circuits Corporation (APM)
 arm	ARM Ltd.
 armadeus	ARMadeus Systems SARL
+asahi-kasei	Asahi Kasei Corp.
 atmel	Atmel Corporation
 auo	AU Optronics Corporation
 avago	Avago Technologies
diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts
index a1d4bf9..7f5cf80 100644
--- a/arch/arm/boot/dts/tegra20-seaboard.dts
+++ b/arch/arm/boot/dts/tegra20-seaboard.dts
@@ -405,7 +405,7 @@
 		clock-frequency = <400000>;
 
 		magnetometer@c {
-			compatible = "ak,ak8975";
+			compatible = "asahi-kasei,ak8975";
 			reg = <0xc>;
 			interrupt-parent = <&gpio>;
 			interrupts = <TEGRA_GPIO(N, 5) IRQ_TYPE_LEVEL_HIGH>;
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 34+ messages in thread

* [PATCH v5][resend v6] of: replace Asahi Kasei Corp vendor prefix
  2014-12-02  4:57                                                   ` [PATCH v5][resend] of: replace Asahi Kasei Corp vendor prefix Kuninori Morimoto
  2014-12-15  3:53                                                     ` [PATCH v5][resend v2] " Kuninori Morimoto
  2014-12-17  2:33                                                     ` [PATCH v5][resend v3] " Kuninori Morimoto
@ 2014-12-25  3:55                                                     ` Kuninori Morimoto
  2015-01-13 20:03                                                     ` [PATCH v5][resend] " Rob Herring
  3 siblings, 0 replies; 34+ messages in thread
From: Kuninori Morimoto @ 2014-12-25  3:55 UTC (permalink / raw)
  To: Linus Torvalds, Rob Herring, Mark Brown, Simon Horman
  Cc: ALSA Development Mailing List, linux-tegra, Linux-sh list,
	Magnus, linux-kernel, linux-arm-kernel

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp
by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.)

It went through the appropriate review process. But, almost all
Asahi Kasei chip drivers are using "asahi-kasei" prefix today.
(arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975",
 but there are instances of "asahi-kasei,ak8975" in other dts files.
 And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix)
So, we made a mistake there.

In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei"
prerfix in DT file.
(DT compatible string vendor "asahi-kasei" appears un-documented)

Marking it deprecated and warning with checkpatch is certainly
preferable. So, this patch replace "ak" to "asahi-kasei" in
vendor-prefixes.txt. (and fixup tegra20-seaboard)

OTOH, Asahi Kasei is usually referred to as "AKM", but this patch
doesn't care about it. Because no DT is using that today.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Acked-by: Alexandre Courbot <acourbot@nvidia.com>
---
>> Linus, Rob, Mark, Simon

I resend this patch many times, but, there is still no response.
Please, please check this patch, and give me some feedback.


 .../devicetree/bindings/vendor-prefixes.txt        |    2 +-
 arch/arm/boot/dts/tegra20-seaboard.dts             |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 723999d..ddcb4cd 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -9,7 +9,6 @@ ad	Avionic Design GmbH
 adapteva	Adapteva, Inc.
 adi	Analog Devices, Inc.
 aeroflexgaisler	Aeroflex Gaisler AB
-ak	Asahi Kasei Corp.
 allwinner	Allwinner Technology Co., Ltd.
 altr	Altera Corp.
 amcc	Applied Micro Circuits Corporation (APM, formally AMCC)
@@ -20,6 +19,7 @@ amstaos	AMS-Taos Inc.
 apm	Applied Micro Circuits Corporation (APM)
 arm	ARM Ltd.
 armadeus	ARMadeus Systems SARL
+asahi-kasei	Asahi Kasei Corp.
 atmel	Atmel Corporation
 auo	AU Optronics Corporation
 avago	Avago Technologies
diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts
index a1d4bf9..7f5cf80 100644
--- a/arch/arm/boot/dts/tegra20-seaboard.dts
+++ b/arch/arm/boot/dts/tegra20-seaboard.dts
@@ -405,7 +405,7 @@
 		clock-frequency = <400000>;
 
 		magnetometer@c {
-			compatible = "ak,ak8975";
+			compatible = "asahi-kasei,ak8975";
 			reg = <0xc>;
 			interrupt-parent = <&gpio>;
 			interrupts = <TEGRA_GPIO(N, 5) IRQ_TYPE_LEVEL_HIGH>;
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH v5][resend v4] of: replace Asahi Kasei Corp vendor prefix
  2014-12-17  2:33                                                     ` [PATCH v5][resend v3] " Kuninori Morimoto
@ 2015-01-09  3:40                                                       ` Kuninori Morimoto
  2015-01-09  3:42                                                         ` [PATCH v5][resend v5] " Kuninori Morimoto
  2015-01-09  4:36                                                         ` [PATCH v5][resend v4] " Stephen Warren
  0 siblings, 2 replies; 34+ messages in thread
From: Kuninori Morimoto @ 2015-01-09  3:40 UTC (permalink / raw)
  To: Stephen Warren, Olof Johansson, Arnd Bergmann, Andrew Morton,
	Rob Herring, Matthias Brugger
  Cc: linux-tegra, linux-sh, linux-arm-kernel, Magnus Damm,
	Simon Horman, Linus Torvalds, Mark Brown,
	ALSA Development Mailing List, linux-tegra, Linux-sh list,
	Magnus, linux-kernel, Simon Horman, Geert Uytterhoeven,
	linux-arm-kernel


Hi Stephen, Olof, Arnd, Rob, Andrew

I'm sending this "of: replace Asahi Kasei Corp vendor prefix" during
half-year (since Jun 2014) , many times. But, no-one care it.
I don't know who is the best maintainer.
 - Stephen : because it has Tegra ?
 - Olof    : because it has Tegra (= ARM) ?
 - Arnd    : because it has Tegra (= ARM) ?
 - Matthias: because it has Tegra (= ARM SoC) ?
 - Rob     : because DT ?
 - Andrew  : Last chance ?

But, could you please care this patch ?
I will re-send it again

> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp
> by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.)
> 
> It went through the appropriate review process. But, almost all
> Asahi Kasei chip drivers are using "asahi-kasei" prefix today.
> (arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975",
>  but there are instances of "asahi-kasei,ak8975" in other dts files.
>  And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix)
> So, we made a mistake there.
> 
> In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei"
> prerfix in DT file.
> (DT compatible string vendor "asahi-kasei" appears un-documented)
> 
> Marking it deprecated and warning with checkpatch is certainly
> preferable. So, this patch replace "ak" to "asahi-kasei" in
> vendor-prefixes.txt. (and fixup tegra20-seaboard)
> 
> OTOH, Asahi Kasei is usually referred to as "AKM", but this patch
> doesn't care about it. Because no DT is using that today.
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Acked-by: Thierry Reding <treding@nvidia.com>
> Acked-by: Alexandre Courbot <acourbot@nvidia.com>
> ---
> >> Linus
> 
> I had sent this patch to Linux ML and Maintainers many times,
> but, no-one cares about it.
> Can you please check and apply it ?
> 
> 
>  .../devicetree/bindings/vendor-prefixes.txt        |    2 +-
>  arch/arm/boot/dts/tegra20-seaboard.dts             |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index 723999d..ddcb4cd 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -9,7 +9,6 @@ ad	Avionic Design GmbH
>  adapteva	Adapteva, Inc.
>  adi	Analog Devices, Inc.
>  aeroflexgaisler	Aeroflex Gaisler AB
> -ak	Asahi Kasei Corp.
>  allwinner	Allwinner Technology Co., Ltd.
>  altr	Altera Corp.
>  amcc	Applied Micro Circuits Corporation (APM, formally AMCC)
> @@ -20,6 +19,7 @@ amstaos	AMS-Taos Inc.
>  apm	Applied Micro Circuits Corporation (APM)
>  arm	ARM Ltd.
>  armadeus	ARMadeus Systems SARL
> +asahi-kasei	Asahi Kasei Corp.
>  atmel	Atmel Corporation
>  auo	AU Optronics Corporation
>  avago	Avago Technologies
> diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts
> index a1d4bf9..7f5cf80 100644
> --- a/arch/arm/boot/dts/tegra20-seaboard.dts
> +++ b/arch/arm/boot/dts/tegra20-seaboard.dts
> @@ -405,7 +405,7 @@
>  		clock-frequency = <400000>;
>  
>  		magnetometer@c {
> -			compatible = "ak,ak8975";
> +			compatible = "asahi-kasei,ak8975";
>  			reg = <0xc>;
>  			interrupt-parent = <&gpio>;
>  			interrupts = <TEGRA_GPIO(N, 5) IRQ_TYPE_LEVEL_HIGH>;
> -- 
> 1.7.9.5
> 

^ permalink raw reply	[flat|nested] 34+ messages in thread

* [PATCH v5][resend v5] of: replace Asahi Kasei Corp vendor prefix
  2015-01-09  3:40                                                       ` [PATCH v5][resend v4] " Kuninori Morimoto
@ 2015-01-09  3:42                                                         ` Kuninori Morimoto
  2015-01-09  4:36                                                         ` [PATCH v5][resend v4] " Stephen Warren
  1 sibling, 0 replies; 34+ messages in thread
From: Kuninori Morimoto @ 2015-01-09  3:42 UTC (permalink / raw)
  To: Stephen Warren, Olof Johansson, Arnd Bergmann, Andrew Morton,
	Rob Herring, Matthias Brugger
  Cc: linux-tegra, linux-sh, linux-arm-kernel, Magnus Damm,
	Simon Horman, Linus Torvalds, Mark Brown,
	ALSA Development Mailing List, linux-kernel, Simon Horman,
	Geert Uytterhoeven

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp
by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.)

It went through the appropriate review process. But, almost all
Asahi Kasei chip drivers are using "asahi-kasei" prefix today.
(arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975",
 but there are instances of "asahi-kasei,ak8975" in other dts files.
 And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix)
So, we made a mistake there.

In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei"
prerfix in DT file.
(DT compatible string vendor "asahi-kasei" appears un-documented)

Marking it deprecated and warning with checkpatch is certainly
preferable. So, this patch replace "ak" to "asahi-kasei" in
vendor-prefixes.txt. (and fixup tegra20-seaboard)

OTOH, Asahi Kasei is usually referred to as "AKM", but this patch
doesn't care about it. Because no DT is using that today.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Acked-by: Alexandre Courbot <acourbot@nvidia.com>
---
v4 -> v5

 - venter -> vendor on Subject
 - fixup Acked-by ordering

 .../devicetree/bindings/vendor-prefixes.txt        |    2 +-
 arch/arm/boot/dts/tegra20-seaboard.dts             |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 723999d..ddcb4cd 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -9,7 +9,6 @@ ad	Avionic Design GmbH
 adapteva	Adapteva, Inc.
 adi	Analog Devices, Inc.
 aeroflexgaisler	Aeroflex Gaisler AB
-ak	Asahi Kasei Corp.
 allwinner	Allwinner Technology Co., Ltd.
 altr	Altera Corp.
 amcc	Applied Micro Circuits Corporation (APM, formally AMCC)
@@ -20,6 +19,7 @@ amstaos	AMS-Taos Inc.
 apm	Applied Micro Circuits Corporation (APM)
 arm	ARM Ltd.
 armadeus	ARMadeus Systems SARL
+asahi-kasei	Asahi Kasei Corp.
 atmel	Atmel Corporation
 auo	AU Optronics Corporation
 avago	Avago Technologies
diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts
index a1d4bf9..7f5cf80 100644
--- a/arch/arm/boot/dts/tegra20-seaboard.dts
+++ b/arch/arm/boot/dts/tegra20-seaboard.dts
@@ -405,7 +405,7 @@
 		clock-frequency = <400000>;
 
 		magnetometer@c {
-			compatible = "ak,ak8975";
+			compatible = "asahi-kasei,ak8975";
 			reg = <0xc>;
 			interrupt-parent = <&gpio>;
 			interrupts = <TEGRA_GPIO(N, 5) IRQ_TYPE_LEVEL_HIGH>;
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH v5][resend v4] of: replace Asahi Kasei Corp vendor prefix
  2015-01-09  3:40                                                       ` [PATCH v5][resend v4] " Kuninori Morimoto
  2015-01-09  3:42                                                         ` [PATCH v5][resend v5] " Kuninori Morimoto
@ 2015-01-09  4:36                                                         ` Stephen Warren
  2015-01-09 10:07                                                           ` Kuninori Morimoto
  1 sibling, 1 reply; 34+ messages in thread
From: Stephen Warren @ 2015-01-09  4:36 UTC (permalink / raw)
  To: Kuninori Morimoto
  Cc: Olof Johansson, Arnd Bergmann, Andrew Morton, Rob Herring,
	Matthias Brugger, linux-tegra, linux-sh, linux-arm-kernel,
	Magnus Damm, Simon Horman, Linus Torvalds, Mark Brown,
	ALSA Development Mailing List, linux-kernel, Simon Horman,
	Geert Uytterhoeven

On 01/08/2015 08:40 PM, Kuninori Morimoto wrote:
> 
> Hi Stephen, Olof, Arnd, Rob, Andrew
> 
> I'm sending this "of: replace Asahi Kasei Corp vendor prefix" during
> half-year (since Jun 2014) , many times. But, no-one care it.
> I don't know who is the best maintainer.
>  - Stephen : because it has Tegra ?
>  - Olof    : because it has Tegra (= ARM) ?
>  - Arnd    : because it has Tegra (= ARM) ?
>  - Matthias: because it has Tegra (= ARM SoC) ?
>  - Rob     : because DT ?
>  - Andrew  : Last chance ?
> 
> But, could you please care this patch ?
> I will re-send it again

It doesn't seem to be ack'd by any of the DT maintainers. Retro-actively
changing a DT vendor name would need that, I think.

Thierry and Alex (both Tegra maintainers) appear to have ack'd it, so it
seems they expect it to go through some tree other than Tegra. Weren't
there a bunch of related patches along with this (e.g. updating relevant
drivers to support both prefixes?) so it was expected this patch would
be applied together with them?

>> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>>
>> Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp
>> by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.)
>>
>> It went through the appropriate review process. But, almost all
>> Asahi Kasei chip drivers are using "asahi-kasei" prefix today.
>> (arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975",
>>  but there are instances of "asahi-kasei,ak8975" in other dts files.
>>  And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix)
>> So, we made a mistake there.
>>
>> In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei"
>> prerfix in DT file.
>> (DT compatible string vendor "asahi-kasei" appears un-documented)
>>
>> Marking it deprecated and warning with checkpatch is certainly
>> preferable. So, this patch replace "ak" to "asahi-kasei" in
>> vendor-prefixes.txt. (and fixup tegra20-seaboard)
>>
>> OTOH, Asahi Kasei is usually referred to as "AKM", but this patch
>> doesn't care about it. Because no DT is using that today.
>>
>> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>> Acked-by: Thierry Reding <treding@nvidia.com>
>> Acked-by: Alexandre Courbot <acourbot@nvidia.com>

>> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt

>> -ak	Asahi Kasei Corp.

>> +asahi-kasei	Asahi Kasei Corp.

>> diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts

>>  		magnetometer@c {
>> -			compatible = "ak,ak8975";
>> +			compatible = "asahi-kasei,ak8975";


^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH v5][resend v4] of: replace Asahi Kasei Corp vendor prefix
  2015-01-09  4:36                                                         ` [PATCH v5][resend v4] " Stephen Warren
@ 2015-01-09 10:07                                                           ` Kuninori Morimoto
  2015-01-09 13:46                                                             ` Rob Herring
  0 siblings, 1 reply; 34+ messages in thread
From: Kuninori Morimoto @ 2015-01-09 10:07 UTC (permalink / raw)
  To: Stephen Warren
  Cc: Olof Johansson, Arnd Bergmann, Andrew Morton, Rob Herring,
	Matthias Brugger, linux-tegra, linux-sh, linux-arm-kernel,
	Magnus Damm, Simon Horman, Linus Torvalds, Mark Brown,
	ALSA Development Mailing List, linux-kernel, Simon Horman,
	Geert Uytterhoeven


Hi Stephen

Thank you for your feedback

> > I'm sending this "of: replace Asahi Kasei Corp vendor prefix" during
> > half-year (since Jun 2014) , many times. But, no-one care it.
> > I don't know who is the best maintainer.
> >  - Stephen : because it has Tegra ?
> >  - Olof    : because it has Tegra (= ARM) ?
> >  - Arnd    : because it has Tegra (= ARM) ?
> >  - Matthias: because it has Tegra (= ARM SoC) ?
> >  - Rob     : because DT ?
> >  - Andrew  : Last chance ?
> > 
> > But, could you please care this patch ?
> > I will re-send it again
> 
> It doesn't seem to be ack'd by any of the DT maintainers. Retro-actively
> changing a DT vendor name would need that, I think.

Rob ?
I had sent this patch to him since half-years ago, many times...
Or other maintainer ?

> Thierry and Alex (both Tegra maintainers) appear to have ack'd it, so it
> seems they expect it to go through some tree other than Tegra. Weren't
> there a bunch of related patches along with this (e.g. updating relevant
> drivers to support both prefixes?) so it was expected this patch would
> be applied together with them?

I guess they expected it goes to DT branch (?)
This is only 1 patch. it doesn't have related patch-set

> >> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >>
> >> Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp
> >> by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.)
> >>
> >> It went through the appropriate review process. But, almost all
> >> Asahi Kasei chip drivers are using "asahi-kasei" prefix today.
> >> (arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975",
> >>  but there are instances of "asahi-kasei,ak8975" in other dts files.
> >>  And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix)
> >> So, we made a mistake there.
> >>
> >> In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei"
> >> prerfix in DT file.
> >> (DT compatible string vendor "asahi-kasei" appears un-documented)
> >>
> >> Marking it deprecated and warning with checkpatch is certainly
> >> preferable. So, this patch replace "ak" to "asahi-kasei" in
> >> vendor-prefixes.txt. (and fixup tegra20-seaboard)
> >>
> >> OTOH, Asahi Kasei is usually referred to as "AKM", but this patch
> >> doesn't care about it. Because no DT is using that today.
> >>
> >> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >> Acked-by: Thierry Reding <treding@nvidia.com>
> >> Acked-by: Alexandre Courbot <acourbot@nvidia.com>
> 
> >> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> 
> >> -ak	Asahi Kasei Corp.
> 
> >> +asahi-kasei	Asahi Kasei Corp.
> 
> >> diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts
> 
> >>  		magnetometer@c {
> >> -			compatible = "ak,ak8975";
> >> +			compatible = "asahi-kasei,ak8975";
> 


Best regards
---
Kuninori Morimoto

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH v5][resend v4] of: replace Asahi Kasei Corp vendor prefix
  2015-01-09 10:07                                                           ` Kuninori Morimoto
@ 2015-01-09 13:46                                                             ` Rob Herring
  2015-01-09 13:55                                                               ` Arnd Bergmann
  0 siblings, 1 reply; 34+ messages in thread
From: Rob Herring @ 2015-01-09 13:46 UTC (permalink / raw)
  To: Kuninori Morimoto
  Cc: Stephen Warren, Olof Johansson, Arnd Bergmann, Andrew Morton,
	Matthias Brugger, linux-tegra, SH-Linux, linux-arm-kernel,
	Magnus Damm, Simon Horman, Linus Torvalds, Mark Brown,
	ALSA Development Mailing List, linux-kernel, Simon Horman,
	Geert Uytterhoeven

On Fri, Jan 9, 2015 at 4:07 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>
> Hi Stephen
>
> Thank you for your feedback
>
>> > I'm sending this "of: replace Asahi Kasei Corp vendor prefix" during
>> > half-year (since Jun 2014) , many times. But, no-one care it.
>> > I don't know who is the best maintainer.
>> >  - Stephen : because it has Tegra ?
>> >  - Olof    : because it has Tegra (= ARM) ?
>> >  - Arnd    : because it has Tegra (= ARM) ?
>> >  - Matthias: because it has Tegra (= ARM SoC) ?
>> >  - Rob     : because DT ?
>> >  - Andrew  : Last chance ?
>> >
>> > But, could you please care this patch ?
>> > I will re-send it again
>>
>> It doesn't seem to be ack'd by any of the DT maintainers. Retro-actively
>> changing a DT vendor name would need that, I think.
>
> Rob ?
> I had sent this patch to him since half-years ago, many times...
> Or other maintainer ?
>
>> Thierry and Alex (both Tegra maintainers) appear to have ack'd it, so it
>> seems they expect it to go through some tree other than Tegra. Weren't
>> there a bunch of related patches along with this (e.g. updating relevant
>> drivers to support both prefixes?) so it was expected this patch would
>> be applied together with them?
>
> I guess they expected it goes to DT branch (?)
> This is only 1 patch. it doesn't have related patch-set

It is in my queue. If the users of it are fine with breaking things,
who am I to argue with them.

Rob

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH v5][resend v4] of: replace Asahi Kasei Corp vendor prefix
  2015-01-09 13:46                                                             ` Rob Herring
@ 2015-01-09 13:55                                                               ` Arnd Bergmann
  2015-01-09 16:04                                                                 ` Mark Brown
  0 siblings, 1 reply; 34+ messages in thread
From: Arnd Bergmann @ 2015-01-09 13:55 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Rob Herring, Kuninori Morimoto, Simon Horman,
	ALSA Development Mailing List, linux-tegra, Stephen Warren,
	SH-Linux, Magnus Damm, linux-kernel, Matthias Brugger,
	Mark Brown, Geert Uytterhoeven, Olof Johansson, Simon Horman,
	Andrew Morton, Linus Torvalds

On Friday 09 January 2015 07:46:16 Rob Herring wrote:
> On Fri, Jan 9, 2015 at 4:07 AM, Kuninori Morimoto
> <kuninori.morimoto.gx@renesas.com> wrote:
> >
> > Hi Stephen
> >
> > Thank you for your feedback
> >
> >> > I'm sending this "of: replace Asahi Kasei Corp vendor prefix" during
> >> > half-year (since Jun 2014) , many times. But, no-one care it.
> >> > I don't know who is the best maintainer.
> >> >  - Stephen : because it has Tegra ?
> >> >  - Olof    : because it has Tegra (= ARM) ?
> >> >  - Arnd    : because it has Tegra (= ARM) ?
> >> >  - Matthias: because it has Tegra (= ARM SoC) ?
> >> >  - Rob     : because DT ?
> >> >  - Andrew  : Last chance ?
> >> >
> >> > But, could you please care this patch ?
> >> > I will re-send it again
> >>
> >> It doesn't seem to be ack'd by any of the DT maintainers. Retro-actively
> >> changing a DT vendor name would need that, I think.
> >
> > Rob ?
> > I had sent this patch to him since half-years ago, many times...
> > Or other maintainer ?
> >
> >> Thierry and Alex (both Tegra maintainers) appear to have ack'd it, so it
> >> seems they expect it to go through some tree other than Tegra. Weren't
> >> there a bunch of related patches along with this (e.g. updating relevant
> >> drivers to support both prefixes?) so it was expected this patch would
> >> be applied together with them?
> >
> > I guess they expected it goes to DT branch (?)
> > This is only 1 patch. it doesn't have related patch-set
> 
> It is in my queue. If the users of it are fine with breaking things,
> who am I to argue with them.

It's an i2c device, so it won't break, based on the implementation
we use in the kernel that ignores the vendor part when the part number
matches the i2c driver name.

I also don't think we need to worry about any non-Linux operating
systems on this board that might share the same dts file.

	Arnd

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH v5][resend v4] of: replace Asahi Kasei Corp vendor prefix
  2015-01-09 13:55                                                               ` Arnd Bergmann
@ 2015-01-09 16:04                                                                 ` Mark Brown
  0 siblings, 0 replies; 34+ messages in thread
From: Mark Brown @ 2015-01-09 16:04 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: linux-arm-kernel, Rob Herring, Kuninori Morimoto, Simon Horman,
	ALSA Development Mailing List, linux-tegra, Stephen Warren,
	SH-Linux, Magnus Damm, linux-kernel, Matthias Brugger,
	Geert Uytterhoeven, Olof Johansson, Simon Horman, Andrew Morton,
	Linus Torvalds

[-- Attachment #1: Type: text/plain, Size: 451 bytes --]

On Fri, Jan 09, 2015 at 02:55:40PM +0100, Arnd Bergmann wrote:

> It's an i2c device, so it won't break, based on the implementation
> we use in the kernel that ignores the vendor part when the part number
> matches the i2c driver name.

Plus this update is actually changing the board DT file have the ID
which we've always had in the driver, the driver has always used the new
string and never the ak, based one that the device tree is registering.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH v5][resend] of: replace Asahi Kasei Corp vendor prefix
  2014-12-02  4:57                                                   ` [PATCH v5][resend] of: replace Asahi Kasei Corp vendor prefix Kuninori Morimoto
                                                                       ` (2 preceding siblings ...)
  2014-12-25  3:55                                                     ` [PATCH v5][resend v6] " Kuninori Morimoto
@ 2015-01-13 20:03                                                     ` Rob Herring
  3 siblings, 0 replies; 34+ messages in thread
From: Rob Herring @ 2015-01-13 20:03 UTC (permalink / raw)
  To: Kuninori Morimoto
  Cc: Matthias Brugger, Jason Cooper, Heiko Stuebner, Shawn Guo,
	Florian Vaussard, Mark Brown, Mark Rutland, Thierry Reding,
	ALSA Development Mailing List, linux-tegra, Stephen Warren,
	Linux-sh list, Magnus, linux-kernel, Olof Johansson, devicetree,
	Simon Horman, Geert Uytterhoeven, Joe Perches, Kuninori Morimoto,
	linux-arm-kernel, grant.likely

On Mon, Dec 1, 2014 at 10:57 PM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp
> by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.)
>
> It went through the appropriate review process. But, almost all
> Asahi Kasei chip drivers are using "asahi-kasei" prefix today.
> (arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975",
>  but there are instances of "asahi-kasei,ak8975" in other dts files.
>  And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix)
> So, we made a mistake there.
>
> In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei"
> prerfix in DT file.
> (DT compatible string vendor "asahi-kasei" appears un-documented)
>
> Marking it deprecated and warning with checkpatch is certainly
> preferable. So, this patch replace "ak" to "asahi-kasei" in
> vendor-prefixes.txt. (and fixup tegra20-seaboard)
>
> OTOH, Asahi Kasei is usually referred to as "AKM", but this patch
> doesn't care about it. Because no DT is using that today.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Acked-by: Thierry Reding <treding@nvidia.com>
> Acked-by: Alexandre Courbot <acourbot@nvidia.com>

Applied for 3.20. Thanks.

> ---
> v4 -> v5
>
>  - venter -> vendor on Subject
>  - fixup Acked-by ordering
>
>  .../devicetree/bindings/vendor-prefixes.txt        |    2 +-
>  arch/arm/boot/dts/tegra20-seaboard.dts             |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index 723999d..ddcb4cd 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -9,7 +9,6 @@ ad      Avionic Design GmbH
>  adapteva       Adapteva, Inc.
>  adi    Analog Devices, Inc.
>  aeroflexgaisler        Aeroflex Gaisler AB
> -ak     Asahi Kasei Corp.
>  allwinner      Allwinner Technology Co., Ltd.
>  altr   Altera Corp.
>  amcc   Applied Micro Circuits Corporation (APM, formally AMCC)
> @@ -20,6 +19,7 @@ amstaos       AMS-Taos Inc.
>  apm    Applied Micro Circuits Corporation (APM)
>  arm    ARM Ltd.
>  armadeus       ARMadeus Systems SARL
> +asahi-kasei    Asahi Kasei Corp.
>  atmel  Atmel Corporation
>  auo    AU Optronics Corporation
>  avago  Avago Technologies
> diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts
> index a1d4bf9..7f5cf80 100644
> --- a/arch/arm/boot/dts/tegra20-seaboard.dts
> +++ b/arch/arm/boot/dts/tegra20-seaboard.dts
> @@ -405,7 +405,7 @@
>                 clock-frequency = <400000>;
>
>                 magnetometer@c {
> -                       compatible = "ak,ak8975";
> +                       compatible = "asahi-kasei,ak8975";
>                         reg = <0xc>;
>                         interrupt-parent = <&gpio>;
>                         interrupts = <TEGRA_GPIO(N, 5) IRQ_TYPE_LEVEL_HIGH>;
> --
> 1.7.9.5
>

^ permalink raw reply	[flat|nested] 34+ messages in thread

end of thread, other threads:[~2015-01-13 20:04 UTC | newest]

Thread overview: 34+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CAMuHMdWTVBjFzA9L9Eqpq_2Xi9_NHkOCLrb_UjK611SBfwnc=Q@mail.gmail.com>
     [not found] ` <87ioo7c0g5.wl%kuninori.morimoto.gx@renesas.com>
     [not found]   ` <539815E6.2050304@codethink.co.uk>
     [not found]     ` <20140611165410.GK5099@sirena.org.uk>
     [not found]       ` <CAMuHMdUT0hEBGbN+W-Oz5zJ0N8S2VDMndqtDO=EtWF3jG2MEew@mail.gmail.com>
     [not found]         ` <20140611170233.GL5099@sirena.org.uk>
     [not found]           ` <5398A53D.3020706@wwwdotorg.org>
     [not found]             ` <20140611190444.GN5099@sirena.org.uk>
     [not found]               ` <5398AB07.4040304@wwwdotorg.org>
2014-06-12  0:53                 ` [PATCH] of: Add vendor 2nd prefix for Asahi Kasei Corp Kuninori Morimoto
2014-06-12  0:59                   ` Simon Horman
2014-06-12 15:33                   ` Stephen Warren
2014-09-04  6:08                   ` [PATCH][resend] " Kuninori Morimoto
2014-09-22 13:00                     ` Mark Rutland
2014-09-22 13:24                       ` Geert Uytterhoeven
2014-09-22 13:27                         ` Mark Rutland
2014-11-13  2:18                           ` Kuninori Morimoto
2014-11-13  2:21                             ` Joe Perches
2014-11-13  2:51                               ` Simon Horman
2014-11-13  3:33                                 ` Kuninori Morimoto
2014-11-13 11:07                                   ` Mark Brown
2014-11-14  1:43                                     ` [PATCH v3] of: replace Asahi Kasei Corp venter prefix Kuninori Morimoto
2014-11-14  8:38                                       ` Alexandre Courbot
2014-11-14  9:16                                         ` Arnd Bergmann
2014-11-14  9:30                                         ` Thierry Reding
2014-11-14  9:35                                       ` [alsa-devel] " Thierry Reding
2014-11-17  0:51                                         ` [PATCH v4] " Kuninori Morimoto
2014-11-17 10:26                                           ` Sergei Shtylyov
2014-11-18  0:30                                             ` [PATCH v5] of: replace Asahi Kasei Corp vendor prefix Kuninori Morimoto
2014-11-28  0:22                                               ` [PATCH v5][resend] of: replace Asahi Kasei Corp venter prefix Kuninori Morimoto
2014-11-28 11:45                                                 ` Sergei Shtylyov
2014-12-02  4:57                                                   ` [PATCH v5][resend] of: replace Asahi Kasei Corp vendor prefix Kuninori Morimoto
2014-12-15  3:53                                                     ` [PATCH v5][resend v2] " Kuninori Morimoto
2014-12-17  2:33                                                     ` [PATCH v5][resend v3] " Kuninori Morimoto
2015-01-09  3:40                                                       ` [PATCH v5][resend v4] " Kuninori Morimoto
2015-01-09  3:42                                                         ` [PATCH v5][resend v5] " Kuninori Morimoto
2015-01-09  4:36                                                         ` [PATCH v5][resend v4] " Stephen Warren
2015-01-09 10:07                                                           ` Kuninori Morimoto
2015-01-09 13:46                                                             ` Rob Herring
2015-01-09 13:55                                                               ` Arnd Bergmann
2015-01-09 16:04                                                                 ` Mark Brown
2014-12-25  3:55                                                     ` [PATCH v5][resend v6] " Kuninori Morimoto
2015-01-13 20:03                                                     ` [PATCH v5][resend] " Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).