LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 1/2] staging: lustre: lnet: lnet: do not initialise statics to 0 or NULL
@ 2014-11-24 6:03 Balavasu kuppusammyprathaban
2014-11-24 16:53 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Balavasu kuppusammyprathaban @ 2014-11-24 6:03 UTC (permalink / raw)
To: linux-kernel; +Cc: andreas.dilger, oleg.drokin, greg
This patch fixes the checkpatch.pl issue
Error: do not initialise statics to 0 or NULL
Signed-off-by: Balavasu kuppusammyprathaban<kp.balavasu@gmail.com>
---
drivers/staging/lustre/lnet/lnet/router.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/lustre/lnet/lnet/router.c b/drivers/staging/lustre/lnet/lnet/router.c
index b5b8fb5..cdeb246 100644
--- a/drivers/staging/lustre/lnet/lnet/router.c
+++ b/drivers/staging/lustre/lnet/lnet/router.c
@@ -46,7 +46,7 @@ MODULE_PARM_DESC(small_router_buffers, "# of small (1 page) messages to buffer i
static int large_router_buffers;
module_param(large_router_buffers, int, 0444);
MODULE_PARM_DESC(large_router_buffers, "# of large messages to buffer in the router");
-static int peer_buffer_credits = 0;
+static int peer_buffer_credits;
module_param(peer_buffer_credits, int, 0444);
MODULE_PARM_DESC(peer_buffer_credits, "# router buffer credits per peer");
@@ -80,7 +80,7 @@ lnet_peer_buffer_credits(lnet_ni_t *ni)
#endif
-static int check_routers_before_use = 0;
+static int check_routers_before_use;
module_param(check_routers_before_use, int, 0444);
MODULE_PARM_DESC(check_routers_before_use, "Assume routers are down and ping them before use");
@@ -245,7 +245,7 @@ lnet_find_net_locked (__u32 net)
static void lnet_shuffle_seed(void)
{
- static int seeded = 0;
+ static int seeded;
int lnd_type, seed[2];
struct timeval tv;
lnet_ni_t *ni;
@@ -1584,8 +1584,8 @@ lnet_notify (lnet_ni_t *ni, lnet_nid_t nid, int alive, unsigned long when)
void
lnet_router_checker (void)
{
- static time_t last = 0;
- static int running = 0;
+ static time_t last;
+ static int running;
time_t now = get_seconds();
int interval = now - last;
--
1.9.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] staging: lustre: lnet: lnet: do not initialise statics to 0 or NULL
2014-11-24 6:03 [PATCH 1/2] staging: lustre: lnet: lnet: do not initialise statics to 0 or NULL Balavasu kuppusammyprathaban
@ 2014-11-24 16:53 ` Greg KH
0 siblings, 0 replies; 7+ messages in thread
From: Greg KH @ 2014-11-24 16:53 UTC (permalink / raw)
To: Balavasu kuppusammyprathaban; +Cc: linux-kernel, andreas.dilger, oleg.drokin
On Mon, Nov 24, 2014 at 11:33:18AM +0530, Balavasu kuppusammyprathaban wrote:
> This patch fixes the checkpatch.pl issue
> Error: do not initialise statics to 0 or NULL
>
> Signed-off-by: Balavasu kuppusammyprathaban<kp.balavasu@gmail.com>
> ---
> drivers/staging/lustre/lnet/lnet/router.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Any reason why you aren't using scripts/get_maintainer.pl?
Also, you need a ' ' after your name and before the '<' character.
As well as properly capitalizing your name.
Please redo both patches.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] staging: lustre: lnet: lnet: do not initialise statics to 0 or NULL
@ 2014-12-29 14:30 Balavasu
0 siblings, 0 replies; 7+ messages in thread
From: Balavasu @ 2014-12-29 14:30 UTC (permalink / raw)
To: linux-kernel; +Cc: andreas.dilger, oleg.drokin, greg
This patch fixes the checkpatch.pl issue
Error: do not initialise statics to 0 or NULL
Signed-off-by: Balavasu <kp.balavasu@gmail.com>
---
drivers/staging/lustre/lnet/lnet/router.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/lustre/lnet/lnet/router.c b/drivers/staging/lustre/lnet/lnet/router.c
index b5b8fb5..cdeb246 100644
--- a/drivers/staging/lustre/lnet/lnet/router.c
+++ b/drivers/staging/lustre/lnet/lnet/router.c
@@ -46,7 +46,7 @@ MODULE_PARM_DESC(small_router_buffers, "# of small (1 page) messages to buffer i
static int large_router_buffers;
module_param(large_router_buffers, int, 0444);
MODULE_PARM_DESC(large_router_buffers, "# of large messages to buffer in the router");
-static int peer_buffer_credits = 0;
+static int peer_buffer_credits;
module_param(peer_buffer_credits, int, 0444);
MODULE_PARM_DESC(peer_buffer_credits, "# router buffer credits per peer");
@@ -80,7 +80,7 @@ lnet_peer_buffer_credits(lnet_ni_t *ni)
#endif
-static int check_routers_before_use = 0;
+static int check_routers_before_use;
module_param(check_routers_before_use, int, 0444);
MODULE_PARM_DESC(check_routers_before_use, "Assume routers are down and ping them before use");
@@ -245,7 +245,7 @@ lnet_find_net_locked (__u32 net)
static void lnet_shuffle_seed(void)
{
- static int seeded = 0;
+ static int seeded;
int lnd_type, seed[2];
struct timeval tv;
lnet_ni_t *ni;
@@ -1584,8 +1584,8 @@ lnet_notify (lnet_ni_t *ni, lnet_nid_t nid, int alive, unsigned long when)
void
lnet_router_checker (void)
{
- static time_t last = 0;
- static int running = 0;
+ static time_t last;
+ static int running;
time_t now = get_seconds();
int interval = now - last;
--
1.9.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] staging: lustre: lnet: lnet: do not initialise statics to 0 or NULL
2014-11-23 18:45 Balavasu kuppusammyprathaban
@ 2014-11-23 19:00 ` Greg KH
0 siblings, 0 replies; 7+ messages in thread
From: Greg KH @ 2014-11-23 19:00 UTC (permalink / raw)
To: Balavasu kuppusammyprathaban; +Cc: linux-kernel, andreas.dilger, oleg.drokin
On Mon, Nov 24, 2014 at 12:15:21AM +0530, Balavasu kuppusammyprathaban wrote:
> This patch fixes the checkpatch.pl issue
> Error: do not initialise statics to 0 or NULL
>
> Signed-off-by: Balavasu <kp.balavasu@gmail.com>
You seem to have ignored everything I said in my last response to your
previous submission, which is a bit rude, don't you think?
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] staging: lustre: lnet: lnet: do not initialise statics to 0 or NULL
@ 2014-11-23 18:45 Balavasu kuppusammyprathaban
2014-11-23 19:00 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Balavasu kuppusammyprathaban @ 2014-11-23 18:45 UTC (permalink / raw)
To: linux-kernel; +Cc: andreas.dilger, oleg.drokin, greg
This patch fixes the checkpatch.pl issue
Error: do not initialise statics to 0 or NULL
Signed-off-by: Balavasu <kp.balavasu@gmail.com>
---
drivers/staging/lustre/lnet/lnet/router.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/lustre/lnet/lnet/router.c b/drivers/staging/lustre/lnet/lnet/router.c
index b5b8fb5..cdeb246 100644
--- a/drivers/staging/lustre/lnet/lnet/router.c
+++ b/drivers/staging/lustre/lnet/lnet/router.c
@@ -46,7 +46,7 @@ MODULE_PARM_DESC(small_router_buffers, "# of small (1 page) messages to buffer i
static int large_router_buffers;
module_param(large_router_buffers, int, 0444);
MODULE_PARM_DESC(large_router_buffers, "# of large messages to buffer in the router");
-static int peer_buffer_credits = 0;
+static int peer_buffer_credits;
module_param(peer_buffer_credits, int, 0444);
MODULE_PARM_DESC(peer_buffer_credits, "# router buffer credits per peer");
@@ -80,7 +80,7 @@ lnet_peer_buffer_credits(lnet_ni_t *ni)
#endif
-static int check_routers_before_use = 0;
+static int check_routers_before_use;
module_param(check_routers_before_use, int, 0444);
MODULE_PARM_DESC(check_routers_before_use, "Assume routers are down and ping them before use");
@@ -245,7 +245,7 @@ lnet_find_net_locked (__u32 net)
static void lnet_shuffle_seed(void)
{
- static int seeded = 0;
+ static int seeded;
int lnd_type, seed[2];
struct timeval tv;
lnet_ni_t *ni;
@@ -1584,8 +1584,8 @@ lnet_notify (lnet_ni_t *ni, lnet_nid_t nid, int alive, unsigned long when)
void
lnet_router_checker (void)
{
- static time_t last = 0;
- static int running = 0;
+ static time_t last;
+ static int running;
time_t now = get_seconds();
int interval = now - last;
--
1.9.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] staging: lustre: lnet: lnet: do not initialise statics to 0 or NULL
2014-10-31 18:18 Balavasu
@ 2014-10-31 20:50 ` Greg KH
0 siblings, 0 replies; 7+ messages in thread
From: Greg KH @ 2014-10-31 20:50 UTC (permalink / raw)
To: Balavasu; +Cc: netdev, linux-kernel, andreas.dilger, oleg.drokin
On Fri, Oct 31, 2014 at 11:48:08PM +0530, Balavasu wrote:
> This patch fixes the checkpatch.pl issue
> Error: do not initialise statics to 0 or NULL for time
>
> Signed-off-by: Balavasu <kp.balavasu@gmail.com>
> ---
> drivers/staging/lustre/lnet/lnet/do not instalise 0 | 10 +++++-----
That line doesn't look right, does it?
And why netdev and not the mailing list for the drivers/staging/ tree?
And again, I need a full name.
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] staging: lustre: lnet: lnet: do not initialise statics to 0 or NULL
@ 2014-10-31 18:18 Balavasu
2014-10-31 20:50 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Balavasu @ 2014-10-31 18:18 UTC (permalink / raw)
To: netdev, linux-kernel; +Cc: greg, andreas.dilger, oleg.drokin
This patch fixes the checkpatch.pl issue
Error: do not initialise statics to 0 or NULL for time
Signed-off-by: Balavasu <kp.balavasu@gmail.com>
---
drivers/staging/lustre/lnet/lnet/do not instalise 0 | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/lustre/lnet/lnet/router.c b/drivers/staging/lustre/lnet/lnet/router.c
index b5b8fb5..cdeb246 100644
--- a/drivers/staging/lustre/lnet/lnet/router.c
+++ b/drivers/staging/lustre/lnet/lnet/router.c
@@ -46,7 +46,7 @@ MODULE_PARM_DESC(small_router_buffers, "# of small (1 page) messages to buffer i
static int large_router_buffers;
module_param(large_router_buffers, int, 0444);
MODULE_PARM_DESC(large_router_buffers, "# of large messages to buffer in the router");
-static int peer_buffer_credits = 0;
+static int peer_buffer_credits;
module_param(peer_buffer_credits, int, 0444);
MODULE_PARM_DESC(peer_buffer_credits, "# router buffer credits per peer");
@@ -80,7 +80,7 @@ lnet_peer_buffer_credits(lnet_ni_t *ni)
#endif
-static int check_routers_before_use = 0;
+static int check_routers_before_use;
module_param(check_routers_before_use, int, 0444);
MODULE_PARM_DESC(check_routers_before_use, "Assume routers are down and ping them before use");
@@ -245,7 +245,7 @@ lnet_find_net_locked (__u32 net)
static void lnet_shuffle_seed(void)
{
- static int seeded = 0;
+ static int seeded;
int lnd_type, seed[2];
struct timeval tv;
lnet_ni_t *ni;
@@ -1584,8 +1584,8 @@ lnet_notify (lnet_ni_t *ni, lnet_nid_t nid, int alive, unsigned long when)
void
lnet_router_checker (void)
{
- static time_t last = 0;
- static int running = 0;
+ static time_t last;
+ static int running;
time_t now = get_seconds();
int interval = now - last;
--
1.9.1
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-12-29 14:30 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-24 6:03 [PATCH 1/2] staging: lustre: lnet: lnet: do not initialise statics to 0 or NULL Balavasu kuppusammyprathaban
2014-11-24 16:53 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2014-12-29 14:30 Balavasu
2014-11-23 18:45 Balavasu kuppusammyprathaban
2014-11-23 19:00 ` Greg KH
2014-10-31 18:18 Balavasu
2014-10-31 20:50 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).