LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Michal Hocko <mhocko@suse.cz>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
	cgroups@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: memcontrol.c:  Cleaning up function that are not used anywhere
Date: Wed, 3 Dec 2014 16:54:51 +0100	[thread overview]
Message-ID: <20141203155451.GI23236@dhcp22.suse.cz> (raw)
In-Reply-To: <20141203152231.GA2822@phnom.home.cmpxchg.org>

On Wed 03-12-14 10:22:31, Johannes Weiner wrote:
> On Tue, Dec 02, 2014 at 11:41:23PM +0100, Rickard Strandqvist wrote:
> > Remove function mem_cgroup_lru_names_not_uptodate() that is not used anywhere.
> > 
> > This was partially found by using a static code analysis program called cppcheck.
> > 
> > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> > ---
> >  mm/memcontrol.c |    5 -----
> >  1 file changed, 5 deletions(-)
> > 
> > diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> > index d6ac0e3..5edd1fe 100644
> > --- a/mm/memcontrol.c
> > +++ b/mm/memcontrol.c
> > @@ -4379,11 +4379,6 @@ static int memcg_numa_stat_show(struct seq_file *m, void *v)
> >  }
> >  #endif /* CONFIG_NUMA */
> >  
> > -static inline void mem_cgroup_lru_names_not_uptodate(void)
> > -{
> > -	BUILD_BUG_ON(ARRAY_SIZE(mem_cgroup_lru_names) != NR_LRU_LISTS);
> > -}
> 
> That assertion doesn't work in an unused function, but we still want
> this check.  Please move the BUILD_BUG_ON() to the beginning of
> memcg_stat_show() instead.

Ohh. I have completely missed the point of the check! Moving the check
to memcg_stat_show sounds like a good idea.

-- 
Michal Hocko
SUSE Labs

  reply	other threads:[~2014-12-03 15:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-02 22:41 Rickard Strandqvist
2014-12-03  9:22 ` Michal Hocko
2014-12-03 15:22 ` Johannes Weiner
2014-12-03 15:54   ` Michal Hocko [this message]
2014-12-03 17:04     ` Rickard Strandqvist
2014-12-06 16:45 Rickard Strandqvist
2014-12-07 10:31 ` Michal Hocko
2014-12-08 16:02 ` Johannes Weiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141203155451.GI23236@dhcp22.suse.cz \
    --to=mhocko@suse.cz \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rickard_strandqvist@spectrumdigital.se \
    --subject='Re: [PATCH] mm: memcontrol.c:  Cleaning up function that are not used anywhere' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).