From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751925AbaLERj5 (ORCPT ); Fri, 5 Dec 2014 12:39:57 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:49494 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751338AbaLERj4 (ORCPT ); Fri, 5 Dec 2014 12:39:56 -0500 Date: Fri, 5 Dec 2014 17:39:32 +0000 From: Mark Brown To: Charles Keepax Cc: Zidan Wang , lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.de, lars@metafoo.de, Li.Xiubo@freescale.com, patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Message-ID: <20141205173932.GN11764@sirena.org.uk> References: <1417696879-15402-1-git-send-email-b50113@freescale.com> <20141205170156.GB14516@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="v541l457l4DThMFo" Content-Disposition: inline In-Reply-To: <20141205170156.GB14516@opensource.wolfsonmicro.com> X-Cookie: I don't get no respect. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [alsa-devel][PATCH v3] ASoC: wm8960: Let wm8960 codec driver manage its own MCLK X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --v541l457l4DThMFo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Dec 05, 2014 at 05:01:56PM +0000, Charles Keepax wrote: > On Thu, Dec 04, 2014 at 08:41:19PM +0800, Zidan Wang wrote: > > struct wm8960_data { > > + struct clk *mclk; > Is this really pdata? Would the pdata entry to locate the clock > not be a string holding the clock name that you call clk_get on, > rather than a clk pointer itself? Probably this should go in > wm8960_priv instead. There should be no platform data of any kind for the clock, the name should be fixed and defined in terms of the name of the clock on the device requesting it. The code is actually doing the right thing here, it's just that it's put the variable into the platform data because currently the driver just uses the platform data as the driver data. --v541l457l4DThMFo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJUge3TAAoJECTWi3JdVIfQOCwIAIMa/jqp6hOr38kRpbWnkrzm o0PJZFVQDEhVAy/+lJfnM31NWjw0tmvCzShOk9YEoYBOnGTiUYEnPtTN4b4HWoXC Am+FmsmEuTKpx9yEgerMGGn0XcgnRLl2RSgqD4FzaAKeUk2BgpJRmInHtjkAmZz7 xtouUumkV1IdqsRP5u11I8WMNfQqZ05+3dHuU5IyGpYcA6PXlkj/kXdUZl3+drl6 a107f3I5l/7AzuySQwcjX3E3MVc5ECN1t9tNGaH0mDTI/EujsspZZkpfmKrxA/tT tHDpCoHom6ZSTuYZSRoRd7NcHjrIS3h505/MgkjEsKWe+2vRl+UwH7E5e+NxhyY= =sBfT -----END PGP SIGNATURE----- --v541l457l4DThMFo--