LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] mm: memcontrol.c:  Cleaning up function that are not used anywhere
@ 2014-12-06 16:45 Rickard Strandqvist
  2014-12-07 10:31 ` Michal Hocko
  2014-12-08 16:02 ` Johannes Weiner
  0 siblings, 2 replies; 8+ messages in thread
From: Rickard Strandqvist @ 2014-12-06 16:45 UTC (permalink / raw)
  To: Johannes Weiner, Michal Hocko
  Cc: Rickard Strandqvist, cgroups, linux-mm, linux-kernel

Remove function mem_cgroup_lru_names_not_uptodate() that is not used anywhere.
And move BUILD_BUG_ON() to the beginning of memcg_stat_show() instead.

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
 mm/memcontrol.c |    7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index d6ac0e3..5e2f0f3 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -4379,17 +4379,14 @@ static int memcg_numa_stat_show(struct seq_file *m, void *v)
 }
 #endif /* CONFIG_NUMA */
 
-static inline void mem_cgroup_lru_names_not_uptodate(void)
-{
-	BUILD_BUG_ON(ARRAY_SIZE(mem_cgroup_lru_names) != NR_LRU_LISTS);
-}
-
 static int memcg_stat_show(struct seq_file *m, void *v)
 {
 	struct mem_cgroup *memcg = mem_cgroup_from_css(seq_css(m));
 	struct mem_cgroup *mi;
 	unsigned int i;
 
+	BUILD_BUG_ON(ARRAY_SIZE(mem_cgroup_lru_names) != NR_LRU_LISTS);
+
 	for (i = 0; i < MEM_CGROUP_STAT_NSTATS; i++) {
 		if (i == MEM_CGROUP_STAT_SWAP && !do_swap_account)
 			continue;
-- 
1.7.10.4


^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH] mm: memcontrol.c:  Cleaning up function that are not used anywhere
@ 2014-12-02 22:41 Rickard Strandqvist
  2014-12-03  9:22 ` Michal Hocko
  2014-12-03 15:22 ` Johannes Weiner
  0 siblings, 2 replies; 8+ messages in thread
From: Rickard Strandqvist @ 2014-12-02 22:41 UTC (permalink / raw)
  To: Johannes Weiner, Michal Hocko
  Cc: Rickard Strandqvist, cgroups, linux-mm, linux-kernel

Remove function mem_cgroup_lru_names_not_uptodate() that is not used anywhere.

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
 mm/memcontrol.c |    5 -----
 1 file changed, 5 deletions(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index d6ac0e3..5edd1fe 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -4379,11 +4379,6 @@ static int memcg_numa_stat_show(struct seq_file *m, void *v)
 }
 #endif /* CONFIG_NUMA */
 
-static inline void mem_cgroup_lru_names_not_uptodate(void)
-{
-	BUILD_BUG_ON(ARRAY_SIZE(mem_cgroup_lru_names) != NR_LRU_LISTS);
-}
-
 static int memcg_stat_show(struct seq_file *m, void *v)
 {
 	struct mem_cgroup *memcg = mem_cgroup_from_css(seq_css(m));
-- 
1.7.10.4


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2014-12-08 16:02 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-06 16:45 [PATCH] mm: memcontrol.c: Cleaning up function that are not used anywhere Rickard Strandqvist
2014-12-07 10:31 ` Michal Hocko
2014-12-08 16:02 ` Johannes Weiner
  -- strict thread matches above, loose matches on Subject: below --
2014-12-02 22:41 Rickard Strandqvist
2014-12-03  9:22 ` Michal Hocko
2014-12-03 15:22 ` Johannes Weiner
2014-12-03 15:54   ` Michal Hocko
2014-12-03 17:04     ` Rickard Strandqvist

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).