LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Lai Jiangshan <laijs@cn.fujitsu.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH wq/for-3.19 3/3] workqueue: dump workqueues on sysrq-t
Date: Mon, 8 Dec 2014 10:06:13 -0800	[thread overview]
Message-ID: <20141208100613.ecc66d89.akpm@linux-foundation.org> (raw)
In-Reply-To: <20141208174733.GD12274@htj.dyndns.org>

On Mon, 8 Dec 2014 12:47:33 -0500 Tejun Heo <tj@kernel.org> wrote:

>
> ...
>
> This patch implements show_workqueue_state() which dumps all busy
> workqueues and pools and is called from the sysrq-t handler.  At the
> end of sysrq-t dump, something like the following is printed.

Seems sensible.

sysrq-t already produces thousands of lines of output.  Maybe create a
new keycode for this?

>
> ...
>
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -4419,6 +4419,174 @@ void print_worker_info(const char *log_l
>  	}
>  }
>  
> +static void pr_cont_pool_info(struct worker_pool *pool)
> +{
> +	if (pool->cpu >= 0)
> +		pr_cont(" cpu=%d", pool->cpu);
> +	else if (pool->node != NUMA_NO_NODE)
> +		pr_cont(" node=%d", pool->node);
> +
> +	if (pool->cpu < 0) {
> +		static char cpus_buf[PAGE_SIZE];

Ouch.  This could be [NR_CPUS + epsilon]?

> +		cpumask_scnprintf(cpus_buf, sizeof(cpus_buf),
> +				  pool->attrs->cpumask);
> +		pr_cont(" cpumask=%s", cpus_buf);
> +	}
> +	pr_cont(" flags=0x%x nice=%d", pool->flags, pool->attrs->nice);
> +}
> +
> +static void pr_cont_work(bool comma, struct work_struct *work)
> +{
> +	if (work->func == wq_barrier_func) {
> +		struct wq_barrier *barr =
> +			container_of(work, struct wq_barrier, work);

Can avoid the 80-col contortions with

		struct wq_barrier *barr;

		barr = container_of(work, struct wq_barrier, work);

> +		pr_cont("%s BAR(%d)", comma ? "," : "",
> +			task_pid_nr(barr->task));
> +	} else {
> +		pr_cont("%s %pf", comma ? "," : "", work->func);
> +	}
> +}
> +
> +static void show_pwq(struct pool_workqueue *pwq)
> +{
> +	struct worker_pool *pool = pwq->pool;
> +	struct work_struct *work;
> +	struct worker *worker;
> +	bool has_in_flight = false, has_pending = false;
> +	int bkt;
> +
> +	printk("  pwq %d:", pool->id);
> +	pr_cont_pool_info(pool);
> +
> +	pr_cont(" active=%d/%d%s\n", pwq->nr_active, pwq->max_active,
> +		!list_empty(&pwq->mayday_node) ? " MAYDAY" : "");
> +
> +	hash_for_each(pool->busy_hash, bkt, worker, hentry) {
> +		if (worker->current_pwq == pwq) {
> +			has_in_flight = true;
> +			break;
> +		}
> +	}
> +	if (has_in_flight) {
> +		bool comma = false;
> +
> +		printk("    in-flight:");

pr_something?  show_state() uses KERN_INFO, which may or may not be
appropriate.

> +		hash_for_each(pool->busy_hash, bkt, worker, hentry) {
> +			if (worker->current_pwq != pwq)
> +				continue;
> +
> +			pr_cont("%s %d%s:%pf", comma ? "," : "",
> +				task_pid_nr(worker->task),
> +				worker == pwq->wq->rescuer ? "(RESCUER)" : "",
> +				worker->current_func);
> +			list_for_each_entry(work, &worker->scheduled, entry)
> +				pr_cont_work(false, work);
> +			comma = true;
> +		}
> +		pr_cont("\n");
> +	}
> +
> +	list_for_each_entry(work, &pool->worklist, entry) {
> +		if (get_work_pwq(work) == pwq) {
> +			has_pending = true;
> +			break;
> +		}
> +	}
> +	if (has_pending) {
> +		bool comma = false;
> +
> +		printk("    pending:");

ditto

> +		list_for_each_entry(work, &pool->worklist, entry) {
> +			if (get_work_pwq(work) != pwq)
> +				continue;
> +
> +			pr_cont_work(comma, work);
> +			comma = !(*work_data_bits(work) & WORK_STRUCT_LINKED);
> +		}
> +		pr_cont("\n");
> +	}
> +
> +	if (!list_empty(&pwq->delayed_works)) {
> +		bool comma = false;
> +
> +		printk("    delayed:");

ditto

> +		list_for_each_entry(work, &pwq->delayed_works, entry) {
> +			pr_cont_work(comma, work);
> +			comma = !(*work_data_bits(work) & WORK_STRUCT_LINKED);
> +		}
> +		pr_cont("\n");
> +	}
> +}
> +
>
> ...

  reply	other threads:[~2014-12-08 18:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-08 17:43 [PATCH wq/for-3.19 1/3] workqueue: make the workqueues list RCU walkable Tejun Heo
2014-12-08 17:44 ` [PATCH wq/for-3.19 2/3] workqueue: keep track of the flushing task and pool manager Tejun Heo
2014-12-08 17:47   ` [PATCH wq/for-3.19 3/3] workqueue: dump workqueues on sysrq-t Tejun Heo
2014-12-08 18:06     ` Andrew Morton [this message]
2014-12-08 18:40       ` Tejun Heo
2014-12-08 19:05         ` Andrew Morton
2014-12-08 19:22           ` Tejun Heo
2014-12-10  4:50             ` Greg Kroah-Hartman
2014-12-10 18:34               ` Tejun Heo
2015-03-09 13:28     ` [PATCH v3 " Tejun Heo
2015-03-10 12:58       ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141208100613.ecc66d89.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [PATCH wq/for-3.19 3/3] workqueue: dump workqueues on sysrq-t' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).