On Mon, Dec 08, 2014 at 09:49:51AM +0000, Zidan Wang wrote: > So I should move mclk to wm8960_priv. > And doing wm8960_priv->mclk = devm_clk_get(&i2c->dev, "codec_mclk") in wm8960_i2c_probe. Yes, please.