From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755256AbaLHL5U (ORCPT ); Mon, 8 Dec 2014 06:57:20 -0500 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:53894 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753337AbaLHL5T (ORCPT ); Mon, 8 Dec 2014 06:57:19 -0500 Date: Mon, 8 Dec 2014 11:57:17 +0000 From: Charles Keepax To: Mark Brown Cc: Zidan Wang , "lgirdwood@gmail.com" , "perex@perex.cz" , "tiwai@suse.de" , "lars@metafoo.de" , "Li.Xiubo@freescale.com" , "patches@opensource.wolfsonmicro.com" , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" Subject: Re: [alsa-devel][PATCH v3] ASoC: wm8960: Let wm8960 codec driver manage its own MCLK Message-ID: <20141208115717.GF14516@opensource.wolfsonmicro.com> References: <1417696879-15402-1-git-send-email-b50113@freescale.com> <20141205170156.GB14516@opensource.wolfsonmicro.com> <20141205173932.GN11764@sirena.org.uk> <20141208111445.GT11764@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141208111445.GT11764@sirena.org.uk> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 08, 2014 at 11:14:45AM +0000, Mark Brown wrote: > On Mon, Dec 08, 2014 at 09:49:51AM +0000, Zidan Wang wrote: > > So I should move mclk to wm8960_priv. > > And doing wm8960_priv->mclk = devm_clk_get(&i2c->dev, "codec_mclk") in wm8960_i2c_probe. > > Yes, please. Apologies I totally misread you last email. Thanks, Charles