LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
	Lai Jiangshan <laijs@cn.fujitsu.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH wq/for-3.19 3/3] workqueue: dump workqueues on sysrq-t
Date: Mon, 8 Dec 2014 13:40:35 -0500	[thread overview]
Message-ID: <20141208184035.GE12274@htj.dyndns.org> (raw)
In-Reply-To: <20141208100613.ecc66d89.akpm@linux-foundation.org>

Hello, Andrew.

On Mon, Dec 08, 2014 at 10:06:13AM -0800, Andrew Morton wrote:
> sysrq-t already produces thousands of lines of output.  Maybe create a
> new keycode for this?

Believe it or not, we already used up all alphanumerics if we count in
the arch-specific ones.  Given that the workqueue information would
primarily be useful in tracking down hangs and we'd want to see the
dump of tasks in that case anyway, sysrq-t isn't a bad fit for
appending workqueue dump.  If anybody has a better idea, I'm all ears.

...
> > +static void pr_cont_pool_info(struct worker_pool *pool)
> > +{
> > +	if (pool->cpu >= 0)
> > +		pr_cont(" cpu=%d", pool->cpu);
> > +	else if (pool->node != NUMA_NO_NODE)
> > +		pr_cont(" node=%d", pool->node);
> > +
> > +	if (pool->cpu < 0) {
> > +		static char cpus_buf[PAGE_SIZE];
> 
> Ouch.  This could be [NR_CPUS + epsilon]?

It's bitmap mask printing so each char can show four cpus.  PAGE_SIZE
should be enough for now but I think we need cpumask_prcont().

> > +static void pr_cont_work(bool comma, struct work_struct *work)
> > +{
> > +	if (work->func == wq_barrier_func) {
> > +		struct wq_barrier *barr =
> > +			container_of(work, struct wq_barrier, work);
> 
> Can avoid the 80-col contortions with
> 
> 		struct wq_barrier *barr;
> 
> 		barr = container_of(work, struct wq_barrier, work);

I'm not sure either is any better, but sure.

> > +	if (has_in_flight) {
> > +		bool comma = false;
> > +
> > +		printk("    in-flight:");
> 
> pr_something?  show_state() uses KERN_INFO, which may or may not be
> appropriate.

Hmmm, best to match show_state().  I'll convert to pr_info().

Thanks.

-- 
tejun

  reply	other threads:[~2014-12-08 18:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-08 17:43 [PATCH wq/for-3.19 1/3] workqueue: make the workqueues list RCU walkable Tejun Heo
2014-12-08 17:44 ` [PATCH wq/for-3.19 2/3] workqueue: keep track of the flushing task and pool manager Tejun Heo
2014-12-08 17:47   ` [PATCH wq/for-3.19 3/3] workqueue: dump workqueues on sysrq-t Tejun Heo
2014-12-08 18:06     ` Andrew Morton
2014-12-08 18:40       ` Tejun Heo [this message]
2014-12-08 19:05         ` Andrew Morton
2014-12-08 19:22           ` Tejun Heo
2014-12-10  4:50             ` Greg Kroah-Hartman
2014-12-10 18:34               ` Tejun Heo
2015-03-09 13:28     ` [PATCH v3 " Tejun Heo
2015-03-10 12:58       ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141208184035.GE12274@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [PATCH wq/for-3.19 3/3] workqueue: dump workqueues on sysrq-t' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).