LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, dahi@linux.vnet.ibm.com,
rusty@rustcorp.com.au,
Christian Borntraeger <borntraeger@de.ibm.com>,
linux390@de.ibm.com, Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-s390@vger.kernel.org
Subject: Re: [PATCH v3 2/6] virtio_ccw: legacy: don't negotiate rev 1/features
Date: Tue, 9 Dec 2014 11:35:29 +0100 [thread overview]
Message-ID: <20141209113529.675e8df3.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <1418042769-25539-3-git-send-email-mst@redhat.com>
On Mon, 8 Dec 2014 15:05:54 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> Legacy balloon device doesn't pretend to support revision 1 or 64 bit
> features.
>
> But just in case someone implements a broken one that does, let's not
> even try to drive legacy only devices using revision 1, and let's not
> give them a chance to say they support VIRTIO_F_VERSION_1 by not reading
s/reading/reading or writing/
> high feature bits.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/s390/kvm/virtio_ccw.c | 16 +++++++++++++---
> 1 file changed, 13 insertions(+), 3 deletions(-)
Otherwise, looks good.
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
next prev parent reply other threads:[~2014-12-09 10:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 13:05 [PATCH v3 0/6] virtio 1.0 enhancements Michael S. Tsirkin
2014-12-08 13:05 ` [PATCH v3 1/6] virtio: add API to detect legacy devices Michael S. Tsirkin
2014-12-08 13:05 ` [PATCH v3 2/6] virtio_ccw: legacy: don't negotiate rev 1/features Michael S. Tsirkin
2014-12-09 10:35 ` Cornelia Huck [this message]
2014-12-08 13:05 ` [PATCH v3 3/6] virtio: allow finalize_features to fail Michael S. Tsirkin
2014-12-09 10:46 ` Cornelia Huck
2014-12-09 12:07 ` Michael S. Tsirkin
2014-12-09 12:56 ` Cornelia Huck
2014-12-08 13:06 ` [PATCH v3 4/6] virtio_ccw: rev 1 devices set VIRTIO_F_VERSION_1 Michael S. Tsirkin
2014-12-09 11:01 ` Cornelia Huck
2014-12-09 12:21 ` Michael S. Tsirkin
2014-12-09 17:23 ` Cornelia Huck
2014-12-09 18:55 ` Michael S. Tsirkin
2014-12-09 19:40 ` Michael S. Tsirkin
2014-12-10 8:41 ` Cornelia Huck
2014-12-08 13:06 ` [PATCH v3 5/6] virtio_balloon: drop legacy_only driver flag Michael S. Tsirkin
2014-12-09 11:24 ` Cornelia Huck
2014-12-08 13:06 ` [PATCH v3 6/6] virtio: " Michael S. Tsirkin
2014-12-09 11:24 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141209113529.675e8df3.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=dahi@linux.vnet.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=mst@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=schwidefsky@de.ibm.com \
--subject='Re: [PATCH v3 2/6] virtio_ccw: legacy: don'\''t negotiate rev 1/features' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).