LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: linux-efi <linux-efi@vger.kernel.org>,
Laszlo Ersek <lersek@redhat.com>,
Matt Fleming <matt.fleming@intel.com>,
Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: Shorten efi regions output
Date: Tue, 9 Dec 2014 13:48:46 +0100 [thread overview]
Message-ID: <20141209124845.GB3990@pd.tnic> (raw)
In-Reply-To: <CAKv+Gu_F+o6NKb5JJ8ZQ7AJbjvASeQF1YcuUXv8seOMa5oaxgg@mail.gmail.com>
On Tue, Dec 09, 2014 at 01:42:44PM +0100, Ard Biesheuvel wrote:
> The |] thing is easily fixed, though.
>
> [...]
> > diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
> > index 8590099ac148..6734072980ee 100644
> > --- a/drivers/firmware/efi/efi.c
> > +++ b/drivers/firmware/efi/efi.c
> [...]
> > @@ -490,15 +490,15 @@ char * __init efi_md_typeattr_format(char *buf, size_t size,
> > snprintf(pos, size, "|attr=0x%016llx]",
> > (unsigned long long)attr);
> > else
> > - snprintf(pos, size, "|%3s|%2s|%2s|%2s|%3s|%2s|%2s|%2s|%2s]",
> > - attr & EFI_MEMORY_RUNTIME ? "RUN" : "",
> > - attr & EFI_MEMORY_XP ? "XP" : "",
> > - attr & EFI_MEMORY_RP ? "RP" : "",
> > - attr & EFI_MEMORY_WP ? "WP" : "",
> > - attr & EFI_MEMORY_UCE ? "UCE" : "",
> > - attr & EFI_MEMORY_WB ? "WB" : "",
> > - attr & EFI_MEMORY_WT ? "WT" : "",
> > - attr & EFI_MEMORY_WC ? "WC" : "",
> > - attr & EFI_MEMORY_UC ? "UC" : "");
> > + snprintf(pos, size, "|%s%s%s%s%s%s%s%s%s]",
>
> Drop the leading | here
>
> > + attr & EFI_MEMORY_RUNTIME ? "RT|" : "",
> > + attr & EFI_MEMORY_XP ? "XP|" : "",
> > + attr & EFI_MEMORY_RP ? "RP|" : "",
> > + attr & EFI_MEMORY_WP ? "WP|" : "",
> > + attr & EFI_MEMORY_UCE ? "UCE|" : "",
> > + attr & EFI_MEMORY_WB ? "WB|" : "",
> > + attr & EFI_MEMORY_WT ? "WT|" : "",
> > + attr & EFI_MEMORY_WC ? "WC|" : "",
> > + attr & EFI_MEMORY_UC ? "UC" : "");
>
> and move all the | to the beginning of the string here, including "UC"
Haha, of course! :-)
/me slaps forehead.
Thanks!
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2014-12-09 12:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 9:58 Borislav Petkov
2014-12-09 12:42 ` Ard Biesheuvel
2014-12-09 12:48 ` Borislav Petkov [this message]
2014-12-09 15:35 ` Laszlo Ersek
2014-12-09 16:45 ` Borislav Petkov
2014-12-10 2:17 ` Dave Young
2014-12-10 10:46 ` Borislav Petkov
2015-01-05 14:03 ` Matt Fleming
2015-01-05 15:00 ` Laszlo Ersek
2015-01-21 5:48 ` Jon Masters
2015-01-21 10:06 ` Borislav Petkov
2015-01-26 10:49 ` Matt Fleming
2015-01-30 16:43 ` [PATCH] efi, x86: Add a "debug" option to the efi= cmdline Borislav Petkov
2015-01-30 16:58 ` Laszlo Ersek
2015-01-30 18:06 ` Randy Dunlap
2015-01-30 21:17 ` Borislav Petkov
2015-02-04 12:18 ` Parmeshwr Prasad
2015-02-05 3:18 ` Dave Young
2015-02-05 8:11 ` Borislav Petkov
2015-02-05 8:41 ` Dave Young
2015-02-05 10:44 ` [PATCH v2] " Borislav Petkov
2015-02-05 12:45 ` Parmeshwr Prasad
2015-02-05 14:28 ` Borislav Petkov
2015-02-06 6:00 ` Parmeshwr Prasad
2015-02-06 10:49 ` Borislav Petkov
2015-02-24 22:33 ` Matt Fleming
2015-04-02 12:27 ` [tip:core/efi] x86/efi: " tip-bot for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141209124845.GB3990@pd.tnic \
--to=bp@alien8.de \
--cc=ard.biesheuvel@linaro.org \
--cc=lersek@redhat.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=ricardo.neri-calderon@linux.intel.com \
--subject='Re: Shorten efi regions output' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).