LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-kernel@vger.kernel.org, rusty@rustcorp.com.au,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 8/9] virtio_pci: split out legacy device support
Date: Wed, 17 Dec 2014 00:55:26 +0200	[thread overview]
Message-ID: <20141216225526.GA19694@redhat.com> (raw)
In-Reply-To: <20141216210309.GA32071@gondor.apana.org.au>

On Wed, Dec 17, 2014 at 08:03:10AM +1100, Herbert Xu wrote:
> Michael S. Tsirkin <mst@redhat.com> wrote:
> > Move everything dealing with legacy devices out to virtio_pci_legacy.c.
> > Expose common code APIs in virtio_pci.h
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> 
> This breaks virtio_pci because you deleted the licence from it.
> 
> -- >8 --
> Subject: virtio_pci: Restore module licence and other attributes
> 
> When the virtio_pci driver was moved into virtio_pci_legacy.c the
> module licence and other attributes went AWOL.  This patch restores
> them.
> 
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Thanks!
I'll apply a similar patch but to virtio_pci_common.
Will send a pull request with this included tomorrow.

> diff --git a/drivers/virtio/virtio_pci_legacy.c b/drivers/virtio/virtio_pci_legacy.c
> index 2588252..6b100e3 100644
> --- a/drivers/virtio/virtio_pci_legacy.c
> +++ b/drivers/virtio/virtio_pci_legacy.c
> @@ -324,3 +324,8 @@ static struct pci_driver virtio_pci_driver = {
>  };
>  
>  module_pci_driver(virtio_pci_driver);
> +
> +MODULE_AUTHOR("Anthony Liguori <aliguori@us.ibm.com>");
> +MODULE_DESCRIPTION("virtio-pci");
> +MODULE_LICENSE("GPL");
> +MODULE_VERSION("1");
> 
> Cheers,
> -- 
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2014-12-16 22:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-08 13:06 [PATCH 0/9] " Michael S. Tsirkin
2014-12-08 13:06 ` [PATCH 1/9] virtio_pci: add isr field Michael S. Tsirkin
2014-12-08 13:06 ` [PATCH 2/9] virtio_pci: fix coding style for structs Michael S. Tsirkin
2014-12-08 13:06 ` [PATCH 3/9] virtio_pci: free up vq->priv Michael S. Tsirkin
2014-12-08 13:06 ` [PATCH 4/9] virtio_pci: use priv for vq notification Michael S. Tsirkin
2014-12-08 13:06 ` [PATCH 5/9] virtio_pci: delete vqs indirectly Michael S. Tsirkin
2014-12-08 13:06 ` [PATCH 6/9] virtio_pci: setup " Michael S. Tsirkin
2014-12-08 13:06 ` [PATCH 7/9] virtio_pci: setup config vector indirectly Michael S. Tsirkin
2014-12-08 13:06 ` [PATCH 8/9] virtio_pci: split out legacy device support Michael S. Tsirkin
2014-12-16 21:03   ` Herbert Xu
2014-12-16 22:55     ` Michael S. Tsirkin [this message]
2014-12-16 23:18     ` Michael S. Tsirkin
2014-12-08 13:06 ` [PATCH 9/9] virtio_pci: update file descriptions and copyright Michael S. Tsirkin
2014-12-15  4:12   ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141216225526.GA19694@redhat.com \
    --to=mst@redhat.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    --subject='Re: [PATCH 8/9] virtio_pci: split out legacy device support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).