LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2] gru: cleanup on stack DECLARE_COMPLETION
@ 2014-12-29 18:31 Nicholas Mc Guire
2014-12-29 18:38 ` Dimitri Sivanich
0 siblings, 1 reply; 2+ messages in thread
From: Nicholas Mc Guire @ 2014-12-29 18:31 UTC (permalink / raw)
To: Dimitri Sivanich; +Cc: linux-kernel, Nicholas Mc Guire
fix-up for incorrect use of DECLARE_COMPLETION. see also commit
6e9a4738 ("completions: lockdep annotate on stack completions")
V2: split out patch for individual files and (hopefully) proper
labeling this time
patch is against linux-next 3.19.0-rc1 -next-20141226
patch was compile tested with defconfig_x86_64 + CONFIG_IRQ_REMAP=y
CONFIG_X86_X2APIC=y, CONFIG_X86_UV=y, CONFIG_SGI_GRU=y
Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
---
drivers/misc/sgi-gru/grukservices.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/sgi-gru/grukservices.c b/drivers/misc/sgi-gru/grukservices.c
index 913de07..abf2b73 100644
--- a/drivers/misc/sgi-gru/grukservices.c
+++ b/drivers/misc/sgi-gru/grukservices.c
@@ -1044,7 +1044,7 @@ done:
static int quicktest2(unsigned long arg)
{
- static DECLARE_COMPLETION(cmp);
+ static DECLARE_COMPLETION_ONSTACK(cmp);
unsigned long han;
int blade_id = 0;
int numcb = 4;
--
1.7.10.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] gru: cleanup on stack DECLARE_COMPLETION
2014-12-29 18:31 [PATCH v2] gru: cleanup on stack DECLARE_COMPLETION Nicholas Mc Guire
@ 2014-12-29 18:38 ` Dimitri Sivanich
0 siblings, 0 replies; 2+ messages in thread
From: Dimitri Sivanich @ 2014-12-29 18:38 UTC (permalink / raw)
To: Nicholas Mc Guire; +Cc: linux-kernel
Acked-by: Dimitri Sivanich <sivanich@sgi.com>
On Mon, Dec 29, 2014 at 01:31:16PM -0500, Nicholas Mc Guire wrote:
> fix-up for incorrect use of DECLARE_COMPLETION. see also commit
> 6e9a4738 ("completions: lockdep annotate on stack completions")
>
> V2: split out patch for individual files and (hopefully) proper
> labeling this time
>
> patch is against linux-next 3.19.0-rc1 -next-20141226
>
> patch was compile tested with defconfig_x86_64 + CONFIG_IRQ_REMAP=y
> CONFIG_X86_X2APIC=y, CONFIG_X86_UV=y, CONFIG_SGI_GRU=y
>
> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
> ---
> drivers/misc/sgi-gru/grukservices.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/sgi-gru/grukservices.c b/drivers/misc/sgi-gru/grukservices.c
> index 913de07..abf2b73 100644
> --- a/drivers/misc/sgi-gru/grukservices.c
> +++ b/drivers/misc/sgi-gru/grukservices.c
> @@ -1044,7 +1044,7 @@ done:
>
> static int quicktest2(unsigned long arg)
> {
> - static DECLARE_COMPLETION(cmp);
> + static DECLARE_COMPLETION_ONSTACK(cmp);
> unsigned long han;
> int blade_id = 0;
> int numcb = 4;
> --
> 1.7.10.4
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-29 18:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-29 18:31 [PATCH v2] gru: cleanup on stack DECLARE_COMPLETION Nicholas Mc Guire
2014-12-29 18:38 ` Dimitri Sivanich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).