LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] arm64: add ioremap physical address information
@ 2014-12-26 16:52 Min-Hua Chen
  2015-01-06 14:17 ` Will Deacon
  2015-01-23 15:29 ` Catalin Marinas
  0 siblings, 2 replies; 4+ messages in thread
From: Min-Hua Chen @ 2014-12-26 16:52 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon; +Cc: linux-arm-kernel, linux-kernel

In /proc/vmallocinfo, it's good to show the physical address
of each ioremap in vmallocinfo. Add physical address information
in arm64 ioremap.

0xffffc900047f2000-0xffffc900047f4000    8192 _nv013519rm+0x57/0xa0
[nvidia] phys=f8100000 ioremap
0xffffc900047f4000-0xffffc900047f6000    8192 _nv013519rm+0x57/0xa0
[nvidia] phys=f8008000 ioremap
0xffffc90004800000-0xffffc90004821000  135168 e1000_probe+0x22c/0xb95
[e1000e] phys=f4300000 ioremap
0xffffc900049c0000-0xffffc900049e1000  135168 _nv013521rm+0x4d/0xd0
[nvidia] phys=e0140000 ioremap

Signed-off-by: Min-Hua Chen <orca.chen@gmail.com>
---
 arch/arm64/mm/ioremap.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/mm/ioremap.c b/arch/arm64/mm/ioremap.c
index cbb99c8..01e88c8 100644
--- a/arch/arm64/mm/ioremap.c
+++ b/arch/arm64/mm/ioremap.c
@@ -62,6 +62,7 @@ static void __iomem *__ioremap_caller(phys_addr_t
phys_addr, size_t size,
     if (!area)
         return NULL;
     addr = (unsigned long)area->addr;
+    area->phys_addr = phys_addr;

     err = ioremap_page_range(addr, addr + size, phys_addr, prot);
     if (err) {
--
1.7.10.4

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: add ioremap physical address information
  2014-12-26 16:52 [PATCH] arm64: add ioremap physical address information Min-Hua Chen
@ 2015-01-06 14:17 ` Will Deacon
  2015-01-06 14:58   ` Min-Hua Chen
  2015-01-23 15:29 ` Catalin Marinas
  1 sibling, 1 reply; 4+ messages in thread
From: Will Deacon @ 2015-01-06 14:17 UTC (permalink / raw)
  To: Min-Hua Chen; +Cc: Catalin Marinas, linux-arm-kernel, linux-kernel

On Fri, Dec 26, 2014 at 04:52:10PM +0000, Min-Hua Chen wrote:
> In /proc/vmallocinfo, it's good to show the physical address
> of each ioremap in vmallocinfo. Add physical address information
> in arm64 ioremap.
> 
> 0xffffc900047f2000-0xffffc900047f4000    8192 _nv013519rm+0x57/0xa0
> [nvidia] phys=f8100000 ioremap
> 0xffffc900047f4000-0xffffc900047f6000    8192 _nv013519rm+0x57/0xa0
> [nvidia] phys=f8008000 ioremap
> 0xffffc90004800000-0xffffc90004821000  135168 e1000_probe+0x22c/0xb95
> [e1000e] phys=f4300000 ioremap
> 0xffffc900049c0000-0xffffc900049e1000  135168 _nv013521rm+0x4d/0xd0
> [nvidia] phys=e0140000 ioremap
> 
> Signed-off-by: Min-Hua Chen <orca.chen@gmail.com>
> ---

Thanks, this looks useful for debugging.

  Acked-by: Will Deacon <will.deacon@arm.com>

I assume this can wait for 3.20?

Will


>  arch/arm64/mm/ioremap.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/mm/ioremap.c b/arch/arm64/mm/ioremap.c
> index cbb99c8..01e88c8 100644
> --- a/arch/arm64/mm/ioremap.c
> +++ b/arch/arm64/mm/ioremap.c
> @@ -62,6 +62,7 @@ static void __iomem *__ioremap_caller(phys_addr_t
> phys_addr, size_t size,
>      if (!area)
>          return NULL;
>      addr = (unsigned long)area->addr;
> +    area->phys_addr = phys_addr;
> 
>      err = ioremap_page_range(addr, addr + size, phys_addr, prot);
>      if (err) {
> --
> 1.7.10.4
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: add ioremap physical address information
  2015-01-06 14:17 ` Will Deacon
@ 2015-01-06 14:58   ` Min-Hua Chen
  0 siblings, 0 replies; 4+ messages in thread
From: Min-Hua Chen @ 2015-01-06 14:58 UTC (permalink / raw)
  To: Will Deacon; +Cc: Catalin Marinas, linux-arm-kernel, linux-kernel

On Tue, Jan 6, 2015 at 10:17 PM, Will Deacon <will.deacon@arm.com> wrote:
> On Fri, Dec 26, 2014 at 04:52:10PM +0000, Min-Hua Chen wrote:
>> In /proc/vmallocinfo, it's good to show the physical address
>> of each ioremap in vmallocinfo. Add physical address information
>> in arm64 ioremap.
>>
>> 0xffffc900047f2000-0xffffc900047f4000    8192 _nv013519rm+0x57/0xa0
>> [nvidia] phys=f8100000 ioremap
>> 0xffffc900047f4000-0xffffc900047f6000    8192 _nv013519rm+0x57/0xa0
>> [nvidia] phys=f8008000 ioremap
>> 0xffffc90004800000-0xffffc90004821000  135168 e1000_probe+0x22c/0xb95
>> [e1000e] phys=f4300000 ioremap
>> 0xffffc900049c0000-0xffffc900049e1000  135168 _nv013521rm+0x4d/0xd0
>> [nvidia] phys=e0140000 ioremap
>>
>> Signed-off-by: Min-Hua Chen <orca.chen@gmail.com>
>> ---
>
> Thanks, this looks useful for debugging.
>
>   Acked-by: Will Deacon <will.deacon@arm.com>
>
> I assume this can wait for 3.20?

Sure, thanks.

Min-Hua

>
> Will
>
>
>>  arch/arm64/mm/ioremap.c |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/mm/ioremap.c b/arch/arm64/mm/ioremap.c
>> index cbb99c8..01e88c8 100644
>> --- a/arch/arm64/mm/ioremap.c
>> +++ b/arch/arm64/mm/ioremap.c
>> @@ -62,6 +62,7 @@ static void __iomem *__ioremap_caller(phys_addr_t
>> phys_addr, size_t size,
>>      if (!area)
>>          return NULL;
>>      addr = (unsigned long)area->addr;
>> +    area->phys_addr = phys_addr;
>>
>>      err = ioremap_page_range(addr, addr + size, phys_addr, prot);
>>      if (err) {
>> --
>> 1.7.10.4
>>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: add ioremap physical address information
  2014-12-26 16:52 [PATCH] arm64: add ioremap physical address information Min-Hua Chen
  2015-01-06 14:17 ` Will Deacon
@ 2015-01-23 15:29 ` Catalin Marinas
  1 sibling, 0 replies; 4+ messages in thread
From: Catalin Marinas @ 2015-01-23 15:29 UTC (permalink / raw)
  To: Min-Hua Chen; +Cc: Will Deacon, linux-arm-kernel, linux-kernel

On Fri, Dec 26, 2014 at 04:52:10PM +0000, Min-Hua Chen wrote:
> In /proc/vmallocinfo, it's good to show the physical address
> of each ioremap in vmallocinfo. Add physical address information
> in arm64 ioremap.
> 
> 0xffffc900047f2000-0xffffc900047f4000    8192 _nv013519rm+0x57/0xa0
> [nvidia] phys=f8100000 ioremap
> 0xffffc900047f4000-0xffffc900047f6000    8192 _nv013519rm+0x57/0xa0
> [nvidia] phys=f8008000 ioremap
> 0xffffc90004800000-0xffffc90004821000  135168 e1000_probe+0x22c/0xb95
> [e1000e] phys=f4300000 ioremap
> 0xffffc900049c0000-0xffffc900049e1000  135168 _nv013521rm+0x4d/0xd0
> [nvidia] phys=e0140000 ioremap
> 
> Signed-off-by: Min-Hua Chen <orca.chen@gmail.com>

Applied. Thanks.

-- 
Catalin

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-01-23 15:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-26 16:52 [PATCH] arm64: add ioremap physical address information Min-Hua Chen
2015-01-06 14:17 ` Will Deacon
2015-01-06 14:58   ` Min-Hua Chen
2015-01-23 15:29 ` Catalin Marinas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).