LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jeremiah Mahler <jmmahler@gmail.com>
To: Julian Brost <linux-kernel@0x4a42.net>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	corbet@lwn.net, tomas.winkler@intel.com,
	linux-mei@linux.intel.com, linux-kernel@i4.cs.fau.de,
	fabian.hofmann@fau.de
Subject: Re: [PATCH 4/4] Documentation/misc-devices/mei: Fix indentation of embedded code.
Date: Sun, 11 Jan 2015 20:56:38 -0800	[thread overview]
Message-ID: <20150112045638.GA19607@hudson.localdomain> (raw)
In-Reply-To: <1421020689-28332-5-git-send-email-linux-kernel@0x4a42.net>

Julian,

On Mon, Jan 12, 2015 at 12:58:09AM +0100, Julian Brost wrote:
[...]
>  static struct mei_cl_driver contact_driver = {
> -       .id_table = contact_mei_tbl,
> -       .name = CONTACT_DRIVER_NAME,
> +	.id_table = contact_mei_tbl,
> +	.name = CONTACT_DRIVER_NAME,
>  
> -       .probe = contact_probe,
> -       .remove = contact_remove,
> +	.probe = contact_probe,
> +	.remove = contact_remove,
>  };
>  

Looking at this file the majority of the code is formatted at the left
with tabs.  So I think your change is in agreement with the current
design.

[...]

Reviewed-by: Jeremiah Mahler <jmmahler@gmail.com>

-- 
- Jeremiah Mahler

  reply	other threads:[~2015-01-12  4:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-11 23:58 [PATCH 0/4] Documentation/misc-devices/mei: Fix formatting Julian Brost
2015-01-11 23:58 ` [PATCH 1/4] Documentation/misc-devices/mei: Fix formatting of headings Julian Brost
2015-01-28 19:17   ` Jonathan Corbet
2015-01-29  1:39     ` [i4passt] " Alexander Wuerstlein
2015-01-29 19:57       ` Jonathan Corbet
2015-01-11 23:58 ` [PATCH 2/4] Documentation/misc-devices/mei: Fix spacing around parentheses Julian Brost
2015-01-11 23:58 ` [PATCH 3/4] Documentation/misc-devices/mei: Fix indentation of enumeration Julian Brost
2015-01-11 23:58 ` [PATCH 4/4] Documentation/misc-devices/mei: Fix indentation of embedded code Julian Brost
2015-01-12  4:56   ` Jeremiah Mahler [this message]
2015-01-12  4:57 ` [PATCH 0/4] Documentation/misc-devices/mei: Fix formatting Jeremiah Mahler
2015-01-12  8:55   ` Winkler, Tomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150112045638.GA19607@hudson.localdomain \
    --to=jmmahler@gmail.com \
    --cc=corbet@lwn.net \
    --cc=fabian.hofmann@fau.de \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@0x4a42.net \
    --cc=linux-kernel@i4.cs.fau.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mei@linux.intel.com \
    --cc=tomas.winkler@intel.com \
    --subject='Re: [PATCH 4/4] Documentation/misc-devices/mei: Fix indentation of embedded code.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).