From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751530AbbALLUk (ORCPT ); Mon, 12 Jan 2015 06:20:40 -0500 Received: from mail-we0-f172.google.com ([74.125.82.172]:37642 "EHLO mail-we0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751361AbbALLUi (ORCPT ); Mon, 12 Jan 2015 06:20:38 -0500 Date: Mon, 12 Jan 2015 06:20:33 -0500 From: "Ahmed S. Darwish" To: Olivier Sobrie , Oliver Hartkopp , Wolfgang Grandegger , Marc Kleine-Budde Cc: "David S. Miller" , Paul Gortmaker , Linux-CAN , netdev , LKML Subject: Re: [PATCH v4 3/4] can: kvaser_usb: Add support for the Usbcan-II family Message-ID: <20150112112033.GB9213@linux> References: <20141223154654.GB6460@vivalin-002> <20150111200544.GA8855@linux> <20150111201116.GB8855@linux> <20150111201519.GC8855@linux> <20150111203612.GA8999@linux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150111203612.GA8999@linux> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org List-Archive: Hi Marc, On Sun, Jan 11, 2015 at 03:36:12PM -0500, Ahmed S. Darwish wrote: > From: Ahmed S. Darwish > > CAN to USB interfaces sold by the Swedish manufacturer Kvaser are > divided into two major families: 'Leaf', and 'UsbcanII'. From an > Operating System perspective, the firmware of both families behave > in a not too drastically different fashion. > > This patch adds support for the UsbcanII family of devices to the > current Kvaser Leaf-only driver. > > CAN frames sending, receiving, and error handling paths has been > tested using the dual-channel "Kvaser USBcan II HS/LS" dongle. It > should also work nicely with other products in the same category. > Please delay applying this to as I've just discovered that removal of two of the device family checks introduced two un-necessary GCC warnings. Will send and updated version soon. Thanks, Darwish