From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753164AbbANJdS (ORCPT ); Wed, 14 Jan 2015 04:33:18 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:43781 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752501AbbANJdJ (ORCPT ); Wed, 14 Jan 2015 04:33:09 -0500 Date: Wed, 14 Jan 2015 01:33:02 -0800 From: Christoph Hellwig To: Alan Stern Cc: Christoph Hellwig , Bart Van Assche , James Bottomley , Hannes Reinecke , "linux-scsi@vger.kernel.org" , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH for v3.19, v2] Avoid that sd_shutdown() triggers a kernel warning Message-ID: <20150114093302.GA17532@infradead.org> References: <20150108131508.GA31022@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 12, 2015 at 11:29:15AM -0500, Alan Stern wrote: > This seems like a good idea and the obvious (once it has been pointed > out!) approach. > > Perhaps not directly related to the issue at hand is this question: In > scsi_rescan_device() we will now have: > > mutex_lock(&shost->scan_mutex); > if (dev->driver && try_module_get(dev->driver->owner)) { > struct scsi_driver *drv = to_scsi_driver(dev->driver); > > if (drv->rescan) > drv->rescan(dev); > module_put(dev->driver->owner); > } > mutex_unlock(&shost->scan_mutex); > > What prevents the device from being unbound from its driver while the > rescan runs? Evaluating the argument to the module_put() would then > dereference a NULL pointer. > > Unbind events that happen through the normal scsi_remove_host() > mechanism are fine, because scsi_remove_host() locks the scan_mutex. > But what about writes to the driver's sysfs "unbind" attribute? Looks like we should still get an unconditional reference to the device using get_device in scsi_rescan_device at least. But this seems like a more generic problem, and at least a quick glance at the pci_driver methods seems like others don't have a good synchroniation of ->remove against random driver methods.