LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Wang Nan <wangnan0@huawei.com>
Cc: acme@kernel.org, paulus@samba.org, mingo@redhat.com,
	namhyung@kernel.org, lizefan@huawei.com,
	linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH] perf: perl: force to use stdbool.
Date: Mon, 19 Jan 2015 12:23:13 +0100	[thread overview]
Message-ID: <20150119112313.GC11009@krava.brq.redhat.com> (raw)
In-Reply-To: <54BCDF89.5070008@huawei.com>

On Mon, Jan 19, 2015 at 06:42:17PM +0800, Wang Nan wrote:
> Add Jiri Olsa jolsa@kernel.org to CC list. I think jolsa@kernel.org should be the main
> email address he uses.

ack ;-)

jirka

> 
> On 2015/1/15 13:55, Wang Nan wrote:
> > When building perf for arm64 I hit a warning (and be treated as an
> > error) like below:
> > 
> >  aarch64-oe-linux-gcc -o .../util/scripting-engines/trace-event-python.o -c -Wbad-function-cast \
> > 	 ... util/scripting-engines/trace-event-python.c
> > 
> >  In file included from .../usr/lib64/perl/5.14.3/CORE/perl.h:2464:0,
> >                   from Context.xs:23:
> >  /.../usr/lib64/perl/5.14.3/CORE/handy.h:108:0: error: "bool" redefined [-Werror]
> >   #  define bool char
> >   ^
> >  In file included from /.../usr/src/kernel/tools/include/linux/types.h:4:0,
> >                   from /.../usr/src/kernel/arch/arm64/include/uapi/asm/sigcontext.h:19,
> > 		  from /.../usr/include/bits/sigcontext.h:27,
> > 		  from /.../usr/include/signal.h:340,
> > 		  from /.../usr/include/sys/param.h:28,
> > 		  from /.../usr/lib64/perl/5.14.3/CORE/perl.h:678,
> > 		  from Context.xs:23:
> >   /.../usr/lib/aarch64-oe-linux/gcc/aarch64-oe-linux/4.9.2/include/stdbool.h:33:0: note: this is the location of the previous definition
> >     #define bool _Bool
> > 
> > Looks like the failure is caused by arm64 uapi/asm/sigcontext.h, which
> > includes linux/types.h while other archs not.
> > 
> > This patch includes stdbool.h before Context.xs and define HAS_BOOL to
> > prevent perl'e headers define its own 'bool'.
> > 
> > Signed-off-by: Wang Nan <wangnan0@huawei.com>
> > ---
> >  tools/perf/scripts/perl/Perf-Trace-Util/Context.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tools/perf/scripts/perl/Perf-Trace-Util/Context.c b/tools/perf/scripts/perl/Perf-Trace-Util/Context.c
> > index 790ceba..69c3572 100644
> > --- a/tools/perf/scripts/perl/Perf-Trace-Util/Context.c
> > +++ b/tools/perf/scripts/perl/Perf-Trace-Util/Context.c
> > @@ -5,7 +5,8 @@
> >   *	ANY CHANGES MADE HERE WILL BE LOST! 
> >   *
> >   */
> > -
> > +#include <stdbool.h>
> > +#define HAS_BOOL 1

I saw this patch before.. but I had no idea ;-)

seems hacky to me? Is there any doc saying 'this is how you handle this with perl' ? ;-)

I couldn't find any.. or more detailed explanation why we should
define HAS_BOOL and not perl headers..

thanks,
jirka

  reply	other threads:[~2015-01-19 11:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-15  5:55 Wang Nan
2015-01-19 10:42 ` Wang Nan
2015-01-19 11:23   ` Jiri Olsa [this message]
2015-01-19 11:51     ` Wang Nan
2015-01-19 12:38       ` Jiri Olsa
2015-01-19 12:43         ` [PATCH v2] " Wang Nan
2015-01-19 14:26           ` Namhyung Kim
2015-01-20  1:59             ` [PATCH v3] " Wang Nan
2015-01-20  2:07             ` [PATCH v2] " Wang Nan
2015-01-28 15:00           ` [tip:perf/core] perf scripting perl: Force " tip-bot for Wang Nan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150119112313.GC11009@krava.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=paulus@samba.org \
    --cc=wangnan0@huawei.com \
    --subject='Re: [PATCH] perf: perl: force to use stdbool.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).