LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] jbd2: complain about descriptor block checksum errors
@ 2015-01-08 20:03 Darrick J. Wong
2015-01-19 21:11 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Darrick J. Wong @ 2015-01-08 20:03 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: linux-ext4, linux-kernel
We should complain in dmesg when journal recovery fails on account of
the descriptor block being corrupt, so that the diagnostic data can
be recovered.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/jbd2/recovery.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/jbd2/recovery.c b/fs/jbd2/recovery.c
index bcbef08..b5128c6 100644
--- a/fs/jbd2/recovery.c
+++ b/fs/jbd2/recovery.c
@@ -524,6 +524,9 @@ static int do_one_pass(journal_t *journal,
if (descr_csum_size > 0 &&
!jbd2_descr_block_csum_verify(journal,
bh->b_data)) {
+ printk(KERN_ERR "JBD2: Invalid checksum "
+ "recovering block %lu in log\n",
+ next_log_block);
err = -EIO;
brelse(bh);
goto failed;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] jbd2: complain about descriptor block checksum errors
2015-01-08 20:03 [PATCH] jbd2: complain about descriptor block checksum errors Darrick J. Wong
@ 2015-01-19 21:11 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2015-01-19 21:11 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: linux-ext4, linux-kernel
On Thu, Jan 08, 2015 at 12:03:34PM -0800, Darrick J. Wong wrote:
> We should complain in dmesg when journal recovery fails on account of
> the descriptor block being corrupt, so that the diagnostic data can
> be recovered.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-19 21:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-08 20:03 [PATCH] jbd2: complain about descriptor block checksum errors Darrick J. Wong
2015-01-19 21:11 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).