LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Mark Brown <broonie@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Eddie Huang <eddie.huang@mediatek.com>,
	Lee Jones <lee.jones@linaro.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/8] soc: Add MediaTek infracfg controller support
Date: Tue, 20 Jan 2015 16:14:03 +0000	[thread overview]
Message-ID: <20150120161403.GG15924@leverpostej> (raw)
In-Reply-To: <1421747231-554-2-git-send-email-s.hauer@pengutronix.de>

On Tue, Jan 20, 2015 at 09:47:04AM +0000, Sascha Hauer wrote:
> This adds support for the MediaTek infracfg controller found
> on the MT8135/MT8173 SoCs. The infracfg controller contains
> miscellaneous registers for controlling peripheral resets and
> clocks.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  .../devicetree/bindings/soc/mediatek/infracfg.txt  |  19 +++
>  drivers/soc/Kconfig                                |   1 +
>  drivers/soc/Makefile                               |   1 +
>  drivers/soc/mediatek/Kconfig                       |  12 ++
>  drivers/soc/mediatek/Makefile                      |   1 +
>  drivers/soc/mediatek/mtk-infracfg.c                | 127 ++++++++++++++++++++
>  drivers/soc/mediatek/mtk-pericfg.c                 | 128 +++++++++++++++++++++
>  7 files changed, 289 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/soc/mediatek/infracfg.txt
>  create mode 100644 drivers/soc/mediatek/Kconfig
>  create mode 100644 drivers/soc/mediatek/Makefile
>  create mode 100644 drivers/soc/mediatek/mtk-infracfg.c
>  create mode 100644 drivers/soc/mediatek/mtk-pericfg.c
> 
> diff --git a/Documentation/devicetree/bindings/soc/mediatek/infracfg.txt b/Documentation/devicetree/bindings/soc/mediatek/infracfg.txt
> new file mode 100644
> index 0000000..042083a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/mediatek/infracfg.txt
> @@ -0,0 +1,19 @@
> +MediaTek infracfg Controller
> +
> +The infracfg controller contains miscellaneous registers for controlling
> +clocks, resets and bus settings.
> +
> +Required properties:
> +- compatible: must be one of:
> +       mediatek,mt8135-infracfg
> +       mediatek,mt8173-infracfg
> +- reg: Address range for the infracfg controller
> +
> +Example:
> +
> +       infracfg: infracfg@10003000 {
> +               #reset-cells = <1>;
> +               #clock-cells = <1>;

These weren't listed as required or optional above.

Please document these, along with the values a given clock-specifier or
reset-specifier may take.

> +               compatible = "mediatek,mt8135-infracfg";
> +               reg = <0 0x10003000 0 0x1000>;
> +       };

Thanks,
Mark.

  reply	other threads:[~2015-01-20 16:14 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-20  9:47 MediaTek PMIC support Sascha Hauer
2015-01-20  9:47 ` [PATCH 1/8] soc: Add MediaTek infracfg controller support Sascha Hauer
2015-01-20 16:14   ` Mark Rutland [this message]
2015-01-21  8:14     ` Sascha Hauer
2015-01-20  9:47 ` [PATCH 2/8] soc: Add MediaTek pericfg " Sascha Hauer
2015-01-20 13:18   ` Yingjoe Chen
2015-01-20 13:27     ` Sascha Hauer
2015-01-20 16:15   ` Mark Rutland
2015-01-21  8:17     ` Sascha Hauer
2015-01-20  9:47 ` [PATCH 3/8] dt: bindings: Add MediaTek MT8135/MT8173 reset controller defines Sascha Hauer
2015-01-20  9:47 ` [PATCH 4/8] soc: mediatek: Add PMIC wrapper for MT8135 and MT6397 SoC Sascha Hauer
2015-01-20  9:47 ` [PATCH 5/8] ARM: dts: mt8135: Add pericfg, infracfg and pmic wrapper nodes Sascha Hauer
2015-01-20  9:47 ` [PATCH 6/8] ARM: dts: mt8135-evbp1: Add PMIC support Sascha Hauer
2015-01-20  9:47 ` [PATCH 7/8] mfd: Add support for the MediaTek MT6397 PMIC Sascha Hauer
2015-01-20  9:47 ` [PATCH 8/8] regulator: MT6397: Add support for MT6397 regulator Sascha Hauer
2015-01-20 10:07   ` Paul Bolle
2015-01-20 10:54     ` Sascha Hauer
2015-01-21  8:26   ` Sascha Hauer
2015-02-05 15:25 [PATCH v3] MediaTek PMIC support Sascha Hauer
2015-02-05 15:25 ` [PATCH 1/8] soc: Add MediaTek infracfg controller support Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150120161403.GG15924@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=eddie.huang@mediatek.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=olof@lixom.net \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sameo@linux.intel.com \
    --subject='Re: [PATCH 1/8] soc: Add MediaTek infracfg controller support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).