LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 1/3] mfd/axp20x: change battery cell name to fuel gauge
@ 2015-01-07 21:24 Todd E Brandt
  2015-01-08  1:04 ` Jacob Pan
  2015-01-20 11:47 ` Lee Jones
  0 siblings, 2 replies; 4+ messages in thread
From: Todd E Brandt @ 2015-01-07 21:24 UTC (permalink / raw)
  To: linux-pm, linux-iio, linux-kernel
  Cc: jacob.jun.pan, sameo, lee.jones, sre, dbaryshkov, dwmw2,
	david.woodhouse, todd.e.brandt

mfd/axp20x: change battery cell name to fuel gauge

Name changes to the battery cell structure to a
more generic cell type: fuel gauge.

Signed-off-by: Todd Brandt <todd.e.brandt@intel.com>
----
 drivers/mfd/axp20x.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
index b1b580a..e75717e 100644
--- a/drivers/mfd/axp20x.c
+++ b/drivers/mfd/axp20x.c
@@ -87,7 +87,7 @@ static struct resource axp20x_pek_resources[] = {
 	},
 };
 
-static struct resource axp288_battery_resources[] = {
+static struct resource axp288_fuel_gauge_resources[] = {
 	{
 		.start = AXP288_IRQ_QWBTU,
 		.end   = AXP288_IRQ_QWBTU,
@@ -236,7 +236,7 @@ static const struct i2c_device_id axp20x_i2c_id[] = {
 };
 MODULE_DEVICE_TABLE(i2c, axp20x_i2c_id);
 
-static const struct acpi_device_id axp20x_acpi_match[] = {
+static struct acpi_device_id axp20x_acpi_match[] = {
 	{
 		.id = "INT33F4",
 		.driver_data = AXP288_ID,
@@ -350,9 +350,9 @@ static struct mfd_cell axp288_cells[] = {
 		.resources = axp288_charger_resources,
 	},
 	{
-		.name = "axp288_battery",
-		.num_resources = ARRAY_SIZE(axp288_battery_resources),
-		.resources = axp288_battery_resources,
+		.name = "axp288_fuel_gauge",
+		.num_resources = ARRAY_SIZE(axp288_fuel_gauge_resources),
+		.resources = axp288_fuel_gauge_resources,
 	},
 	{
 		.name = "axp288_pmic_acpi",

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/3] mfd/axp20x: change battery cell name to fuel gauge
  2015-01-07 21:24 [PATCH 1/3] mfd/axp20x: change battery cell name to fuel gauge Todd E Brandt
@ 2015-01-08  1:04 ` Jacob Pan
  2015-01-20 11:47 ` Lee Jones
  1 sibling, 0 replies; 4+ messages in thread
From: Jacob Pan @ 2015-01-08  1:04 UTC (permalink / raw)
  To: todd.e.brandt
  Cc: linux-pm, linux-iio, linux-kernel, sameo, lee.jones, sre,
	dbaryshkov, dwmw2, david.woodhouse, todd.e.brandt

On Wed, 7 Jan 2015 13:24:50 -0800
Todd E Brandt <todd.e.brandt@linux.intel.com> wrote:

> mfd/axp20x: change battery cell name to fuel gauge
> 
Acked-by: Jacob Pan <jacob.jun.pan@linux.intel.com>

> Name changes to the battery cell structure to a
> more generic cell type: fuel gauge.
> 
> Signed-off-by: Todd Brandt <todd.e.brandt@intel.com>
> ----
>  drivers/mfd/axp20x.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index b1b580a..e75717e 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -87,7 +87,7 @@ static struct resource axp20x_pek_resources[] = {
>  	},
>  };
>  
> -static struct resource axp288_battery_resources[] = {
> +static struct resource axp288_fuel_gauge_resources[] = {
>  	{
>  		.start = AXP288_IRQ_QWBTU,
>  		.end   = AXP288_IRQ_QWBTU,
> @@ -236,7 +236,7 @@ static const struct i2c_device_id axp20x_i2c_id[]
> = { };
>  MODULE_DEVICE_TABLE(i2c, axp20x_i2c_id);
>  
> -static const struct acpi_device_id axp20x_acpi_match[] = {
> +static struct acpi_device_id axp20x_acpi_match[] = {
>  	{
>  		.id = "INT33F4",
>  		.driver_data = AXP288_ID,
> @@ -350,9 +350,9 @@ static struct mfd_cell axp288_cells[] = {
>  		.resources = axp288_charger_resources,
>  	},
>  	{
> -		.name = "axp288_battery",
> -		.num_resources =
> ARRAY_SIZE(axp288_battery_resources),
> -		.resources = axp288_battery_resources,
> +		.name = "axp288_fuel_gauge",
> +		.num_resources =
> ARRAY_SIZE(axp288_fuel_gauge_resources),
> +		.resources = axp288_fuel_gauge_resources,
>  	},
>  	{
>  		.name = "axp288_pmic_acpi",

[Jacob Pan]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/3] mfd/axp20x: change battery cell name to fuel gauge
  2015-01-07 21:24 [PATCH 1/3] mfd/axp20x: change battery cell name to fuel gauge Todd E Brandt
  2015-01-08  1:04 ` Jacob Pan
@ 2015-01-20 11:47 ` Lee Jones
  2015-01-21 19:16   ` Todd E Brandt
  1 sibling, 1 reply; 4+ messages in thread
From: Lee Jones @ 2015-01-20 11:47 UTC (permalink / raw)
  To: Todd E Brandt
  Cc: linux-pm, linux-iio, linux-kernel, jacob.jun.pan, sameo, sre,
	dbaryshkov, dwmw2, david.woodhouse, todd.e.brandt

On Wed, 07 Jan 2015, Todd E Brandt wrote:

> mfd/axp20x: change battery cell name to fuel gauge
> 
> Name changes to the battery cell structure to a
> more generic cell type: fuel gauge.
> 
> Signed-off-by: Todd Brandt <todd.e.brandt@intel.com>
> ----
>  drivers/mfd/axp20x.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index b1b580a..e75717e 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -87,7 +87,7 @@ static struct resource axp20x_pek_resources[] = {
>  	},
>  };
>  
> -static struct resource axp288_battery_resources[] = {
> +static struct resource axp288_fuel_gauge_resources[] = {
>  	{
>  		.start = AXP288_IRQ_QWBTU,
>  		.end   = AXP288_IRQ_QWBTU,
> @@ -236,7 +236,7 @@ static const struct i2c_device_id axp20x_i2c_id[] = {
>  };
>  MODULE_DEVICE_TABLE(i2c, axp20x_i2c_id);
>  
> -static const struct acpi_device_id axp20x_acpi_match[] = {
> +static struct acpi_device_id axp20x_acpi_match[] = {

Why have you dropped the cost qualifier here?

[...]

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/3] mfd/axp20x: change battery cell name to fuel gauge
  2015-01-20 11:47 ` Lee Jones
@ 2015-01-21 19:16   ` Todd E Brandt
  0 siblings, 0 replies; 4+ messages in thread
From: Todd E Brandt @ 2015-01-21 19:16 UTC (permalink / raw)
  To: Lee Jones
  Cc: linux-pm, linux-iio, linux-kernel, jacob.jun.pan, sameo, sre,
	dbaryshkov, dwmw2, david.woodhouse, todd.e.brandt

On Tue, Jan 20, 2015 at 11:47:25AM +0000, Lee Jones wrote:
> On Wed, 07 Jan 2015, Todd E Brandt wrote:
> 
> > mfd/axp20x: change battery cell name to fuel gauge
> > 
> > Name changes to the battery cell structure to a
> > more generic cell type: fuel gauge.
> > 
> > Signed-off-by: Todd Brandt <todd.e.brandt@intel.com>
> > ----
> >  drivers/mfd/axp20x.c | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> > index b1b580a..e75717e 100644
> > --- a/drivers/mfd/axp20x.c
> > +++ b/drivers/mfd/axp20x.c
> > @@ -87,7 +87,7 @@ static struct resource axp20x_pek_resources[] = {
> >  	},
> >  };
> >  
> > -static struct resource axp288_battery_resources[] = {
> > +static struct resource axp288_fuel_gauge_resources[] = {
> >  	{
> >  		.start = AXP288_IRQ_QWBTU,
> >  		.end   = AXP288_IRQ_QWBTU,
> > @@ -236,7 +236,7 @@ static const struct i2c_device_id axp20x_i2c_id[] = {
> >  };
> >  MODULE_DEVICE_TABLE(i2c, axp20x_i2c_id);
> >  
> > -static const struct acpi_device_id axp20x_acpi_match[] = {
> > +static struct acpi_device_id axp20x_acpi_match[] = {
> 
> Why have you dropped the cost qualifier here?

That's a bug, I shouldn't have removed the const qualifier, I'll submit a
v2 patch with this change removed. Thanks for the catch.

> 
> [...]
> 
> -- 
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-01-21 19:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-07 21:24 [PATCH 1/3] mfd/axp20x: change battery cell name to fuel gauge Todd E Brandt
2015-01-08  1:04 ` Jacob Pan
2015-01-20 11:47 ` Lee Jones
2015-01-21 19:16   ` Todd E Brandt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).