LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.cz>
To: Pranith Kumar <bobby.prani@gmail.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
	"Steven Rostedt (Red Hat)" <rostedt@goodmis.org>,
	"John Stultz" <john.stultz@linaro.org>,
	"Joe Perches" <joe@perches.com>,
	"Simon Kågström" <simon.kagstrom@netinsight.net>,
	"Borislav Petkov" <bp@suse.de>,
	"Dan Streetman" <ddstreet@ieee.org>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"open list" <linux-kernel@vger.kernel.org>,
	"Michael Ellerman" <mpe@ellerman.id.au>
Subject: Re: [PATCH v2 1/2] printk: Add dummy routine for when CONFIG_PRINTK=n
Date: Thu, 22 Jan 2015 15:13:09 +0100	[thread overview]
Message-ID: <20150122141309.GA14531@pathway.suse.cz> (raw)
In-Reply-To: <1421893570-6920-1-git-send-email-bobby.prani@gmail.com>

On Wed 2015-01-21 21:26:08, Pranith Kumar wrote:
> There are missing dummy routines for log_buf_addr_get() and log_buf_len_get()
> for when CONFIG_PRINTK is not set causing build failures.
> 
> This patch adds these dummy routines at the appropriate location.
> 
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>

Reviewed-by: Petr Mladek <pmladek@suse.cz>

Makes perfect sense and builds now :-)

Best Regards,
Petr

> CC: Michael Ellerman <mpe@ellerman.id.au>
> ---
>  include/linux/printk.h | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/printk.h b/include/linux/printk.h
> index aeb9d7f..baa3f97 100644
> --- a/include/linux/printk.h
> +++ b/include/linux/printk.h
> @@ -10,9 +10,6 @@
>  extern const char linux_banner[];
>  extern const char linux_proc_banner[];
>  
> -extern char *log_buf_addr_get(void);
> -extern u32 log_buf_len_get(void);
> -
>  static inline int printk_get_level(const char *buffer)
>  {
>  	if (buffer[0] == KERN_SOH_ASCII && buffer[1]) {
> @@ -163,6 +160,8 @@ extern int kptr_restrict;
>  
>  extern void wake_up_klogd(void);
>  
> +char *log_buf_addr_get(void);
> +u32 log_buf_len_get(void);
>  void log_buf_kexec_setup(void);
>  void __init setup_log_buf(int early);
>  void dump_stack_set_arch_desc(const char *fmt, ...);
> @@ -198,6 +197,16 @@ static inline void wake_up_klogd(void)
>  {
>  }
>  
> +static inline char *log_buf_addr_get(void)
> +{
> +	return NULL;
> +}
> +
> +static inline u32 log_buf_len_get(void)
> +{
> +	return 0;
> +}
> +
>  static inline void log_buf_kexec_setup(void)
>  {
>  }
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

  parent reply	other threads:[~2015-01-22 14:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-22  2:26 Pranith Kumar
2015-01-22  2:26 ` [PATCH v2 2/2] powerpc/powernv: Skip registering log region " Pranith Kumar
2015-01-22  5:19   ` Michael Ellerman
2015-01-22 14:34     ` Pranith Kumar
2015-01-22 22:35       ` Stewart Smith
2015-01-23  4:03         ` Pranith Kumar
2015-01-23  4:13           ` Michael Ellerman
2015-01-22 14:13 ` Petr Mladek [this message]
2015-01-22 14:17 ` [PATCH v2 1/2] printk: Add dummy routine for " Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150122141309.GA14531@pathway.suse.cz \
    --to=pmladek@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bobby.prani@gmail.com \
    --cc=bp@suse.de \
    --cc=ddstreet@ieee.org \
    --cc=joe@perches.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=rostedt@goodmis.org \
    --cc=simon.kagstrom@netinsight.net \
    --subject='Re: [PATCH v2 1/2] printk: Add dummy routine for when CONFIG_PRINTK=n' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).