LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu,
	vincent.weaver@maine.edu, cl@linux.com, paulus@samba.org,
	acme@redhat.com
Subject: Re: [PATCH] perf/rapl: fix crash in rapl_scale()
Date: Fri, 23 Jan 2015 09:39:31 +0100	[thread overview]
Message-ID: <20150123083931.GD2896@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20150122203834.GA10228@thinkpad>

On Thu, Jan 22, 2015 at 09:38:34PM +0100, Stephane Eranian wrote:
> 
> This patch fixes a systematic crash in rapl_scale()
> due to an invalid pointer.
> 
> The bug was introduced by commit:
> commit 89cbc76768c2fa4ed95545bf961f3a14ddfeed21
> Author: Christoph Lameter <cl@linux.com>
> Date:   Sun Aug 17 12:30:40 2014 -0500
> 
>     x86: Replace __get_cpu_var uses
> 
> 
> The fix is simple. Just put the parenthesis where it needs
> to be, i.e., around rapl_pmu. To my surprise, the compiler
> was not complaining about passing an integer instead of a
> pointer.
> 
> Reported-by: Vince Weaver <vincent.weaver@maine.edu>
> Signed-off-by: Stephane Eranian <eranian@google.com>
> Tested-by: Vince Weaver <vincent.weaver@maine.edu>

Thanks!

  reply	other threads:[~2015-01-23  8:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-22 20:38 Stephane Eranian
2015-01-23  8:39 ` Peter Zijlstra [this message]
2015-01-28 14:29 ` [tip:perf/urgent] perf/rapl: Fix " tip-bot for Stephane Eranian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150123083931.GD2896@worktop.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=acme@redhat.com \
    --cc=cl@linux.com \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=vincent.weaver@maine.edu \
    --subject='Re: [PATCH] perf/rapl: fix crash in rapl_scale()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).