LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Simon Kelley <simon@thekelleys.org.uk>,
	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [v2] atmel: Remove open-coded and wrong strcasecmp
Date: Fri, 23 Jan 2015 19:40:23 +0000 (UTC)	[thread overview]
Message-ID: <20150123194023.B69BE141EF5@smtp.codeaurora.org> (raw)
In-Reply-To: <1421841127-8209-1-git-send-email-linux@rasmusvillemoes.dk>


> The kernel's string library does in fact have strcasecmp, at least
> since ded220bd8f08 ("[STRING]: Move strcasecmp/strncasecmp to
> lib/string.c"). Moreover, this open-coded version is in fact wrong: If
> the strings only differ in their last character, a and b have already
> been incremented to point to the terminating NUL bytes, so they would
> wrongly be treated as equal.
> 
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>

Thanks, applied to wireless-drivers-next.git. I just remove the useless "net:
wireless:" from the title. People, PLEASE stop using that.

Kalle Valo

      reply	other threads:[~2015-01-23 19:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-16 13:28 [PATCH] net: wireless: " Rasmus Villemoes
2015-01-16 18:17 ` Sergei Shtylyov
2015-01-21 11:52 ` [PATCH v2] " Rasmus Villemoes
2015-01-23 19:40   ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150123194023.B69BE141EF5@smtp.codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=netdev@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=simon@thekelleys.org.uk \
    --subject='Re: [v2] atmel: Remove open-coded and wrong strcasecmp' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).