LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] input: (gtco) use sign_extend32() for sign extension
@ 2015-01-23 12:29 Martin Kepplinger
  2015-01-24  0:47 ` Dmitry Torokhov
  0 siblings, 1 reply; 2+ messages in thread
From: Martin Kepplinger @ 2015-01-23 12:29 UTC (permalink / raw)
  To: dmitry.torokhov; +Cc: khoroshilov, linux-input, linux-kernel, Martin Kepplinger

Signed-off-by: Martin Kepplinger <martink@posteo.de>
---
Despite it's name, sign_extend32() is safe to use for 8 and 16 bit types too.


 drivers/input/tablet/gtco.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/drivers/input/tablet/gtco.c b/drivers/input/tablet/gtco.c
index 8580456..272a838 100644
--- a/drivers/input/tablet/gtco.c
+++ b/drivers/input/tablet/gtco.c
@@ -59,7 +59,7 @@ Scott Hill shill@gtcocalcomp.com
 #include <asm/uaccess.h>
 #include <asm/unaligned.h>
 #include <asm/byteorder.h>
-
+#include <linux/bitops.h>
 
 #include <linux/usb/input.h>
 
@@ -666,13 +666,8 @@ static void gtco_urb_callback(struct urb *urbinfo)
 		case 4:
 			/* Tilt */
 
-			/* Sign extend these 7 bit numbers.  */
-			if (device->buffer[6] & 0x40)
-				device->buffer[6] |= 0x80;
-
-			if (device->buffer[7] & 0x40)
-				device->buffer[7] |= 0x80;
-
+			device->buffer[6] = sign_extend32(device->buffer[6], 6);
+			device->buffer[7] = sign_extend32(device->buffer[7], 6);
 
 			valsigned = (device->buffer[6]);
 			input_report_abs(inputdev, ABS_TILT_X, (s32)valsigned);
-- 
2.1.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] input: (gtco) use sign_extend32() for sign extension
  2015-01-23 12:29 [PATCH] input: (gtco) use sign_extend32() for sign extension Martin Kepplinger
@ 2015-01-24  0:47 ` Dmitry Torokhov
  0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2015-01-24  0:47 UTC (permalink / raw)
  To: Martin Kepplinger; +Cc: khoroshilov, linux-input, linux-kernel

On Fri, Jan 23, 2015 at 01:29:36PM +0100, Martin Kepplinger wrote:
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
> ---
> Despite it's name, sign_extend32() is safe to use for 8 and 16 bit types too.


Applied, thank you, but I am sure it can be cleaned up even more.

> 
> 
>  drivers/input/tablet/gtco.c | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/input/tablet/gtco.c b/drivers/input/tablet/gtco.c
> index 8580456..272a838 100644
> --- a/drivers/input/tablet/gtco.c
> +++ b/drivers/input/tablet/gtco.c
> @@ -59,7 +59,7 @@ Scott Hill shill@gtcocalcomp.com
>  #include <asm/uaccess.h>
>  #include <asm/unaligned.h>
>  #include <asm/byteorder.h>
> -
> +#include <linux/bitops.h>
>  
>  #include <linux/usb/input.h>
>  
> @@ -666,13 +666,8 @@ static void gtco_urb_callback(struct urb *urbinfo)
>  		case 4:
>  			/* Tilt */
>  
> -			/* Sign extend these 7 bit numbers.  */
> -			if (device->buffer[6] & 0x40)
> -				device->buffer[6] |= 0x80;
> -
> -			if (device->buffer[7] & 0x40)
> -				device->buffer[7] |= 0x80;
> -
> +			device->buffer[6] = sign_extend32(device->buffer[6], 6);
> +			device->buffer[7] = sign_extend32(device->buffer[7], 6);
>  
>  			valsigned = (device->buffer[6]);
>  			input_report_abs(inputdev, ABS_TILT_X, (s32)valsigned);
> -- 
> 2.1.4
> 

-- 
Dmitry

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-01-24  0:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-23 12:29 [PATCH] input: (gtco) use sign_extend32() for sign extension Martin Kepplinger
2015-01-24  0:47 ` Dmitry Torokhov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).