LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: NeilBrown <neilb@suse.de>
Cc: Marek Belisko <marek@goldelico.com>,
	bcousson@baylibre.com, robh+dt@kernel.org, pawel.moll@arm.com,
	mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
	galak@codeaurora.org, linux-omap@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, hns@goldelico.com,
	NeilBrown <neil@brown.name>
Subject: Re: [PATCH 12/13] ARM: dts: omap3-gta04: uart4 is not connected, so mark it "disabled"
Date: Fri, 23 Jan 2015 17:03:41 -0800	[thread overview]
Message-ID: <20150124010340.GB28663@atomide.com> (raw)
In-Reply-To: <20150124092842.2441d3c6@notabene.brown>

* NeilBrown <neilb@suse.de> [150123 14:31]:
> On Thu, 22 Jan 2015 13:40:53 -0800 Tony Lindgren <tony@atomide.com> wrote:
> > >  
> > > +&uart4 {
> > > +	status = "disabled";
> > > +};
> > > +
> > 
> > This you probably want to avoid from PM point of view. Depending on
> > bootloader state of uart4, Linux may or may not be able to hit any
> > deeper power states.
> > 
> > Marking something with status = "disabled" in dts causes the device
> > entry not even to be created. That means hwmod won't be able to reset
> > and idle this device during boot.
> > 
> > The uart4 device is there for sure even if not muxed and in incomplete
> > state. You may want to also check other places where you're using
> > status = "disabled" for the same reasons.
> 
> That's ... unfortunate.  Would that apply to the MCBSPs too?  They are
> disabled by default so you would need to explicitly enable them all for
> sensible behaviour....

Yeah that applies to all the SoC integrated devices that the bus code
(hwmod) is supposed to reset and idle if unused. Basically anything
that depends on the dev entry being created.
 
> Hopefully there is some way to mark as device as "this is not used, make sure
> it is turned off and stays off" ???

Not currently that I know of :) To do that, we should add something
like status = "incomplete" where the dev entry gets created but the
driver is never probed. And incomplete here meaning that the device
is missing some parts like pins that would make it work properly.
 
> Thanks for the heads-up.  I'll have a look and see exactly what is happening.

OK
 
> BTW, on the topic of OMAP UARTs and power saving...
>  I note that there are now two drivers for the OMAP3 UART - omap-serial and
>  8250_omap.
>  I also note that your commit:
> 
> commit a2fc36613ac1af2e92cbed7af80bc72d8114dd50
>     ARM: OMAP3: Use manual idle for UARTs because of DMA errata
> 
>  is incompatible with omap-serial.  In particular, if I enable runtime
>  suspend of the serial port by setting the autosuspend_timeout, then incoming
>  characters will no longer wake the port (if I revert your patch incoming
>  chars do wake the port).
>  This could (I think) be fixed by enabling the RX/CTS interrupt.  However if
>  omap-serial is being deprecated, then there probably isn't any point.
> 
>  So: what is the longer term expectation for these drivers?  Should we be
>  switching over to 8250?

Yeah you should alredy be able to do it. Hopefully we'll have some
translation layer and the old omap-serial.c can be mostly removed
now that we have 8250 support with runtime PM :)

Regards,

Tony

  reply	other threads:[~2015-01-24  1:07 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-22 20:38 [PATCH 00/13] ARM: dts: omap3-gta04: Various DT fixes Marek Belisko
2015-01-22 20:38 ` [PATCH 01/13] ARM: dts: omap3-gta04: Fix backup-battery charging in devicetree file Marek Belisko
2015-01-22 20:38 ` [PATCH 02/13] ARM: dts: omap3-gta04: Fix audio node malformatting Marek Belisko
2015-01-22 20:38 ` [PATCH 03/13] ARM: dts: omap3-gta04: Enable mcbps2 necessary for audio Marek Belisko
2015-01-22 20:38 ` [PATCH 04/13] ARM: dts: omap3-gta04: Enable twl audio vibra support Marek Belisko
2015-01-22 20:38 ` [PATCH 05/13] ARM: dts: omap3-gta04: Fix a GPIO line for bma180 node Marek Belisko
2015-01-22 20:38 ` [PATCH 06/13] ARM: dts: omap3-gta04: Enable power-off using twl4030 Marek Belisko
2015-01-22 21:37   ` Tony Lindgren
2015-01-22 20:38 ` [PATCH 07/13] ARM: dts: omap3-gta04: Add ramp value for twl4030 audio Marek Belisko
2015-01-22 20:38 ` [PATCH 08/13] ARM: dts: omap3-gta04: add comments about gpios Marek Belisko
2015-01-22 20:38 ` [PATCH 09/13] ARM: dts: omap3-gta04: enable power-off for wifi card Marek Belisko
2015-01-22 20:38 ` [PATCH 10/13] ARM: dts: omap3-gta04: add gyroscope Marek Belisko
2015-01-22 20:38 ` [PATCH 11/13] ARM: dts: omap3-gta04: only power DSS when necessary Marek Belisko
2015-01-22 20:38 ` [PATCH 12/13] ARM: dts: omap3-gta04: uart4 is not connected, so mark it "disabled" Marek Belisko
2015-01-22 21:40   ` Tony Lindgren
2015-01-23 22:28     ` NeilBrown
2015-01-24  1:03       ` Tony Lindgren [this message]
2015-01-22 20:38 ` [PATCH 13/13] ARM: dts: omap3-gta04: Disable keypad Marek Belisko
2015-01-26 20:51 ` [PATCH 00/13] ARM: dts: omap3-gta04: Various DT fixes Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150124010340.GB28663@atomide.com \
    --to=tony@atomide.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=hns@goldelico.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=marek@goldelico.com \
    --cc=mark.rutland@arm.com \
    --cc=neil@brown.name \
    --cc=neilb@suse.de \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH 12/13] ARM: dts: omap3-gta04: uart4 is not connected, so mark it "disabled"' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).