LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: jitendra kumar khasdev <jkhasdev@gmail.com>
Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] Staging: comedi: fix line over 80 characters warning
Date: Sat, 24 Jan 2015 10:29:41 +0800	[thread overview]
Message-ID: <20150124022941.GA4161@kroah.com> (raw)
In-Reply-To: <1422040280-20213-3-git-send-email-jkhasdev@gmail.com>

On Sat, Jan 24, 2015 at 12:41:20AM +0530, jitendra kumar khasdev wrote:
> This is patch to file jr3_pci.c that fix up warning line
> over 80 character which is found by checkpatch tool. Made change into signature
> of struct jr3_pci_poll_delay jr3_pci_poll_subdevice function by giving a newline
> so that 80 character line over warning to be reduced.

The irony of not properly line-wrapping your changelog comment for a
patch that you are fixing up proper line size is huge :)


> 
> Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
> ---
>  drivers/staging/comedi/drivers/jr3_pci.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/comedi/drivers/jr3_pci.c b/drivers/staging/comedi/drivers/jr3_pci.c
> index 81fab2d..1de843d 100644
> --- a/drivers/staging/comedi/drivers/jr3_pci.c
> +++ b/drivers/staging/comedi/drivers/jr3_pci.c
> @@ -449,7 +449,8 @@ static int jr3_download_firmware(struct comedi_device *dev,
>  	return 0;
>  }
>  
> -static struct jr3_pci_poll_delay jr3_pci_poll_subdevice(struct comedi_subdevice *s)
> +static struct jr3_pci_poll_delay jr3_pci_poll_subdevice(struct comedi_subdevice
> +							*s)

Be reasonable, this is now looks worse than the code did before, just
leave this as-is, coding style is a guideline, not hard rules.

thanks,

greg k-h

  reply	other threads:[~2015-01-24  2:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-23 19:11 [PATCH v1 0/2] line over 80 character warnings jitendra kumar khasdev
2015-01-23 19:11 ` [PATCH v1 1/2] Staging: comedi: fix line over 80 characters warning jitendra kumar khasdev
2015-01-26 11:19   ` Ian Abbott
2015-01-23 19:11 ` [PATCH v1 2/2] " jitendra kumar khasdev
2015-01-24  2:29   ` Greg KH [this message]
2015-01-26 11:20   ` Ian Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150124022941.GA4161@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=hsweeten@visionengravers.com \
    --cc=jkhasdev@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH v1 2/2] Staging: comedi: fix line over 80 characters warning' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).