LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Al Viro <viro@ZenIV.linux.org.uk>,
	Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 4/5 v2] tracefs: Add directory /sys/kernel/tracing
Date: Sat, 24 Jan 2015 11:00:56 +0800	[thread overview]
Message-ID: <20150124030056.GC5009@kroah.com> (raw)
In-Reply-To: <20150123162414.743137310@goodmis.org>

On Fri, Jan 23, 2015 at 10:55:29AM -0500, Steven Rostedt wrote:
> From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>
> 
> When tracefs is configured, have the directory /sys/kernel/tracing appear
> just like /sys/kernel/debug appears when debugfs is configured.
> 
> This will give a consistent place for system admins to mount tracefs.
> 
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
> ---
>  fs/tracefs/inode.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/fs/tracefs/inode.c b/fs/tracefs/inode.c
> index c31997a303c7..cdbaa42b44a1 100644
> --- a/fs/tracefs/inode.c
> +++ b/fs/tracefs/inode.c
> @@ -16,6 +16,7 @@
>  #include <linux/module.h>
>  #include <linux/fs.h>
>  #include <linux/mount.h>
> +#include <linux/kobject.h>
>  #include <linux/namei.h>
>  #include <linux/tracefs.h>
>  #include <linux/fsnotify.h>
> @@ -547,10 +548,16 @@ bool tracefs_initialized(void)
>  	return tracefs_registered;
>  }
>  
> +static struct kobject *trace_kobj;
> +
>  static int __init tracefs_init(void)
>  {
>  	int retval;
>  
> +	trace_kobj = kobject_create_and_add("tracing", kernel_kobj);
> +	if (!trace_kobj)
> +		return -EINVAL;
> +
>  	retval = register_filesystem(&trace_fs_type);
>  	if (!retval)
>  		tracefs_registered = true;
> -- 
> 2.1.4
> 

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

  reply	other threads:[~2015-01-24  3:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-23 15:55 [PATCH 0/5 v2] tracing: Add new file system tracefs Steven Rostedt
2015-01-23 15:55 ` [PATCH 1/5 v2] tracefs: Add new tracefs file system Steven Rostedt
2015-01-23 15:55 ` [PATCH 2/5 v2] tracing: Convert the tracing facility over to use tracefs Steven Rostedt
2015-01-23 15:55 ` [PATCH 3/5 v2] tracing: Automatically mount tracefs on debugfs/tracing Steven Rostedt
2015-01-24  3:00   ` Greg Kroah-Hartman
2015-01-24 11:33     ` Steven Rostedt
2015-01-25 13:22       ` Greg Kroah-Hartman
2015-01-25 19:38         ` Steven Rostedt
2015-01-25 19:59           ` Al Viro
2015-01-25 20:27             ` Al Viro
2015-01-25 20:31               ` Al Viro
2015-01-23 15:55 ` [PATCH 4/5 v2] tracefs: Add directory /sys/kernel/tracing Steven Rostedt
2015-01-24  3:00   ` Greg Kroah-Hartman [this message]
2015-01-23 15:55 ` [PATCH 5/5 v2] tracing: Have mkdir and rmdir be part of tracefs Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150124030056.GC5009@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=viro@ZenIV.linux.org.uk \
    --subject='Re: [PATCH 4/5 v2] tracefs: Add directory /sys/kernel/tracing' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).