LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: vivien.didelot@savoirfairelinux.com
Cc: netdev@vger.kernel.org, f.fainelli@gmail.com,
linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com
Subject: Re: [PATCH] net: dsa: set slave MII bus PHY mask
Date: Sun, 25 Jan 2015 16:01:21 -0800 (PST) [thread overview]
Message-ID: <20150125.160121.1332719031463622112.davem@davemloft.net> (raw)
In-Reply-To: <1421799212-2028-2-git-send-email-vivien.didelot@savoirfairelinux.com>
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Date: Tue, 20 Jan 2015 19:13:32 -0500
> When registering a mdio bus, Linux assumes than every port has a PHY and tries
> to scan it. If a switch port has no PHY registered, DSA will fail to register
> the slave MII bus. To fix this, set the slave MII bus PHY mask to the switch
> PHYs mask.
>
> As an example, if we use a Marvell MV88E6352 (which is a 7-port switch with no
> registered PHYs for port 5 and port 6), with the following declared names:
>
> static struct dsa_chip_data switch_cdata = {
> [...]
> .port_names[0] = "sw0",
> .port_names[1] = "sw1",
> .port_names[2] = "sw2",
> .port_names[3] = "sw3",
> .port_names[4] = "sw4",
> .port_names[5] = "cpu",
> };
>
> DSA will fail to create the switch instance. With the PHY mask set for the
> slave MII bus, only the PHY for ports 0-4 will be scanned and the instance will
> be successfully created.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Applied.
next prev parent reply other threads:[~2015-01-26 0:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 0:13 [PATCH] net: dsa: set parent of hwmon device Vivien Didelot
2015-01-21 0:13 ` [PATCH] net: dsa: set slave MII bus PHY mask Vivien Didelot
2015-01-21 0:37 ` Florian Fainelli
2015-01-26 0:01 ` David Miller [this message]
2015-01-21 2:48 ` [PATCH] net: dsa: set parent of hwmon device Guenter Roeck
2015-01-21 3:50 ` Guenter Roeck
2015-01-21 5:58 ` Florian Fainelli
2015-01-21 16:26 ` Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150125.160121.1332719031463622112.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
--subject='Re: [PATCH] net: dsa: set slave MII bus PHY mask' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).