LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jiri Olsa <jolsa@kernel.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH 2/5] tools lib api fs: Add tracefs mount helper functions
Date: Sun, 25 Jan 2015 14:22:33 -0500	[thread overview]
Message-ID: <20150125142233.1338c2e5@gandalf.local.home> (raw)
In-Reply-To: <20150125164536.GD31987@krava.brq.redhat.com>

On Sun, 25 Jan 2015 17:45:36 +0100
Jiri Olsa <jolsa@redhat.com> wrote:

> On Sat, Jan 24, 2015 at 01:13:32PM -0500, Steven Rostedt wrote:
> 
> SNIP
> 
> > diff --git a/tools/lib/api/fs/tracefs.h b/tools/lib/api/fs/tracefs.h
> > new file mode 100644
> > index 000000000000..576206500e15
> > --- /dev/null
> > +++ b/tools/lib/api/fs/tracefs.h
> > @@ -0,0 +1,29 @@
> > +#ifndef __API_TRACEFS_H__
> > +#define __API_TRACEFS_H__
> > +
> > +#define _STR(x) #x
> > +#define STR(x) _STR(x)
> 
> I can't find STR macro being used in the code..

I noticed this too just after I sent the series. I was seeing who had
good eyes ;-)

It's from doing a cut and paste from debugfs.h, which still has it,
even though after this series, it's only used by findfs.c. Thus it
should be moved to findfs.h, and removed from debugfs.h and tracefs.h.

Thanks, will fix.

-- Steve

  reply	other threads:[~2015-01-25 19:22 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-24 18:13 [PATCH 0/5] perf: Have perf become tracefs aware Steven Rostedt
2015-01-24 18:13 ` [PATCH 1/5] tools lib fs: Add helper to find mounted file systems Steven Rostedt
2015-01-25 16:41   ` Jiri Olsa
2015-01-25 19:20     ` Steven Rostedt
2015-01-24 18:13 ` [PATCH 2/5] tools lib api fs: Add tracefs mount helper functions Steven Rostedt
2015-01-25 16:45   ` Jiri Olsa
2015-01-25 19:22     ` Steven Rostedt [this message]
2015-01-25 16:51   ` Jiri Olsa
2015-01-25 19:24     ` Steven Rostedt
2015-01-25 16:56   ` Jiri Olsa
2015-01-25 19:26     ` Steven Rostedt
2015-01-26  9:02       ` Jiri Olsa
2015-01-26 14:26         ` Steven Rostedt
2015-01-26 14:31           ` Jiri Olsa
2015-01-26 14:44             ` Arnaldo Carvalho de Melo
2015-01-24 18:13 ` [PATCH 3/5] tools lib api fs: Add DEBUGFS_DEFAULT_PATH macro Steven Rostedt
2015-01-24 18:13 ` [PATCH 4/5] tools lib api fs: Add {tracefs,debugfs}_configured() functions Steven Rostedt
2015-01-25 17:02   ` Jiri Olsa
2015-01-25 19:27     ` Steven Rostedt
2015-01-24 18:13 ` [PATCH 5/5] perf: Make perf aware of tracefs Steven Rostedt
2015-01-25 13:50   ` Namhyung Kim
2015-01-25 19:19     ` Steven Rostedt
2015-01-25 17:34   ` Jiri Olsa
2015-01-25 19:31     ` Steven Rostedt
2015-01-26  8:57       ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150125142233.1338c2e5@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=acme@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=jolsa@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --subject='Re: [PATCH 2/5] tools lib api fs: Add tracefs mount helper functions' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).