LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jiri Olsa <jolsa@kernel.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH 4/5] tools lib api fs: Add {tracefs,debugfs}_configured() functions
Date: Sun, 25 Jan 2015 18:02:03 +0100	[thread overview]
Message-ID: <20150125170203.GG31987@krava.brq.redhat.com> (raw)
In-Reply-To: <20150124181449.008674149@goodmis.org>

On Sat, Jan 24, 2015 at 01:13:34PM -0500, Steven Rostedt wrote:

SNIP

>  #include <sys/mount.h>
>  #include <linux/kernel.h>
>  
> @@ -24,6 +27,16 @@ static const char * const debugfs_known_mountpoints[] = {
>  
>  static bool debugfs_found;
>  
> +bool debugfs_configured(void)
> +{
> +	struct stat st;
> +
> +	if (stat(DEBUGFS_DEFAULT_PATH, &st) < 0)
> +		return false;
> +

hum, should  this function rather do

bool debugfs_configured(void)
{
	return debugfs_find_mountpoint() != NULL;
}


SNIP

>  static bool tracefs_found;
>  
> +bool tracefs_configured(void)
> +{
> +	struct stat st;
> +
> +	if (stat(TRACEFS_DEFAULT_PATH, &st) < 0)
> +		return false;
> +
> +	return true;
> +}

same for this one..

jirka

  reply	other threads:[~2015-01-25 17:02 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-24 18:13 [PATCH 0/5] perf: Have perf become tracefs aware Steven Rostedt
2015-01-24 18:13 ` [PATCH 1/5] tools lib fs: Add helper to find mounted file systems Steven Rostedt
2015-01-25 16:41   ` Jiri Olsa
2015-01-25 19:20     ` Steven Rostedt
2015-01-24 18:13 ` [PATCH 2/5] tools lib api fs: Add tracefs mount helper functions Steven Rostedt
2015-01-25 16:45   ` Jiri Olsa
2015-01-25 19:22     ` Steven Rostedt
2015-01-25 16:51   ` Jiri Olsa
2015-01-25 19:24     ` Steven Rostedt
2015-01-25 16:56   ` Jiri Olsa
2015-01-25 19:26     ` Steven Rostedt
2015-01-26  9:02       ` Jiri Olsa
2015-01-26 14:26         ` Steven Rostedt
2015-01-26 14:31           ` Jiri Olsa
2015-01-26 14:44             ` Arnaldo Carvalho de Melo
2015-01-24 18:13 ` [PATCH 3/5] tools lib api fs: Add DEBUGFS_DEFAULT_PATH macro Steven Rostedt
2015-01-24 18:13 ` [PATCH 4/5] tools lib api fs: Add {tracefs,debugfs}_configured() functions Steven Rostedt
2015-01-25 17:02   ` Jiri Olsa [this message]
2015-01-25 19:27     ` Steven Rostedt
2015-01-24 18:13 ` [PATCH 5/5] perf: Make perf aware of tracefs Steven Rostedt
2015-01-25 13:50   ` Namhyung Kim
2015-01-25 19:19     ` Steven Rostedt
2015-01-25 17:34   ` Jiri Olsa
2015-01-25 19:31     ` Steven Rostedt
2015-01-26  8:57       ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150125170203.GG31987@krava.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=rostedt@goodmis.org \
    --subject='Re: [PATCH 4/5] tools lib api fs: Add {tracefs,debugfs}_configured() functions' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).