LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 3/5 v2] tracing: Automatically mount tracefs on debugfs/tracing
Date: Sun, 25 Jan 2015 19:59:32 +0000	[thread overview]
Message-ID: <20150125195932.GH29656@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20150125143830.760c448a@gandalf.local.home>

On Sun, Jan 25, 2015 at 02:38:30PM -0500, Steven Rostedt wrote:
> On Sun, 25 Jan 2015 21:22:07 +0800
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 
> 
> > If we could do it in a non-racy way, that would be good, otherwise I
> > don't see us being able to even take this patch :(
> 
> Is it still racy even if it's only done at boot up? This path only gets
> hit the first time it is called. "if (tr->flags &TRACE_ARRAY_FL_GLOBAL)"
> is the top level tracing directory ("tracing") and is only called
> during boot up (fs_initcall) and never hit again. I could even make
> this called directly by that code so we could label it "__init" to make
> sure that it is to be never hit. Or is this racy even when done by
> fs_initcall?
> 
> Waiting for Al to comment on this, because, I can't add this feature
> until debugfs/tracing still containing the tracing information,
> otherwise it will break all the tools that interact with the tracing
> infrastructure, and we all know how happy Linus feels about such
> changes.

Actually, I'm almost done massaging that sucker into adding
debugfs_create_automount().  The only remaining question is what arguments
do we put it; for now I'm giving it dentry_operations + data (to go into
inode->i_private), but it might be better to give it a pointer just to
d_automount() callback + data for it...

  reply	other threads:[~2015-01-25 19:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-23 15:55 [PATCH 0/5 v2] tracing: Add new file system tracefs Steven Rostedt
2015-01-23 15:55 ` [PATCH 1/5 v2] tracefs: Add new tracefs file system Steven Rostedt
2015-01-23 15:55 ` [PATCH 2/5 v2] tracing: Convert the tracing facility over to use tracefs Steven Rostedt
2015-01-23 15:55 ` [PATCH 3/5 v2] tracing: Automatically mount tracefs on debugfs/tracing Steven Rostedt
2015-01-24  3:00   ` Greg Kroah-Hartman
2015-01-24 11:33     ` Steven Rostedt
2015-01-25 13:22       ` Greg Kroah-Hartman
2015-01-25 19:38         ` Steven Rostedt
2015-01-25 19:59           ` Al Viro [this message]
2015-01-25 20:27             ` Al Viro
2015-01-25 20:31               ` Al Viro
2015-01-23 15:55 ` [PATCH 4/5 v2] tracefs: Add directory /sys/kernel/tracing Steven Rostedt
2015-01-24  3:00   ` Greg Kroah-Hartman
2015-01-23 15:55 ` [PATCH 5/5 v2] tracing: Have mkdir and rmdir be part of tracefs Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150125195932.GH29656@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=rostedt@goodmis.org \
    --subject='Re: [PATCH 3/5 v2] tracing: Automatically mount tracefs on debugfs/tracing' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).