LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Matt Fleming <matt@codeblueprint.co.uk>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Andi Kleen <andi@firstfloor.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Kanaka Juvva <kanaka.d.juvva@intel.com>,
Vikas Shivappa <vikas.shivappa@linux.intel.com>,
Matt Fleming <matt.fleming@intel.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH 5/9] perf/x86/intel: Add Intel Cache QoS Monitoring support
Date: Sun, 25 Jan 2015 23:07:01 +0000 [thread overview]
Message-ID: <20150125230701.GC4148@codeblueprint.co.uk> (raw)
In-Reply-To: <20150125183455.GA15208@krava.brq.redhat.com>
On Sun, 25 Jan, at 07:34:55PM, Jiri Olsa wrote:
> On Fri, Jan 23, 2015 at 06:45:44PM +0000, Matt Fleming wrote:
>
> SNIP
>
> > + int phys_id = topology_physical_package_id(cpu);
> > + int i;
> > +
> > + for_each_cpu(i, &cqm_cpumask) {
> > + if (phys_id == topology_physical_package_id(i))
> > + return; /* already got reader for this socket */
> > + }
> > +
> > + cpumask_set_cpu(cpu, &cqm_cpumask);
> > +}
> > +
> > +static void intel_cqm_cpu_prepare(unsigned int cpu)
> > +{
> > + struct intel_cqm_state *state = &per_cpu(cqm_state, cpu);
> > + struct cpuinfo_x86 *c = &cpu_data(cpu);
> > +
> > + raw_spin_lock_init(&state->lock);
> > + state->rmid = 0;
>
> shouldn't you also init state->cnt?
Oops. Good catch, thanks!
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2015-01-25 23:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 18:45 [PATCH v5 0/9] perf: " Matt Fleming
2015-01-23 18:45 ` [PATCH 1/9] perf: Make perf_cgroup_from_task() global Matt Fleming
2015-02-26 4:14 ` [tip:perf/x86] " tip-bot for Matt Fleming
2015-01-23 18:45 ` [PATCH 2/9] perf: Add ->count() function to read per-package counters Matt Fleming
2015-02-26 4:14 ` [tip:perf/x86] " tip-bot for Matt Fleming
2015-01-23 18:45 ` [PATCH 3/9] perf: Move cgroup init before PMU ->event_init() Matt Fleming
2015-02-26 4:14 ` [tip:perf/x86] " tip-bot for Matt Fleming
2015-01-23 18:45 ` [PATCH 4/9] x86: Add support for Intel Cache QoS Monitoring (CQM) detection Matt Fleming
2015-02-26 4:14 ` [tip:perf/x86] x86: Add support for Intel Cache QoS Monitoring ( CQM) detection tip-bot for Peter P Waskiewicz Jr
2015-01-23 18:45 ` [PATCH 5/9] perf/x86/intel: Add Intel Cache QoS Monitoring support Matt Fleming
2015-01-25 18:34 ` Jiri Olsa
2015-01-25 23:07 ` Matt Fleming [this message]
2015-02-26 4:15 ` [tip:perf/x86] " tip-bot for Matt Fleming
2015-02-26 18:47 ` Matt Fleming
2015-02-26 19:40 ` Peter Zijlstra
2015-03-23 12:25 ` [tip:perf/x86] perf/x86/intel: Fix Makefile to actually build the cqm driver tip-bot for Matt Fleming
2015-01-23 18:45 ` [PATCH 6/9] perf/x86/intel: Implement LRU monitoring ID allocation for CQM Matt Fleming
2015-02-26 4:15 ` [tip:perf/x86] " tip-bot for Matt Fleming
2015-01-23 18:45 ` [PATCH 7/9] perf/x86/intel: Support task events with Intel CQM Matt Fleming
2015-02-26 4:15 ` [tip:perf/x86] " tip-bot for Matt Fleming
2015-03-04 4:16 ` Vince Weaver
2015-03-05 0:55 ` Ingo Molnar
2015-03-05 21:10 ` Peter Zijlstra
2015-03-23 12:26 ` [tip:perf/x86] perf: Remove type specific target pointers tip-bot for Peter Zijlstra
2015-01-23 18:45 ` [PATCH v5 8/9] perf/x86/intel: Perform rotation on Intel CQM RMIDs Matt Fleming
2015-02-26 4:16 ` [tip:perf/x86] " tip-bot for Matt Fleming
2015-01-23 18:45 ` [PATCH v5 9/9] perf/x86/intel: Enable conflicting event scheduling for CQM Matt Fleming
2015-02-26 4:16 ` [tip:perf/x86] " tip-bot for Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150125230701.GC4148@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=kanaka.d.juvva@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=vikas.shivappa@linux.intel.com \
--subject='Re: [PATCH 5/9] perf/x86/intel: Add Intel Cache QoS Monitoring support' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).